FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=releng%2F12.2 2018-05-18T20:13:34Z 2018-05-18T20:13:34Z Matt Macy mmacy@FreeBSD.org 2018-05-18T20:13:34Z urn:sha1:d7c5a620e2b99e914f1770abde956cf0d0a970b7 Run on LLNW canaries and tested by pho@ gallatin: Using a 14-core, 28-HTT single socket E5-2697 v3 with a 40GbE MLX5 based ConnectX 4-LX NIC, I see an almost 12% improvement in received packet rate, and a larger improvement in bytes delivered all the way to userspace. When the host receiving 64 streams of netperf -H $DUT -t UDP_STREAM -- -m 1, I see, using nstat -I mce0 1 before the patch: InMpps OMpps InGbs OGbs err TCP Est %CPU syscalls csw irq GBfree 4.98 0.00 4.42 0.00 4235592 33 83.80 4720653 2149771 1235 247.32 4.73 0.00 4.20 0.00 4025260 33 82.99 4724900 2139833 1204 247.32 4.72 0.00 4.20 0.00 4035252 33 82.14 4719162 2132023 1264 247.32 4.71 0.00 4.21 0.00 4073206 33 83.68 4744973 2123317 1347 247.32 4.72 0.00 4.21 0.00 4061118 33 80.82 4713615 2188091 1490 247.32 4.72 0.00 4.21 0.00 4051675 33 85.29 4727399 2109011 1205 247.32 4.73 0.00 4.21 0.00 4039056 33 84.65 4724735 2102603 1053 247.32 After the patch InMpps OMpps InGbs OGbs err TCP Est %CPU syscalls csw irq GBfree 5.43 0.00 4.20 0.00 3313143 33 84.96 5434214 1900162 2656 245.51 5.43 0.00 4.20 0.00 3308527 33 85.24 5439695 1809382 2521 245.51 5.42 0.00 4.19 0.00 3316778 33 87.54 5416028 1805835 2256 245.51 5.42 0.00 4.19 0.00 3317673 33 90.44 5426044 1763056 2332 245.51 5.42 0.00 4.19 0.00 3314839 33 88.11 5435732 1792218 2499 245.52 5.44 0.00 4.19 0.00 3293228 33 91.84 5426301 1668597 2121 245.52 Similarly, netperf reports 230Mb/s before the patch, and 270Mb/s after the patch Reviewed by: gallatin Sponsored by: Limelight Networks Differential Revision: https://reviews.freebsd.org/D15366 2017-11-27T14:52:40Z Pedro F. Giffuni pfg@FreeBSD.org 2017-11-27T14:52:40Z urn:sha1:718cf2ccb9956613756ab15d7a0e28f2c8e91cab Mainly focus on files that use BSD 2-Clause license, however the tool I was using misidentified many licenses so this was mostly a manual - error prone - task. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts. 2016-04-19T23:37:24Z Pedro F. Giffuni pfg@FreeBSD.org 2016-04-19T23:37:24Z urn:sha1:73a1170a8c41cb848f17cc0a8839e9dcee3d126e No functional change, only trivial cases are done in this sweep, Drivers that can get further enhancements will be done independently. Discussed in: freebsd-current 2016-02-18T01:24:10Z Pyun YongHyeon yongari@FreeBSD.org 2016-02-18T01:24:10Z urn:sha1:9dda5c8ffc7466f940ed2ae0b056c9ae39e3208a Found by: PVS-Studio 2014-09-18T21:16:05Z Gleb Smirnoff glebius@FreeBSD.org 2014-09-18T21:16:05Z urn:sha1:d5002dd19f203f34da46e02881631a12ee4d7bfb 2014-08-30T19:55:54Z Gleb Smirnoff glebius@FreeBSD.org 2014-08-30T19:55:54Z urn:sha1:1bffa9511fe94125820858b0ead796db54ac019d that resides in struct ifnet. Sponsored by: Nginx, Inc. 2014-06-11T14:53:58Z John Baldwin jhb@FreeBSD.org 2014-06-11T14:53:58Z urn:sha1:068d8643adb13434b57fdd5febf43a11194d508f In particular, don't check the value of the bus_dma map against NULL to determine if either bus_dmamem_alloc() or bus_dmamap_load() succeeded. Instead, assume that bus_dmamap_load() succeeeded (and thus that bus_dmamap_unload() should be called) if the bus address for a resource is non-zero, and assume that bus_dmamem_alloc() succeeded (and thus that bus_dmamem_free() should be called) if the virtual address for a resource is not NULL. In many cases these bugs could result in leaks when a driver was detached. Reviewed by: yongari MFC after: 2 weeks 2013-10-26T17:58:36Z Gleb Smirnoff glebius@FreeBSD.org 2013-10-26T17:58:36Z urn:sha1:76039bc84fae9915788b54ff28fe0cc4876952d2 to this event, adding if_var.h to files that do need it. Also, include all includes that now are included due to implicit pollution via if_var.h Sponsored by: Netflix Sponsored by: Nginx, Inc. 2013-08-12T23:30:01Z Scott Long scottl@FreeBSD.org 2013-08-12T23:30:01Z urn:sha1:c68534f1d5bab4ad466384c4fb9bb2956811e8b9 command register. The lazy BAR allocation code in FreeBSD sometimes disables this bit when it detects a range conflict, and will re-enable it on demand when a driver allocates the BAR. Thus, the bit is no longer a reliable indication of capability, and should not be checked. This results in the elimination of a lot of code from drivers, and also gives the opportunity to simplify a lot of drivers to use a helper API to set the busmaster enable bit. This changes fixes some recent reports of disk controllers and their associated drives/enclosures disappearing during boot. Submitted by: jhb Reviewed by: jfv, marius, achadd, achim MFC after: 1 day 2012-12-04T09:32:43Z Gleb Smirnoff glebius@FreeBSD.org 2012-12-04T09:32:43Z urn:sha1:c6499eccad497913a5025fbde8ae76da70e08043 malloc(9) flags in sys/dev.