src/sys/dev/sym, branch mainFreeBSD source treehttps://cgit-dev.freebsd.org/src/atom?h=main2026-02-02T21:57:56Zsym(4): Map HCB memory as uncacheable also on x862026-02-02T21:57:56ZMarius Stroblmarius@FreeBSD.org2026-02-02T21:30:42Zurn:sha1:b941d1c64e58708c93621cc07ed1c8e5e709cd48
As part of making the chip-specific mix and match of different accesses
(DMA/bus space) work as desired, the intent is to map the HCB memory as
uncacheable. Prior to VM_MEMATTR_*, the !x86 way of indicating this to
bus_dmamem_alloc(9) was BUS_DMA_COHERENT. Then later on in 2db99100a4,
BUS_DMA_NOCACHE was hooked up to VM_MEMATTR_UNCACHEABLE for x86. As it
turns out, still as of today bus_dmamem_alloc(9) differs in this regard
across architectures. On arm, it still supports BUS_DMA_COHERENT only
for requesting uncacheable DMA and x86 still uses BUS_DMA_NOCACHE only.
On arm64 and riscv, BUS_DMA_COHERENT seems to effectively be an alias
for BUS_DMA_NOCACHE.
Thus, allocate the HCB memory with BUS_DMA_COHERENT | BUS_DMA_NOCACHE,
so we get uncacheable memory on all architectures including x86 and so
loads and stores from/to HCB won't get reordered. However, even on x86
we still need to use at least compiler barriers to achieve the desired
program order.
This change should also fix panics due to out-of-sync data seen with
FreeBSD VMs on top of OpenStack and HBAs of type lsiLogic as a result
of loads and stores getting reordered. [1]
While at it:
- Nuke the unused SYM_DRIVER_NAME macro.
- Remove unused/redundant HCB members and correct a comment typo.
PR: 270816 [1]
MFC after: 3 days
Revert "sym(4): Employ memory barriers also on x86"2026-02-02T21:53:13ZMarius Stroblmarius@FreeBSD.org2026-01-28T21:20:42Zurn:sha1:bfbcd310bd4997c4ddb21bb81d61f2f29c68937c
The problem will be avoided in a different way.
This reverts commit e769bc77184312b6137a9b180c97b87c0760b849.
sym(4): Employ memory barriers also on x862026-01-26T15:54:48ZMarius Stroblmarius@FreeBSD.org2026-01-26T13:58:57Zurn:sha1:e769bc77184312b6137a9b180c97b87c0760b849
In an MP world, it doesn't hold that x86 requires no memory barriers.
This change should also fix panics due to out-of-sync data seen with
FreeBSD VMs on top of OpenStack and HBAs of type lsiLogic. [1]
While at it:
- Improve the granularity somewhat by distinguishing between read and
write memory barriers as well as refer to existing *mb(9) functions
instead of duplicating these [2], unless IO barriers are also used.
- Nuke the unused SYM_DRIVER_NAME macro.
PR: 270816 [1]
Obtained from: BSD-licensed Linux sym53c8xx driver [2]
MFC after: 1 week
sym(4): Provide a DEVICE_DETACH(9) method2026-01-26T15:54:48ZMarius Stroblmarius@FreeBSD.org2026-01-22T09:05:38Zurn:sha1:518c01b31e96bbe8353a551885a61e7da6aed5f6
This also fixes sym_cam_free() to tear things down correctly, i. e. in
opposite order of setup, as well as sym_cam_attach() to not free devq
and SIM twice in the failure case.
sym(4): Use memcpy(9) instead of bcopy(9)2026-01-26T15:54:47ZMarius Stroblmarius@FreeBSD.org2026-01-21T16:47:50Zurn:sha1:c8e9479c74a2af0f6c665e930091c163bf760fd5
The overlap handling of bcopy(9) is not required in these cases.
Obtained from: BSD-licensed Linux sym53c8xx driver
sym(4): Consistently use device_printf(9) where applicable2026-01-26T15:54:47ZMarius Stroblmarius@FreeBSD.org2026-01-21T17:29:35Zurn:sha1:48eee744b540ef0413fa1cb543dde6e49e7f2ac4style(9): white space after ; and around binary operators2025-10-16T22:02:50ZDavid E. O'Brienobrien@FreeBSD.org2025-10-15T05:22:00Zurn:sha1:0050289464fa56ec79e060b8d8378b9ff7145a0e
in for() loops. Also, use 'while', where only the
conditional test of 'for' was used.
Reviewed by: sjg
sym(4): Add __diagused to nseg of getbaddrcb()2023-08-18T14:33:27ZMarius Stroblmarius@FreeBSD.org2023-08-18T14:29:10Zurn:sha1:ae6d4963589418f2116ddc8cabcf93dd2f4bbf3b
The parameter is only used when compiling with INVARIANTS.
sys: Remove $FreeBSD$: one-line .c pattern2023-08-16T17:54:36ZWarner Loshimp@FreeBSD.org2023-08-16T17:54:36Zurn:sha1:685dc743dc3b5645e34836464128e1c0558b404b
Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
sys: Remove $FreeBSD$: one-line .c comment pattern2023-08-16T17:54:24ZWarner Loshimp@FreeBSD.org2023-08-16T17:54:24Zurn:sha1:71625ec9ad2a9bc8c09784fbd23b759830e0ee5f
Remove /^/[*/]\s*\$FreeBSD\$.*\n/