FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=release%2F14.3.0 2023-08-16T17:54:36Z 2023-08-16T17:54:36Z Warner Losh imp@FreeBSD.org 2023-08-16T17:54:36Z urn:sha1:685dc743dc3b5645e34836464128e1c0558b404b Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/ 2023-08-16T17:54:11Z Warner Losh imp@FreeBSD.org 2023-08-16T17:54:11Z urn:sha1:95ee2897e98f5d444f26ed2334cc7c439f9c16c6 Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/ 2023-05-12T16:44:03Z Warner Losh imp@FreeBSD.org 2023-05-10T15:40:58Z urn:sha1:4d846d260e2b9a3d4d0a701462568268cbfe7a5b The SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catch up to that fact and revert to their recommended match of BSD-2-Clause. Discussed with: pfg MFC After: 3 days Sponsored by: Netflix 2023-01-23T19:21:36Z Mitchell Horne mhorne@FreeBSD.org 2023-01-09T17:14:19Z urn:sha1:6f5141456ed07a24097c2cf3d6c389bf971d78d2 The code paths while dumping do not got through busdma. As such, safeguard against calling bus_dmamap_sync() with a NULL map. The x86 implementation tolerates this but others do not, resulting in a NULL dereference panic when dumping to a vtblk device on arm64, riscv, etc. Fixes: 782105f7c898 ("vtblk: Use busdma") Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D37990 2023-01-11T03:42:04Z Colin Percival cperciva@FreeBSD.org 2022-12-28T06:23:05Z urn:sha1:9af32ef5643bf35e1a2687269f2339dfb007ef36 Virtio operates with physical addresses, while busdma is designed to map these to produce bus addresses. On most supported platforms, these two are interchangeable; on powerpc platforms, they are not. When on powerpc, set an IOMMU of NULL, which causes the powerpc busdma code to bypass the iommu mapping; this leaves us with the physical buffer addresses which the virtio host expects to see. Tested by: alfredo Fixes: 782105f7c898 ("vtblk: Use busdma") Sponsored by: https://www.patreon.com/cperciva Differential Revision: https://reviews.freebsd.org/D37891 2022-11-03T07:52:43Z Colin Percival cperciva@FreeBSD.org 2022-11-03T01:55:12Z urn:sha1:75549de770df470b024c92ff093009c6987b40fd Now that vtblk uses busdma, it keeps important information inside its request structures. The functions used for kernel dumps synthesize their own request structures rather than using structures initialized with the necessary bits for busdma. Add busdma-bypass paths. Since dumping writes contiguous blocks of physical memory, vtblk doesn't need busdma in that case. Reported by: glebius Tested by: glebius Differential Revision: https://reviews.freebsd.org/D37243 2022-10-18T06:02:21Z Colin Percival cperciva@FreeBSD.org 2022-09-21T19:34:51Z urn:sha1:782105f7c89821552304245d71e107b867a3e934 We assume that bus addresses from busdma are the same thing as "physical" addresses in the Virtio specification; this seems to be true for the platforms on which Virtio is currently supported. For block devices which are limited to a single data segment per I/O, we request PAGE_SIZE alignment from busdma; this is necessary in order to support unaligned I/Os from userland, which may cross a boundary between two non-physically-contiguous pages. On devices which support more data segments per I/O, we retain the existing behaviour of limiting I/Os to (max data segs - 1) * PAGE_SIZE. Reviewed by: bryanv Sponsored by: https://www.patreon.com/cperciva Differential Revision: https://reviews.freebsd.org/D36667 2022-10-18T06:02:21Z Colin Percival cperciva@FreeBSD.org 2022-09-18T22:37:07Z urn:sha1:3a8aff9d087961c38ffa253c0594028a48363ece No functional change intended. Reviewed by: bryanv, imp Sponsored by: https://www.patreon.com/cperciva Differential Revision: https://reviews.freebsd.org/D36666 2022-10-18T06:02:21Z Colin Percival cperciva@FreeBSD.org 2022-09-18T16:16:30Z urn:sha1:cc25cfc9cf8a3d21d4f989eca9a4d1060d5d488e Most virtio_blk requests are launched from vtblk_startio; prior to this commit, if vtblk_request_execute failed (e.g. due to a lack of space on the virtio queue) vtblk_startio would requeue the request to be reattempted later. Add a flag "vbr_requeue_on_error" to requests and perform the requeuing from inside vtblk_request_execute instead. No functional change intended. Reviewed by: bryanv, imp Sponsored by: https://www.patreon.com/cperciva Differential Revision: https://reviews.freebsd.org/D36665 2022-10-18T06:02:21Z Colin Percival cperciva@FreeBSD.org 2022-09-18T01:02:54Z urn:sha1:86f8f5ccb798f336c23cb191f43f578ec9f44c8b The error, if any, now gets stashed in the request structure. (Step 1 of reworking this driver to use busdma.) No functional change intended. Reviewed by: bryanv, imp Sponsored by: https://www.patreon.com/cperciva Differential Revision: https://reviews.freebsd.org/D36664