FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=releng%2F14.3 2024-10-11T07:06:25Z 2024-10-11T07:06:25Z Roger Pau Monné royger@FreeBSD.org 2023-11-03T09:28:16Z urn:sha1:c1782c2d28a59fab389aa6457f109afe3e9b43fc Current cleanup code assumes that all the fields are allocated and/or setup by the time cleanup is called, but this is not always true: a failure in mid-setup of the device will cause the functions to be called with possibly uninitialized fields. Fix the functions to cope with such sate, while also attempting to make the cleanup idempotent. Finally fix an error path during setup that would not mark the device as closed, and hence prevents the kernel from finishing booting. Fixes: 96375eac945c ("xen-netfront: add multiqueue support") Sponsored by: Citrix Systems R&D (cherry picked from commit 318bbb6d5a1eae77eb5dc687bcc63c0f99558e21) 2024-08-20T13:27:05Z Mark Johnston markj@FreeBSD.org 2024-08-02T13:09:41Z urn:sha1:7178003234932e62dd552da9b39d2e6c35ed97f8 netmap's generic mode tries to improve performance by minimizing mbuf allocations. In service of this goal, it maintains an extra reference to the mbuf and polls the counter to see if the driver has released its reference by calling m_freem(). As a result, the extref destructor is not called when expected by the netfront driver, and mbufs tags are not freed. Modify the tx path to release its mbuf tags promptly when reclaiming tx descriptors. They are drawn from a fixed-size pool, so otherwise are quickly exhausted when a netfront interface is in netmap generic mode. Co-authored by: royger MFC after: 2 weeks Fixes: dabb3db7a817 ("xen/netfront: deal with mbuf data crossing a page boundary") Sponsored by: Cloud Software Group Sponsored by: Klara, Inc. Sponsored by: Zenarmor (cherry picked from commit 2e4781cb12af2d13262ed5decf6fd95c8d58d9f5) 2023-11-12T10:37:16Z Doug Rabson dfr@FreeBSD.org 2023-08-12T13:19:47Z urn:sha1:61ba094af4b4798bf2887c30af5c14d66ead706f The driver has a tunable hw.xn.enable_lro which is intended to control whether LRO is enabled. This is currently non-functional - even if its set to zero, the driver still requests LRO support from the backend. This change fixes the feature so that if enable_lro is set to zero, LRO no longer appears in the interface capabilities and LRO is not requested from the backend. PR: 273046 MFC after: 1 week Reviewed by: royger Differential Revision: https://reviews.freebsd.org/D41439 (cherry picked from commit da4b0d6eb06d730487d48e15d2d5e10c56266fd9) 2023-08-16T17:54:36Z Warner Losh imp@FreeBSD.org 2023-08-16T17:54:36Z urn:sha1:685dc743dc3b5645e34836464128e1c0558b404b Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/ 2023-05-12T16:44:03Z Warner Losh imp@FreeBSD.org 2023-05-10T15:40:58Z urn:sha1:4d846d260e2b9a3d4d0a701462568268cbfe7a5b The SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catch up to that fact and revert to their recommended match of BSD-2-Clause. Discussed with: pfg MFC After: 3 days Sponsored by: Netflix 2023-04-24T13:54:23Z Justin Hibbits jhibbits@FreeBSD.org 2022-03-01T17:52:45Z urn:sha1:02f3b17fa5967b15d3841d9f7df56264557d1bfb Reviewed by: zlei Sponsored by: Juniper Networks, Inc. Differential Revision: https://reviews.freebsd.org/D37800 2022-11-03T12:32:21Z Roger Pau Monné royger@FreeBSD.org 2022-11-03T12:29:22Z urn:sha1:dabb3db7a817f003af3f89c965ba369c67fc4910 There's been a report recently of mbufs with data that crosses a page boundary. It seems those mbufs are generated by the iSCSI target system: https://lists.xenproject.org/archives/html/xen-devel/2021-12/msg01581.html In order to handle those mbufs correctly on netfront use the bus_dma interface and explicitly request that segments must not cross a page boundary. No other requirements are necessary, so it's expected that bus_dma won't need to bounce the data and hence it shouldn't introduce a too big performance penalty. Using bus_dma requires some changes to netfront, mainly in order to accommodate for the fact that now ring slots no longer have a 1:1 match with mbufs, as a single mbuf can use two ring slots if the data buffer crosses a page boundary. Store the first packet of the mbuf chain in every ring slot that's used, and use a mbuf tag in order to store the bus_dma related structures and a refcount to keep track of the pending slots before the mbuf chain can be freed. Reported by: G.R. Tested by: G.R. MFC: 1 week Differential revision: https://reviews.freebsd.org/D33876 2022-05-06T22:46:58Z John Baldwin jhb@FreeBSD.org 2022-05-06T22:46:58Z urn:sha1:f929eb1ed50f079f1638cdabe511ac2e347f541a 2022-02-07T09:11:56Z Elliott Mitchell ehem+freebsd@m5p.com 2021-10-13T02:00:26Z urn:sha1:ad7dd5149910a7bc5ff5353a54393e64e3e74690 These headers originate with the Xen project and shouldn't be mixed with the main portion of the FreeBSD kernel. Notably they shouldn't be the target of clean-up commits. Switch to use the headers in sys/contrib/xen. Reviewed by: royger 2021-12-15T13:46:17Z Mateusz Guzik mjg@FreeBSD.org 2021-12-15T13:45:04Z urn:sha1:e7236a7ddf37ffe330d323c7b6037230d10afee4 Sponsored by: Rubicon Communications, LLC ("Netgate")