FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=release%2F10.1.0 2012-12-04T09:32:43Z 2012-12-04T09:32:43Z Gleb Smirnoff glebius@FreeBSD.org 2012-12-04T09:32:43Z urn:sha1:c6499eccad497913a5025fbde8ae76da70e08043 malloc(9) flags in sys/dev. 2012-11-05T19:16:27Z Dimitry Andric dim@FreeBSD.org 2012-11-05T19:16:27Z urn:sha1:29658c96ce9914fdf4ff4e3519fbec696ef32118 them, please let me know if not). Most of these are of the form: static const struct bzzt_type { [...list of members...] } const bzzt_devs[] = { [...list of initializers...] }; The second const is unnecessary, as arrays cannot be modified anyway, and if the elements are const, the whole thing is const automatically (e.g. it is placed in .rodata). I have verified this does not change the binary output of a full kernel build (except for build timestamps embedded in the object files). Reviewed by: yongari, marius MFC after: 1 week 2012-05-11T02:40:40Z Marius Strobl marius@FreeBSD.org 2012-05-11T02:40:40Z urn:sha1:e4029d4cac5e82fdda4e715c8a006a74e17adc70 deterministically handled after the corresponding PHY drivers when loaded as modules. Otherwise, when these MAC/PHY driver pairs are compiled into a single module probing the PHY driver may fail. This makes r151438 and r226154 actually work. [1] Reported and tested by: yongari (fxp(4)) - Use DEVMETHOD_END. - Use NULL instead of 0 for pointers. Submitted by: jhb [1] MFC after: 3 days 2011-11-23T20:27:26Z Marius Strobl marius@FreeBSD.org 2011-11-23T20:27:26Z urn:sha1:604f5f1f7790b303eb28109c3138dd3c1a1c0dff 2011-11-22T21:28:20Z Marius Strobl marius@FreeBSD.org 2011-11-22T21:28:20Z urn:sha1:4b7ec27007570e0ce4fe9dbb447e7afc131b487a one. Interestingly, these are actually the default for quite some time (bus_generic_driver_added(9) since r52045 and bus_generic_print_child(9) since r52045) but even recently added device drivers do this unnecessarily. Discussed with: jhb, marcel - While at it, use DEVMETHOD_END. Discussed with: jhb - Also while at it, use __FBSDID. 2011-11-01T16:13:59Z Marius Strobl marius@FreeBSD.org 2011-11-01T16:13:59Z urn:sha1:8c1093fc50ab084b2ddd4750290a23d62616e0b6 take advantage of it instead of duplicating it. This reduces the size of the i386 GENERIC kernel by about 4k. The only potential in-tree user left unconverted is xe(4), which generally should be changed to use miibus(4) instead of implementing PHY handling on its own, as otherwise it makes not much sense to add a dependency on miibus(4)/mii_bitbang(4) to xe(4) just for the MII bitbang'ing code. The common MII bitbang'ing code also is useful in the embedded space for using GPIO pins to implement MII access. - Based on lessons learnt with dc(4) (see r185750), add bus barriers to the MII bitbang read and write functions of the other drivers converted in order to ensure the intended ordering. Given that register access via an index register as well as register bank/window switching is subject to the same problem, also add bus barriers to the respective functions of smc(4), tl(4) and xl(4). - Sprinkle some const. Thanks to the following testers: Andrew Bliznak (nge(4)), nwhitehorn@ (bm(4)), yongari@ (sis(4) and ste(4)) Thanks to Hans-Joerg Sirtl for supplying hardware to test stge(4). Reviewed by: yongari (subset of drivers) Obtained from: NetBSD (partially) 2011-10-08T12:33:10Z Marius Strobl marius@FreeBSD.org 2011-10-08T12:33:10Z urn:sha1:112a855de73f1077df8308aede5ae11819b90853 drivers that only ever attach to a particular MAC driver, i.e. inphy(4), ruephy(4) and xlphy(4), to the directory where the respective MAC driver lives and only compile it into the kernel when the latter is also there, also removing it from miibus.ko and moving it into the module of the respective MAC driver. - While at it, rename exphy.c, which comes from NetBSD where the MAC driver it corresponds to also is named ex(4) instead of xl(4) but that in FreeBSD actually identifies itself as xlphy(4), and its function names accordingly for consistency. - Additionally while at it, fix some minor style issues like whitespace in the register headers and add multi-inclusion protection to inphyreg.h. 2011-06-21T22:17:28Z Warner Losh imp@FreeBSD.org 2011-06-21T22:17:28Z urn:sha1:3cb589872cc58c5da7e4beda4aebfeaba60abe9f 2011-06-21T22:16:04Z Warner Losh imp@FreeBSD.org 2011-06-21T22:16:04Z urn:sha1:0dcfaeeec59ddcdd8bf730ce15ae6f6504b507e9 2011-06-21T20:51:09Z Warner Losh imp@FreeBSD.org 2011-06-21T20:51:09Z urn:sha1:aa0ea4af6dae257a42f0c9bb80c18fbaa8874c8a thinks the card is gone.