src/sys/dev, branch mainFreeBSD source treehttps://cgit-dev.freebsd.org/src/atom?h=main2026-05-19T17:18:00Zvnic: Add missing #include2026-05-19T17:18:00ZJohn Baldwinjhb@FreeBSD.org2026-05-19T17:18:00Zurn:sha1:8c9dc47b5fcaf58a89b1511118b78a65737b20cc
Reported by: bz, olivier
Fixes: 6dc813301a17 ("sys: Use is_pci_device instead of direct comparisons to devclasses")
Sponsored by: Chelsio Communications
snd_hda: Reassign duplicate HDMI/DP pin sequences instead of disabling2026-05-19T12:25:51ZAbdelkader Boudihfreebsd@seuros.com2026-05-19T12:24:14Zurn:sha1:65341ec3172936804b081c8ceca9bae88f5c7192
Some firmware (e.g. Apple EFI on Sandy Bridge Mac hardware) programs all
HDMI/DP output pins in an association with identical sequence numbers.
The existing code disables the entire association on the first
duplicate, leaving HDMI/DP audio non-functional.
For digital output pins (HDMI/DP) with seq=0 duplicates, search for the
next free sequence slot and reassign the duplicate rather than
disabling.
The seq=0 restriction targets the known Apple firmware pattern; any
other duplicate sequence is more likely a genuine firmware error and the
association is still disabled.
Update first after reassignment so that hpredir is not left pointing at
a stale sequence. Non-digital and input associations retain the existing
disable behaviour.
MFC after: 1 week
Reviewed by: christos
Differential Revision: https://reviews.freebsd.org/D55473
iwx: clean up / document noise floor and RSSI fetching2026-05-19T05:27:59ZAdrian Chaddadrian@FreeBSD.org2025-11-16T03:13:59Zurn:sha1:e56f7becc7efe05acbb08162961dca574b152720
* Document what iwx_rxmq_get_signal_strength() is doing in a comment,
noting what the firmware returns and what math is being done on it
to turn it into a dBm value.
* Document what iwx_get_noise() is supposed to do, that we can't just
go do math with log numbers like we're doing, but also that we're
seeing zeros in this firmware (AX210), which may mean we're decoding
using the wrong structs.
* Swizzle around the RSSI calculation as a function, add min/max RSSI
values, and calculate RSSI against the noise floor.
* And handle the lowest noise floor value - it can't be -127dBm as
that will throw things off. Cap it at -100dBm which is a little
lower than the thermal noise floor at 20MHz (-98dBm), but it matches
IWX_MIN_DBM.
Differential Revision: https://reviews.freebsd.org/D53780
sys: Use is_pci_device instead of checking device or devclass names2026-05-18T18:52:39ZJohn Baldwinjhb@FreeBSD.org2026-05-18T18:52:39Zurn:sha1:be4f245e1e4fe60d43aaff5b11b45f2a9a66a51c
Reviewed by: bz, imp
Sponsored by: Chelsio Communications
Differential Revision: https://reviews.freebsd.org/D56998
sys: Use is_pci_device instead of direct comparisons to devclasses2026-05-18T18:52:23ZJohn Baldwinjhb@FreeBSD.org2026-05-18T18:52:23Zurn:sha1:6dc813301a173e2e1993c3064df162e6218c1231
Reviewed by: bz
Sponsored by: Chelsio Communications
Differential Revision: https://reviews.freebsd.org/D56997
pci: Add is_pci_device helper function2026-05-18T18:50:39ZJohn Baldwinjhb@FreeBSD.org2026-05-18T18:50:39Zurn:sha1:ffcf5e356644252f2f6c89ba01057af45c216559
This returns true if a given device is a PCI device (child of a PCI
bus).
Reviewed by: bz, kib
Sponsored by: Chelsio Communications
Differential Revision: https://reviews.freebsd.org/D56996
qcom_tlmm: remove annoying debugging2026-05-18T17:04:11ZAdrian Chaddadrian@FreeBSD.org2026-05-18T17:03:20Zurn:sha1:32f854663d76ea06529ca8990ec0d116c8acb32b
Yes this printf is for local debugging and not required at all on anything.
Pointed out by: andrew@
Revert "asmc: fix asmc_key_dump() page fault on T2 MMIO backend"2026-05-18T16:58:59ZAdrian Chaddadrian@FreeBSD.org2026-05-18T16:58:59Zurn:sha1:af5cdcd8b18c9a24cc317f1886dd3c32b253ef27
This reverts commit 3abc07947c14f5c30e5328d56a2da8dbf8412ebf.
I'm not sure how this built locally for me but obviously failed
in CI; I'll go figure that out with the submitter and come back.
asmc: fix asmc_key_dump() page fault on T2 MMIO backend2026-05-18T14:01:20ZAbdelkader Boudihfreebsd@seuros.com2026-05-18T14:01:20Zurn:sha1:3abc07947c14f5c30e5328d56a2da8dbf8412ebf
asmc_key_dump() used I/O port macros (ASMC_DATAPORT_WRITE/READ,
asmc_command()) unconditionally. On T2 Macs, sc_ioport is NULL
(MMIO backend is used instead), causing a page fault when
ASMC_DEBUG triggers asmc_dumpall() during attach.
Add an MMIO guard at the top of asmc_key_dump(): delegate to
asmc_key_dump_by_index() + asmc_key_read() for MMIO devices,
consistent with the rest of the T2 code paths.
Reviewed by: adrian
Differential Revision: https://reviews.freebsd.org/D56748
kernel: address executable stack warnings in amd64 gcc build2026-05-16T20:24:45ZRyan Libbyrlibby@FreeBSD.org2026-05-16T20:24:45Zurn:sha1:755c1e039adfd68ecf4d5954e13fe54263c34a03
Mark assembly files as not requiring executable stacks.
Reviewed by: kib
Differential Revision: https://reviews.freebsd.org/D56946