FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=releng%2F14.1 2024-10-29T18:43:16Z 2024-10-29T18:43:16Z Pierre Pronchery pierre@freebsdfoundation.org 2024-08-27T13:57:32Z urn:sha1:9b11b889402aa3f85545464f4ead5da537638a12 Avoid a race condition when accessing guest memory, by reading memory contents only once. This has also been applied to _vq_record() in sys/dev/beri/virtio/virtio.c, as per markj@'s suggestion. Reported by: Synacktiv Reviewed by: markj Security: HYP-10 Security: FreeBSD-SA-24:17.bhyve Approved by: so Sponsored by: The Alpha-Omega Project Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D45735 (cherry picked from commit 869d760cb9d7a307faa2fbe8c1c2b238a81b74d4) (cherry picked from commit ed03c309908687bdb9f71dc6d9c9c8a92c54fc20) 2024-05-22T13:22:40Z Christos Margiolis christos@FreeBSD.org 2024-05-20T14:18:33Z urn:sha1:8d3f96bd85c9519cef76d0727b00082354a2134b The current check is never false and if nvlist_unpack() fails, we might panic later down the road. PR: 266144 Sponsored by: The FreeBSD Foundation MFC after: 1 day Reviewed by: dev_submerge.ch, emaste Differential Revision: https://reviews.freebsd.org/D45237 (cherry picked from commit 64f4e2db6d19d8ab520903a197fcaa8cc7ab9f9a) (cherry picked from commit 45feaa73c68011bbba647d1eb6f86a166a0453e9) Approved by: re (cperciva) 2024-05-22T13:22:26Z Christos Margiolis christos@FreeBSD.org 2024-05-20T14:18:28Z urn:sha1:18f80d6d463495703f9eb2ccfd92bae93c7889a3 SNDSTIOC_ADD_USER_DEVS* expects a user-supplied sndstioc_nv_arg->nbytes, however we currently do not check whether this size is actually valid, which results in a panic when SNDSTIOC_ADD_USER_DEVS* is called with an invalid size. sndstat_add_user_devs() calls sndstat_unpack_user_nvlbuf(), which then calls malloc() with that size. PR: 266142 Sponsored by: The FreeBSD Foundation MFC after: 1 day Reviewed by: brooks Differential Revision: https://reviews.freebsd.org/D45236 (cherry picked from commit 074d337ad618f9cc2a1d5ab18b484928e57bd72b) (cherry picked from commit 5830a00c2c5485ec17900558e4f29c459c6a1f3e) Approved by: re (cperciva) 2024-05-22T13:22:10Z Christos Margiolis christos@FreeBSD.org 2024-05-14T13:42:15Z urn:sha1:5a9a2f5eed47f76e953b546a38d5f368eaee4828 Sponsored by: The FreeBSD Foundation MFC after: 3 days Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D45105 (cherry picked from commit 278953360e0e6187c3f7c688cb49254df1567f0b) (cherry picked from commit 7814ed2bd321dff2bbec8408c5b64cb7f4f2dfc5) Approved by: re (cperciva) 2024-05-22T13:21:56Z Christos Margiolis christos@FreeBSD.org 2024-05-14T13:42:04Z urn:sha1:cb23e0eebfe21d64c2a478bdd4ebfa56d31a37e4 Reported by: bsd-lists@bsdforge.com Sponsored by: The FreeBSD Foundation MFC after: 3 days Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D45100 (cherry picked from commit 54cc353f505dbc5f19168b6b1417b6736433d9ae) (cherry picked from commit 9a620018afb2da062fce11e866a2154765886983) Approved by: re (cperciva) 2024-05-22T13:21:36Z Christos Margiolis christos@FreeBSD.org 2024-05-09T19:08:01Z urn:sha1:a0ff4e0f3e02d31e01844295f216ec87826130de According to the OSS manual, oss_sysinfo->numcards holds the number of detected audio devices in the system, while the current ncards variable, whose value is assigned to oss_sysinfo->numcards, holds the number of currently registered devices only. Sponsored by: The FreeBSD Foundation MFC after: 3 days Reviewed by: dev_submerge.ch, emaste Differential Revision: https://reviews.freebsd.org/D45136 (cherry picked from commit 59d98edae3e1a6fffd292e4393c49862d624f25f) (cherry picked from commit 2b3698288771f6d236212f80b1a259aa86e09fa8) Approved by: re (cperciva) 2024-05-22T13:20:42Z Christos Margiolis christos@FreeBSD.org 2024-05-09T19:07:48Z urn:sha1:a4a473104ec4a42c66f1b9a09736954ebad43e7e nmix is used to compare against oss_mixerinfo->dev, which is a user-supplied value to select the mixer device (if not -1, in which case we'll select the default one) we want to fetch the information of. It is also used to set oss_mixerinfo->dev in case it is -1. However, nmix is at best redundant, since we have the loop counter already (i), and confusing at worst. For example, suppose a system with 3 mixer devices. We call SNDCTL_MIXERINFO with oss_mixerinfo->dev=1, meaning we want to get information for /dev/mixer1. Suppose /dev/mixer0 detaches while inside the loop, so we'll hit the loop's "continue" case, and nmix won't get incremented (i.e will stay 0 for now). At this point nmix counts 1 device less, so when it reaches 1, we'll be fetching /dev/mixer2's information instead of /dev/mixer1's. This is also true in case the mixer device disappears prior to the call to mixer_oss_mixerinfo(). Simply remove nmix and use the loop counter to both set oss_mixerinfo->dev and check against it in case a non -1 value is supplied. Sponsored by: The FreeBSD Foundation MFC after: 3 days Reviewed by: dev_submerge.ch Differential Revision: https://reviews.freebsd.org/D45135 (cherry picked from commit 2f31a5eb75f1e47b5c49f574e8ce48d2c863e9d3) (cherry picked from commit 8b4e2ba31d1b171f688cb630f1827ec397ecaacb) Approved by: re (cperciva) 2024-05-21T20:08:35Z Lexi Winter lexi@le-Fay.ORG 2024-04-12T16:47:16Z urn:sha1:78ccc5af3d23fe6c7d87c5f40cf6ab2b1d9d6fb2 irdma_get_vlan_ipv4() calls ip_ifp_find() even if INET isn't defined, in which case this function isn't available. Stub this out for the non-INET case to return an error (0xffff) instead. Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/1156 (cherry picked from commit 0478a0356272ab3907af9d97711f0bb8b14bf38b) (cherry picked from commit 7aba922879474189e5694ffb92a51ab387ad3dd6) Approved-by: re (cperciva) 2024-05-02T13:25:08Z Mark Johnston markj@FreeBSD.org 2024-04-23T16:19:08Z urn:sha1:bff26fe7aa07173729bff549a00cc355bc977baf No functional change intended. MFC after: 1 week (cherry picked from commit b6a0ed7c78dd45937e404706620467bef61c308d) 2024-05-02T13:25:08Z Mark Johnston markj@FreeBSD.org 2024-04-23T16:18:21Z urn:sha1:4ee7b8e1ef3c5f8ee0b2853fc719f9bf186577ee No functional change intended. MFC after: 1 week (cherry picked from commit 964064937ea04519bd400668dc1ce38848d50901)