src/sys/fs/devfs, branch release/13.2.0FreeBSD source treehttps://cgit-dev.freebsd.org/src/atom?h=release%2F13.2.02022-02-09T06:18:56Zfs: fix a few common typos in source code comments2022-02-09T06:18:56ZGordon Berglinggbe@FreeBSD.org2022-02-06T12:48:31Zurn:sha1:061c19c2bd29454eba63d33526fde8f5b5274477
- s/quadradically/quadratically/
- s/persistant/persistent/
Obtained from: NetBSD
(cherry picked from commit 8ea3ceda7644b7b93532d0c31b50ac5fa61e51a3)
devfs: fix use count leak when using TIOCSCTTY2021-04-10T05:57:55ZMateusz Guzikmjg@FreeBSD.org2021-02-08T22:10:57Zurn:sha1:c3437848d8683f6ad03a15bde201c4ead541378e
by matching devfs_ctty_ref
Fixes: 3b44443626603f65 ("devfs: rework si_usecount to track opens")
(cherry picked from commit 3bc17248d31794519ba95b2c6b9ff8a0d31dba81)
devfs(4): defer freeing until we drop devmtx ("cdev")2020-12-29T13:47:36ZEdward Tomasz Napieralatrasz@FreeBSD.org2020-12-29T13:45:53Zurn:sha1:4ddb3cc5973b94b0502e1683accac87998235857
Before r332974 the old code would sometimes cause a rare lock order
reversal against pagequeue, which looked roughly like this:
witness_checkorder()
__mtx_lock-flags()
vm_page_alloc()
uma_small_alloc()
keg_alloc_slab()
keg_fetch-slab()
zone_fetch-slab()
zone_import()
zone_alloc_bucket()
uma_zalloc_arg()
bucket_alloc()
uma_zfree_arg()
free()
devfs_metoo()
devfs_populate_loop()
devfs_populate()
devfs_rioctl()
VOP_IOCTL_APV()
VOP_IOCTL()
vn_ioctl()
fo_ioctl()
kern_ioctl()
sys_ioctl()
Since r332974 the original problem no longer exists, but it still
makes sense to move things out of the - often congested - lock.
Reviewed By: kib, markj
Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.
Differential Revision: https://reviews.freebsd.org/D27334
fs: clean up empty lines in .c and .h files2020-09-01T21:18:40ZMateusz Guzikmjg@FreeBSD.org2020-09-01T21:18:40Zurn:sha1:586ee69f09c5060621486b34722a4a806581f93ddevfs: Abstract locking assertions2020-08-12T00:32:31ZConrad Meyercem@FreeBSD.org2020-08-12T00:32:31Zurn:sha1:0ac9e27ba964b4d29ed180d5e546873de638822c
The conversion was largely mechanical: sed(1) with:
-e 's|mtx_assert(&devmtx, MA_OWNED)|dev_lock_assert_locked()|g'
-e 's|mtx_assert(&devmtx, MA_NOTOWNED)|dev_lock_assert_unlocked()|g'
The definitions of these abstractions in fs/devfs/devfs_int.h are the
only non-mechanical change.
No functional change.
devfs: rework si_usecount to track opens2020-08-11T14:27:57ZMateusz Guzikmjg@FreeBSD.org2020-08-11T14:27:57Zurn:sha1:3b44443626603f65bba2804f08a7dfa6e6675bb4
This removes a lot of special casing from the VFS layer.
Reviewed by: kib (previous version)
Tested by: pho (previous version)
Differential Revision: https://reviews.freebsd.org/D25612
devfs: bool -> int2020-08-10T11:46:39ZMateusz Guzikmjg@FreeBSD.org2020-08-10T11:46:39Zurn:sha1:ca423b858bf4800bb22963e8133b72499bb18d24
Fixes buildworld after r364069
devfs: save on spurious relocking for devfs_populate2020-08-10T10:36:43ZMateusz Guzikmjg@FreeBSD.org2020-08-10T10:36:43Zurn:sha1:7b19bddac8f6ae5a356ffbca80f087d3654b8363
Tested by: pho
devfs: use cheaper lockmgr entry points2020-08-10T10:36:10ZMateusz Guzikmjg@FreeBSD.org2020-08-10T10:36:10Zurn:sha1:f8935a96d1bc34839cf10ea1ddc45afbdab513d4
Tested by: pho
devfs: use vget_prep/vget_finish2020-08-10T10:35:47ZMateusz Guzikmjg@FreeBSD.org2020-08-10T10:35:47Zurn:sha1:f9c13ab856573b95d27b4349b456de513c2d11af
Tested by: pho