src/sys/net, branch releng/12.4

if_vxlan(4): Check the size of data available in mbuf before using them

2022-11-04T12:21:45Z

PR: 261711 Reviewed by: kp Tested by: Alfa (burak.sn at outlook.com) Approved by: re (gjb), kp (mentor) Differential Revision: https://reviews.freebsd.org/D36794 (cherry picked from commit 8707cb19e68128c181477d87f960182c14e15f12) (cherry picked from commit 639aebb2aa0b72c569f8779e13351d37f7bb17c6)

iflib: Allow drivers to determine which queue to TX on

2022-10-19T22:23:33Z

Adds a new function pointer to struct if_txrx in order to allow drivers to set their own function that will determine which queue a packet should be sent on. Since this includes a kernel ABI change, bump the __FreeBSD_version as well. (This motivation behind this is to allow the driver to examine the UP in the VLAN tag and determine which queue to TX on based on that, in support of HW TX traffic shaping.) Signed-off-by: Eric Joyner Reviewed by: kbowling@, stallamr@netapp.com Tested by: jeffrey.e.pieper@intel.com Sponsored by: Intel Corporation Differential Revision: https://reviews.freebsd.org/D31485 (cherry picked from commit 213e91399b7998554d787bb290109ebe602aa279)

bpf(3): Grammar fix for a source code comment

2022-09-07T07:55:12Z

- s/that that/that the/ (cherry picked from commit 8a153724cd464e7fb156203dfb1304c90cfaec1c)

netisr(9): Fix a typo in a source code comment

2022-09-06T05:45:26Z

- s/overriden/overridden/ (cherry picked from commit 028ecc7aa1a06abdae96ba076189dc973d075042)

altq: improve pfctl config time for large numbers of queues

2022-08-18T07:12:17Z

In the current implementation of altq_hfsc.c, whne new queues are being added (by pfctl), each queue is added to the tail of the siblings linked list under the parent queue. On a system with many queues (50,000+) this leads to very long load times at the insertion process must scan the entire list for every new queue, Since this list is unordered, this changes merely adds the new queue to the head of the list rather than the tail. Reviewed by: kp MFC after: 3 weeks Sponsored by: RG Nets Differential Revision: https://reviews.freebsd.org/D35964 (cherry picked from commit 13890d30f8b215b84800cce3f161ad5148c82c00)

if_vlan: avoid hash table thrashing when adding and removing entries

2022-08-05T11:54:32Z

vlan_remhash() uses incorrect value for b. When using the default value for VLAN_DEF_HWIDTH (4), the VLAN hash-list table expands from 16 chains to 32 chains as the 129th entry is added. trunk->hwidth becomes 5. Say a few more entries are added and there are now 135 entries. trunk-hwidth will still be 5. If an entry is removed, vlan_remhash() will calculate a value of 32 for b. refcnt will be decremented to 134. The if comparison at line 473 will return true and vlan_growhash() will be called. The VLAN hash-list table will be compressed from 32 chains wide to 16 chains wide. hwidth will become 4. This is an error, and it can be seen when a new VLAN is added. The table will again be expanded. If an entry is then removed, again the table is contracted. If the number of VLANS stays in the range of 128-512, each time an insert follows a remove, the table will expand. Each time a remove follows an insert, the table will be contracted. The fix is simple. The line 473 should test that the number of entries has decreased such that the table should be contracted using what would be the new value of hwidth. line 467 should be: b = 1 << (trunk->hwidth - 1); PR: 265382 Reviewed by: kp MFC after: 2 weeks Sponsored by: NetApp, Inc. (cherry picked from commit 151abc80cde778bc18b91c334d07fbd52bbb38fb)

Fix unused variable warning in iflib.c

2022-07-24T11:01:21Z

With clang 15, the following -Werror warning is produced: sys/net/iflib.c:993:8: error: variable 'n' set but not used [-Werror,-Wunused-but-set-variable] u_int n; ^ The 'n' variable appears to have been a debugging aid that has never been used for anything, so remove it. MFC after: 3 days (cherry picked from commit 0294e95da4aa272906d4472137b1235d8d8a7180)

Fix unused variable warning in if_lagg.c

2022-07-24T11:01:21Z

With clang 15, the following -Werror warning is produced: sys/net/if_lagg.c:2413:6: error: variable 'active_ports' set but not used [-Werror,-Wunused-but-set-variable] int active_ports = 0; ^ The 'active_ports' variable appears to have been a debugging aid that has never been used for anything (ref https://reviews.freebsd.org/D549), so remove it. MFC after: 3 days (cherry picked from commit fa267a329ffa3d0e02c3c3a52dd5df5231d92cba)

if_llatbl: Fix a typo in a debug statement

2022-06-10T12:40:56Z

- s/droped/dropped/ Obtained from: NetBSD (cherry picked from commit 4f493559b0d7853c7521bd3cb5affe659914e479)

if_bridge(4): Fix a typo in a source code comment

2022-06-10T12:40:29Z

- s/accross/across/ (cherry picked from commit f7faa4ad4844470058b84fa35156c463cfa8bd85)