src/sys/netinet/ip_input.c, branch releng/6.1

MFC rev. 1.315

2006-03-04T09:16:11Z

Fix five years old bug in ip_reass(): if we are using 'full' (i.e. including pseudo header) hardware rx checksum offloading ip_reass() fails to calculate TCP/UDP checksum for reassembled packet correctly. Reviewed by: sam (earlier version), bde Approved by: re (scottl)

Merge ip_input.c:1.311 from HEAD to RELENG_6:

2006-02-13T23:46:31Z

Modify the IP fragment reassembly code so that it uses a new UMA zone, ipq_zone, to allocate fragment headers from, rather than using cast mbuf storage. This was one of the few remaining uses of mbuf storage for local data structures that relied on dtom(). Implement the resource limit on ipq's using UMA zone limits, but preserve current sysctl semantics using a sysctl proc. Approved by: re (scottl)

MFC ip_input.c:1.310:

2006-02-13T23:44:20Z

Staticize ipqlock, since it is local to ip_input.c. Approved by: re (scottl)

MFC 1.312: In ip_forward() compute MTU always if it hasn't been done before.

2006-01-31T16:17:22Z

MFC (by andre)

2005-10-09T04:24:45Z

Merge subr_witness.c:1.196, igmp.c:1.49, in.c:1.86, in_var.h:1.55,

2005-08-24T17:30:44Z

ip_input.c:1.303, ip_output.c:1.243 from HEAD to RELENG_6: Introduce in_multi_mtx, which will protect IPv4-layer multicast address lists, as well as accessor macros. For now, this is a recursive mutex due code sequences where IPv4 multicast calls into IGMP calls into ip_output(), which then tests for a multicast forwarding case. For support macros in in_var.h to check multicast address lists, assert that in_multi_mtx is held. Acquire in_multi_mtx around iteration over the IPv4 multicast address lists, such as in ip_input() and ip_output(). Acquire in_multi_mtx when manipulating the IPv4 layer multicast addresses, as well as over the manipulation of ifnet multicast address lists in order to keep the two layers in sync. Lock down accesses to IPv4 multicast addresses in IGMP, or assert the lock when performing IGMP join/leave events. Eliminate spl's associated with IPv4 multicast addresses, portions of IGMP that weren't previously expunged by IGMP locking. Add in_multi_mtx, igmp_mtx, and if_addr_mtx lock order to hard-coded lock order in WITNESS, in that order. Problem reported by: Ed Maste Approved by: re (scottl)

Merge ip_input.c:1.302 from HEAD to RELENG_6:

2005-07-20T12:03:38Z

Remove spl() calls from ip_slowtimo(), as IP fragment queue locking was merged several years ago. Approved by: re (kensmith)

Pass icmp_error() the MTU argument directly instead of

2005-05-04T13:09:19Z

an interface pointer. This simplifies a couple of uses and removes some XXX workarounds.

o Nano optimize ip_reass() code path for the first fragment: do not

2005-04-08T10:25:13Z

try to reasseble the packet from the fragments queue with the only fragment, finish with the first fragment as soon as we create a queue. Spotted by: Vijay Singh o Drop the fragment if maxfragsperpacket == 0, no chances we will be able to reassemble the packet in future. Reviewed by: silby

plug resource leak

2005-03-16T05:27:19Z

Noticed by: Coverity Prevent analysis tool