src/sys/netinet/ip_mroute.c, branch releng/13.3FreeBSD source treehttps://cgit-dev.freebsd.org/src/atom?h=releng%2F13.32023-10-02T08:28:23Zip_mroute: Fix sysctl knobs2023-10-02T08:28:23ZZhenlei Huangzlei@FreeBSD.org2023-09-27T16:23:22Zurn:sha1:ef3edef9ec8b7d19e5f66c385340604ab29ccc78
The loader tunable `net.inet.ip.mfchashsize` does not have corresponding
sysctl MIB entry. Just add it.
While here, the sysctl variable `net.inet.pim.squelch_wholepkt` is actually
a loader tunable. Add sysctl flag CTLFLAG_TUN to it so that `sysctl -T`
will report it correctly.
Reviewed by: kp
Fixes: 443fc3176dee Introduce a number of changes to the MROUTING code
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D41997
(cherry picked from commit f549e22901b3a391c76659bee55802b1214112fd)
(cherry picked from commit b0f026435a150933ecb6f2d1359fd1b4898657f1)
sys: Remove $FreeBSD$: one-line .c pattern2023-08-23T17:43:25ZWarner Loshimp@FreeBSD.org2023-08-22T01:31:27Zurn:sha1:3bc80996974a61a4223eae4c1ccd47b6ee32a48a
Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
Similar commit in current:
(cherry picked from commit 685dc743dc3b)
ip_mroute: Delete unreachable code2023-05-17T09:57:07ZZhenlei Huangzlei@FreeBSD.org2023-04-23T04:47:57Zurn:sha1:ece63e96c364679e19c124d145abe5af789d1948
As the flag M_WAITOK is passed to ip_encap_attach(), then the function
will never return NULL, and the following code within NULL check branch
will be unreachable.
No functional change intended.
Reviewed by: kp
Fixes: 6d8fdfa9d5e7d Rework IP encapsulation handling code
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D39746
(cherry picked from commit b658c0fce10a06493dc468fc9f6699120473e17b)
socket: Implement SO_RERROR2021-08-11T01:54:00ZRoy Marplesroy@marples.name2021-07-28T15:46:59Zurn:sha1:f45271340836769d53320d6dbcf63226bb4e39e3
SO_RERROR indicates that receive buffer overflows should be handled as
errors. Historically receive buffer overflows have been ignored and
programs could not tell if they missed messages or messages had been
truncated because of overflows. Since programs historically do not
expect to get receive overflow errors, this behavior is not the
default.
This is really really important for programs that use route(4) to keep
in sync with the system. If we loose a message then we need to reload
the full system state, otherwise the behaviour from that point is
undefined and can lead to chasing bogus bug reports.
Reviewed by: philip (network), kbowling (transport), gbe (manpages)
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D26652
(cherry picked from commit 7045b1603bdf054145dd958a4acc17b410fb62a0)
ip_mroute: fix the viftable export sysctl2020-10-11T00:01:00ZBjoern A. Zeebbz@FreeBSD.org2020-10-11T00:01:00Zurn:sha1:506512b170b659bfde6efc18beb344bc9eeaf955
It seems that in r354857 I got more than one thing wrong.
Convert the SYSCTL_OPAQUE to a SYSCTL_PROC to properly export the these
days allocated and not longer static per-vnet viftable array.
This fixes a problem with netstat -g which would show bogus information
for the IPv4 Virtual Interface Table.
PR: 246626
Reported by: Ozkan KIRIK (ozkan.kirik gmail.com)
MFC after: 3 days
net: clean up empty lines in .c and .h files2020-09-01T21:19:14ZMateusz Guzikmjg@FreeBSD.org2020-09-01T21:19:14Zurn:sha1:662c13053f4bf2d6245ba7e2b66c10d1cd5c1fb9Rather than zeroing MAXVIFS times size of pointer [r362289] (still better than2020-06-21T22:09:30ZBjoern A. Zeebbz@FreeBSD.org2020-06-21T22:09:30Zurn:sha1:e387af1fa85e86b570b02d258c0e99b749de950d
sizeof pointer before [r354857]), we need to zero MAXVIFS times the size of
the struct. All good things come in threes; I hope this is it on this one.
PR: 246629, 206583
Reported by: kib
MFC after: ASAP
When converting the static arrays to mallocarray() in r356621 I missed2020-06-17T21:04:38ZBjoern A. Zeebbz@FreeBSD.org2020-06-17T21:04:38Zurn:sha1:ce19cceb8dbe3b9600d8f9174e86ed4f6ec44956
one place where we now need to multiply the size of the struct with the
number of entries. This lead to problems when restarting user space
daemons, as the cleanup was never properly done, resulting in MRT_ADD_VIF
EADDRINUSE.
Properly zero all array elements to avoid this problem.
PR: 246629, 206583
Reported by: (many)
MFC after: 4 days
Sponsored by: Rubicon Communications, LLC (d/b/a "Netgate")
The call into ifa_ifwithaddr() needs to be epoch protected; ortherwise2020-06-17T20:58:37ZBjoern A. Zeebbz@FreeBSD.org2020-06-17T20:58:37Zurn:sha1:b7b3d237e74e4afe2e153dd35254a7fbae0efe3c
we'll panic on an assertion.
While here, leave a comment that the ifp was never protected and stable
(as glebius pointed out) and this needs to be fixed properly.
Discovered while working on: PR 246629
Reviewed by: glebius
MFC after: 4 days
Sponsored by: Rubicon Communications, LLC (d/b/a "Netgate")
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many)2020-02-26T14:26:36ZPawel Biernackikaktus@FreeBSD.org2020-02-26T14:26:36Zurn:sha1:7029da5c36f2d3cf6bb6c81bf551229f416399e8
r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are
still not MPSAFE (or already are but aren’t properly marked).
Use it in preparation for a general review of all nodes.
This is non-functional change that adds annotations to SYSCTL_NODE and
SYSCTL_PROC nodes using one of the soon-to-be-required flags.
Mark all obvious cases as MPSAFE. All entries that haven't been marked
as MPSAFE before are by default marked as NEEDGIANT
Approved by: kib (mentor, blanket)
Commented by: kib, gallatin, melifaro
Differential Revision: https://reviews.freebsd.org/D23718