src/sys/netinet/libalias/alias_proxy.c, branch releng/12.4

ipfw: Have NAT steal the TH_RES1 bit, instead of the TH_AE bit

2022-11-10T15:01:21Z

The NAT module use of the tcphdr.th_x2 field now collides with the use of this TCP header flag as AccECN (AE) bit. Use the topmost bit instead to allow negotiation of AccECN across a NAT device. Event: IETF 115 Hackathon Reviewed By: #transport, tuexen MFC after: 3 days Approved by: re (gjb) Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D37300 (cherry picked from commit 0b00b801493aa1d4996b0891ea58fbef343f85df) (cherry picked from commit 9839a5ad3a683c3841ec00c9e1a4d551dcf9c1de)

libalias(3): Fix two typos in source code comments

2022-04-14T06:40:03Z

- s/modfied/modified/ (cherry picked from commit 1cfd924f4e7ca3dc742905aaf5d828a21ad88191)

libalias: Style cleanup

2021-05-30T20:03:40Z

libalias is a convolut of various coding styles modified by a series of different editors enforcing interesting convetions on spacing and comments. This patch is a baseline to start with a perfomance rework of libalias. Upcoming patches should be focus on the code, not on the style. That's why most annoying style errors should be fixed beforehand. Reviewed by: hselasky Discussed by: emaste Differential Revision: https://reviews.freebsd.org/D30259 (cherry picked from commit effc8e57fbf03d7f1423c662caf2b63f0d1d21a9) At some places the ASSERT was inserted before variable declarations are finished. This is fixed now. Reported by: kib Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D30282 (cherry picked from commit 2e6b07866f9e1520626a1523f6609cc411bdda1c)

liblias: clean up empty lines in .c and .h files

2021-05-30T19:16:30Z

Partial apply of a huge commit to libalias only (cherry picked from commit 662c13053f4bf2d6245ba7e2b66c10d1cd5c1fb9)

libalias: Fix -Wcast-align compiler warnings

2021-05-30T14:31:38Z

This fixes -Wcast-align warnings caused by the underaligned `struct ip`. This also silences them in the public functions by changing the function signature from char * to void *. This is source and binary compatible and avoids the -Wcast-align warning. Reviewed By: ae, gbe (manpages) Differential Revision: https://reviews.freebsd.org/D27882

sys: general adoption of SPDX licensing ID tags.

2017-11-27T15:23:17Z

Mainly focus on files that use BSD 2-Clause license, however the tool I was using misidentified many licenses so this was mostly a manual - error prone - task. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts. No functional change intended.

alias_proxy.c: Fix accidental error quashing

2017-03-13T18:05:31Z

This was introduced on accident in r165243, when return sites were unified to add a lock around LibAliasProxyRule(). PR: 217749 Submitted by: Svyatoslav Sponsored by: Viva64 (PVS-Studio)

Use inet_ntoa_r() instead of inet_ntoa() throughout the kernel

2017-02-16T20:47:41Z

inet_ntoa() cannot be used safely in a multithreaded environment because it uses a static local buffer. Instead, use inet_ntoa_r() with a buffer on the caller's stack. Suggested by: glebius, emaste Reviewed by: gnn MFC after: 2 weeks Sponsored by: Dell EMC Differential Revision: https://reviews.freebsd.org/D9625

Avoid potential bad pointer dereference.

2012-10-17T20:23:07Z

Previously RuleAdd would leave entry->la unset for the first entry in the proxyList. Sponsored by: ADARA Networks MFC After: 1 week

Move inet_aton() (specular to inet_ntoa(), already present in libkern)

2009-11-12T00:46:28Z

into libkern in order to made it usable by other modules than alias_proxy. Obtained from: Sandvine Incorporated Sponsored by: Sandvine Incorporated MFC: 1 week