src/sys/netinet6, branch release/13.4.0

nd6: Fix the routing table subscription

2024-08-08T22:41:29Z

The nd6 code listens for RTM_DELETE events so that it can mark the corresponding default router as inactive in the case where the default route is deleted. A subsequent RA from the router may then reinstall the default route. Commit fedeb08b6a58e broke this for non-multipath routes, as rib_decompose_notification() only invokes the callback for multipath routes. Restore the old behaviour. Also ensure that we update the router only for RTM_DELETE notifications, lost in commit 2259a03020fe0. Approved by: re (cperciva) Reviewed by: bz Fixes: fedeb08b6a58 ("Introduce scalable route multipath.") Fixes: 2259a03020fe ("Rework part of routing code to reduce difference to D26449.") MFC after: 2 weeks Sponsored by: Klara, Inc. Sponsored by: Bell Tower Integration Differential Revision: https://reviews.freebsd.org/D46020 (cherry picked from commit a48df53e4249499be3e8779dd30888a405aa81ae) (cherry picked from commit c611f050d0dc01bf1f738300365895da84aa5fef)

inet6: protect address manipulation with a lock

2024-05-10T16:27:07Z

This is a total hack/bare minimum which follows inet4. Otherwise 2 threads removing the same address can easily crash. Reviewed by: kp Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D39317 (cherry picked from commit f5a365e51feea75d1e5ebc86c53808d8cae7b6d7)

inpcb: Restore some NULL checks of credential pointers

2024-02-07T14:46:34Z

At least one out-of-tree port (net-mgmt/ng_ipacct) depends on being able to call in_pcblookup_local() with cred == NULL, so the MFC of commit ac1750dd143e ("inpcb: Remove NULL checks of credential references") broke compatibility. Restore a subset of the NULL checks to avoid breaking the module in the 13.3 release. This is a direct commit to stable/13. PR: 276868

netinet6: Fix two typos in source code comments

2024-01-25T06:52:11Z

- s/adddress/address/ (cherry picked from commit 496432f192165b8700da4b0ab8ebdd253002e265)

inpcb: Allow SO_REUSEPORT_LB to be used in jails

2024-01-22T18:45:03Z

Currently SO_REUSEPORT_LB silently does nothing when set by a jailed process. It is trivial to support this option in VNET jails, but it's also useful in traditional jails. This patch enables LB groups in jails with the following semantics: - all PCBs in a group must belong to the same jail, - PCB lookup prefers jailed groups to non-jailed groups This is a straightforward extension of the semantics used for individual listening sockets. One pre-existing quirk of the lbgroup implementation is that non-jailed lbgroups are searched before jailed listening sockets; that is preserved with this change. Discussed with: glebius MFC after: 1 month Sponsored by: Modirum MDPay Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D37029 (cherry picked from commit d93ec8cb1324d04d7cae19fb7fa98ade2ff33c80)

inpcb: Remove NULL checks of credential references

2024-01-22T18:45:03Z

Some auditing of the code shows that "cred" is never non-NULL in these functions, either because all callers pass a non-NULL reference or because they unconditionally dereference "cred". So, let's simplify the code a bit and remove NULL checks. No functional change intended. Reviewed by: glebius MFC after: 1 week Sponsored by: Modirum MDPay Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D37025 (cherry picked from commit ac1750dd143e53225c518bc1ca0462c3fffe10f6)

routing: plug mbuf leak for the packets hitting IPv6 blackhole route

2024-01-22T18:21:34Z

Reported by: Dmitriy Smirnov Tested by: Dmitriy Smirnov MFC after: 1 day (cherry picked from commit b50e1465e88dcf5f6f008892d802df010e7029d1)

sys: Use mbufq_empty instead of comparing mbufq_len against 0

2024-01-18T22:37:32Z

Reviewed by: bz, emaste Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D43338 (cherry picked from commit 8cb9b68f5821e45c63ee08d8ee3029ca523ac174)

sctp: cleanup cdefs.h include

2024-01-11T12:44:49Z

(cherry picked from commit c3179e6660e1365111b89cb6c05c3a4c47375e73)

sctp: remove duplicate code

2024-01-11T12:30:20Z

No functional change intended. (cherry picked from commit 9ade2745db8be213e9da2225795cafb8e7575e29)