FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=releng%2F12.2 2020-10-01T18:17:56Z 2020-10-01T18:17:56Z Michael Tuexen tuexen@FreeBSD.org 2020-10-01T18:17:56Z urn:sha1:6a550fd843f892a861f310356dd4227896f70d45 Improve the handling of receiving unordered and unreliable user messages using DATA chunks. Don't use fsn_included when not being sure that it is set to an appropriate value. If the default is used, which is -1, this can result in SCTP associaitons not making any user visible progress. Thanks to Yutaka Takeda for reporting this issue for the the userland stack in https://github.com/pion/sctp/issues/138. MFS r366329: Improve the input validation and processing of cookies. This avoids setting the association in an inconsistent state, which could result in a use-after-free situation. This can be triggered by a malicious peer, if the peer can modify the cookie without the local endpoint recognizing it. Thanks to Ned Williamson for reporting the issue. Approved by: re (gjb) 2020-09-07T17:31:58Z Ed Maste emaste@FreeBSD.org 2020-09-07T17:31:58Z urn:sha1:26d711200c830b754630eac3b03a0fd0c8267b89 Until the changes to make this a proper dependency are merged, avoid using a syntax error for a user-facing error report. PR: 249037 Suggested by: avg 2020-09-03T09:09:44Z Richard Scheffenegger rscheff@FreeBSD.org 2020-09-03T09:09:44Z urn:sha1:46fd36d518895889b63837778b5c517e660a3510 Since cubic calculates cwnd based on absolute time, retaining RFC3465 (ABC) once-per-window updates can lead to dramatic changes of cwnd in the convex region. Updating cwnd for each incoming ack minimizes this delta, preventing unintentional line-rate bursts. Reviewed by: chengc_netapp.com, tuexen (mentor) MFC after: 2 weeks Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D26060 2020-09-03T08:45:21Z Richard Scheffenegger rscheff@FreeBSD.org 2020-09-03T08:45:21Z urn:sha1:9ccab0221c01da796617974d02c0a9cd4016a47b The Cubic concave region was not aligned nicely for the very first exit from slow start, where a 50% cwnd reduction is done instead of the normal 30%. This addresses an issue, where a short line-rate burst could result from that sudden jump of cwnd. In addition, the Fast Convergence Heuristic has been expanded to work also with ECN induced congestion response. Submitted by: chengc_netapp.com Reported by: chengc_netapp.com Reviewed by: tuexen (mentor), rgrimes (mentor) Approved by: tuexen (mentor), rgrimes (mentor) MFC after: 3 weeks Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D25976 2020-09-03T08:41:38Z Richard Scheffenegger rscheff@FreeBSD.org 2020-09-03T08:41:38Z urn:sha1:ea7c82f32968e9598e1c43171ead671569956010 Initializing K to zero in D23655 introduced a miscalculation, where cwnd would suddenly jump to cwnd_max instead of gradually increasing, after leaving slow-start. Properly calculating K instead of resetting it to zero resolves this issue. Also making sure, that cwnd is recalculated at the earliest opportunity once slow-start is over. Reported by: chengc_netapp.com Reviewed by: chengc_netapp.com, tuexen (mentor), rgrimes (mentor) Approved by: tuexen (mentor), rgrimes (mentor) MFC after: 3 weeks Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D25746 2020-09-03T08:38:04Z Richard Scheffenegger rscheff@FreeBSD.org 2020-09-03T08:38:04Z urn:sha1:d71469cc807a9fcdfc1a810b4732677628e301ab Adding proper accounting of sacked_bytes and (per-ACK) delivered data to the SACK scoreboard. This will allow more aspects of RFC6675 to be implemented as well as Proportional Rate Reduction (RFC6937). Prior to this change, the pipe calculation controlled with net.inet.tcp.rfc6675_pipe was also susceptible to incorrect results when more than 3 (or 4) holes in the sequence space were present, which can no longer all fit into a single ACK's SACK option. Reviewed by: kbowling, rgrimes (mentor) Approved by: rgrimes (blanket) MFC after: 3 weeks Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D18624 2020-09-01T19:54:43Z Bjoern A. Zeeb bz@FreeBSD.org 2020-09-01T19:54:43Z urn:sha1:de305dd0a04c1f7b49771a7d429e35e2f2027603 IPV6_PKTINFO support for v4-mapped IPv6 sockets When using v4-mapped IPv6 sockets with IPV6_PKTINFO we do not respect the given v4-mapped src address on the IPv4 socket. Implement the needed functionality. This allows single-socket UDP applications (such as OpenVPN) to work better on FreeBSD. Requested by: Gert Doering (gert greenie.net), pfsense Tested by: Gert Doering (gert greenie.net) 2020-08-29T06:54:39Z Michael Tuexen tuexen@FreeBSD.org 2020-08-29T06:54:39Z urn:sha1:3d32343d1b7c240bbf7057a8f7e0f236a22f8dc9 Fix a regression with the explicit EOR mode I introduced in r364268. 2020-08-24T09:19:05Z Michael Tuexen tuexen@FreeBSD.org 2020-08-24T09:19:05Z urn:sha1:cc13043e2c974318ce14c50eddf2562f8a0ce989 Improve the handling of concurrent send() calls for SCTP sockets, especially when having the explicit EOR mode enabled. MFC r364270: Remove a line which is needed and was added in https://svnweb.freebsd.org/changeset/base/364268 2020-08-24T09:15:52Z Michael Tuexen tuexen@FreeBSD.org 2020-08-24T09:15:52Z urn:sha1:253a2937235773b18ce1fe91a7239fbc9f36cd3b Clear the pointer to the socket when closing it also in case of an ungraceful operation. This fixes a use-after-free bug found and reported by Taylor Brandstetter of Google by testing the userland stack.