src/sys/netlink, branch mainFreeBSD source treehttps://cgit-dev.freebsd.org/src/atom?h=main2026-05-25T16:37:12Znetlink: Fix RTM_GETROUTE loop for RT_TABLE_UNSPEC2026-05-25T16:37:12ZEd Masteemaste@FreeBSD.org2026-05-22T14:27:53Zurn:sha1:33acf0f26b490ea4887d820a3f45c56e3913a17d
Reviewed by: bz, pouria
Fixes: 7e5bf68495cc ("netlink: add netlink support")
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D57234
netlink: Avoid potential undefined behaviour2026-05-23T20:59:52ZEd Masteemaste@FreeBSD.org2026-05-22T14:55:49Zurn:sha1:4d125ed6e7d445d574c11dc35c40ec3013559806
Taking the address of an OOB array element is UB, even if not
dereferenced.
Reviewed by: des, bz
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D57172
netlink: Check for NULL return from npt_alloc()2026-05-23T16:22:36ZEd Masteemaste@FreeBSD.org2026-05-22T14:41:16Zurn:sha1:1dbc104148845434575d1931d47876ae0ca1542f
Reviewed by: glebius, pouria
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D57171
netlink: Fix interface type match2026-05-22T18:34:13ZEd Masteemaste@FreeBSD.org2026-05-22T13:35:52Zurn:sha1:eff5f220c379d4173fdc0e5ec00380888bf7649a
Reviewed by: bz, glebius, pouria
Fixes: 7e5bf68495cc ("netlink: add netlink support")
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D57167
netlink: Avoid undefined behaviour2026-05-22T14:21:11ZEd Masteemaste@FreeBSD.org2026-05-22T00:50:00Zurn:sha1:1a4ad649cb135501f0bee56a4214e8c904ca402e
Even though it is not dereferenced, it is UB to take the address of an
out of bounds array element.
Reviewed by: pouria, bz, des, adrian
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D57158
netlink: Fix lock leak in nl_find_nhop2026-05-22T00:38:45ZEd Masteemaste@FreeBSD.org2026-05-21T21:14:41Zurn:sha1:d66fec481bfd65cbabb6c12a410d76843e76083e
Reviewed by: bz, pouria
Fixes: 7e5bf68495cc ("netlink: add netlink support")
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D57156
netlink: Add RTA_PRIORITY support (metric)2026-05-20T20:55:03ZPouria Mousavizadeh Tehranipouria@FreeBSD.org2026-05-02T20:58:40Zurn:sha1:73acfc5863489f0d7ed671d5529eea4c05ec40e6
* Use our new 32-bit metric for RTA_PRIORITY support.
* Update snl library for new RTA_PRIORITY support.
* return RTA_PRIORITY for both MPATH and non-MPATH routes.
Reviewed by: glebius (previous version)
Discussed with: markj
Differential Revision: https://reviews.freebsd.org/D56323
netlink: fix unsigned overflow on a truncated message2026-05-20T14:27:52ZGleb Smirnoffglebius@FreeBSD.org2026-05-20T14:27:52Zurn:sha1:e924a2c80b9e1ace68d8ca0ffdacec65feec90a3
PR: 295106
Submitted by: Robert Morris <rtm@lcs.mit.edu>
Reviewed by: pouria, melifaro
Differential Revision: https://reviews.freebsd.org/D56916
netlink: factor out compatibility code from inlined function2026-05-20T14:27:39ZGleb Smirnoffglebius@FreeBSD.org2026-05-20T14:27:39Zurn:sha1:e145afc9eb9187be7e7cfdd42043cefc07b6e8d6
This is a refactor of 228c632ab3f62. First, move compatibility one level
up, where we yet work with the full header. Second, move this rarely
executed code outside of the inline function. Should be no functional
change.
Reviewed by: pouria, melifaro
Differential Revision: https://reviews.freebsd.org/D56915
rtnetlink: Align RTA_MULTIPATH length validation in nlattr_get2026-05-13T09:44:28ZPouria Mousavizadeh Tehranipouria@FreeBSD.org2026-05-12T11:34:28Zurn:sha1:4329663a861ef74796b79b6b0872cfe10d31c591
Fix length validation of RTA_MULTIPATH attributes in
nlattr_get_multipath() by making sure the user request is align.
PR: 295102
Reported by: Robert Morris <rtm@lcs.mit.edu>
Reviewed by: markj
Fixes: 7e5bf68495cc ("netlink: add netlink support")
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D56963