src/sys/netlink, branch release/13.2.0

netlink: fix OOB read in genetlink

2023-03-07T13:28:06Z

Reported by: Coverity Scan Approved by: re (cperciva) CID: 1498863 (cherry picked from commit 8f7455a9265f4952f885b06c08c57fcce6f16e5c) (cherry picked from commit d9d596bb2ce04bbec5ea811342efd4216c1fc2a3)

netlink: call genetlink notification handler upon successful family

2023-03-07T13:27:57Z

search. Approved by: re (cperciva) (cherry picked from commit 7cbe771f013f6cf3316910648f6d46641cad7f44) (cherry picked from commit ac40ea6fbb4e6af98a4540fc8fd5a3e824cb181d)

netlink: do not memcpy 0 bytes from a NULL pointer

2023-03-06T19:37:56Z

Although it works in practice it is UB, and might break after a future compiler update. This was rewritten in main and the memcpy call no longer exists, so this is a direct commit to stable/13 before 055776c84a41 is MFC'd. Discussed with: melifaro Approved by: re (cperciva) Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D38927 (cherry picked from commit 305aaa93e0c805294c8bcbb5fe8b9f7caa28b349)

netlink: simplify temporary address allocation in rtnl_handle_getlink().

2023-03-06T19:37:56Z

Approved by: re (cperciva) (cherry picked from commit 45356a1864c79680c6911b48a18b14a88a7d07fa) (cherry picked from commit 4c1ef49999c6687905664eecd73ea9473ffe5fda)

netlink: fix interface dump.

2023-03-06T19:37:56Z

The current code missed interface addition when reallocating temporary buffer. Tweak the code to perform the reallocation first and add interface afterwards unconditionally. Reported by: Marek Zarychta Approved by: re (cperciva) (cherry picked from commit 86fd0bdba540132ae298457e160b651f61d1db6b) (cherry picked from commit a800622765b1e7cab79fa857e9a671e6c0c1ccec)

netlink: make the maximum allowed netlink socket buffer runtime tunable.

2023-03-01T16:53:36Z

Dumping large routng tables (>1M paths with multipath) require the socket buffer which is larger than the currently defined limit. Allow the limit to be set in runtime, similar to kern.ipc.maxsockbuf. Reported by: Marek Zarychta MFC after: 1 day Approved by: re(cperciva) (cherry picked from commit 28a5d88f7091d1fc72f4f1bd8562d3c8b15883f5) (cherry picked from commit b656161b84dce0322ab00d7958267fa47cda6318)

netlink: fix addition of blackhole/reject routes.

2023-02-27T16:27:16Z

* Make nhop_set_blackhole() set all necessary properties for the nexthop * Make nexthops blackhole/reject based on the rtm_type netlink property instead of using rtflags. Reported by: Marek Zarychta MFC after: 3 days Approved by: re(cperciva) (cherry picked from commit d2deebe21b591336fbd8915b37d409b25da54d4d) (cherry picked from commit f054a56ef3e8dc30ba0904d43cf7ec7b3e6e0ed4)

netlink: clear IPv6 embedded scope when dumping route gateways.

2023-02-27T16:27:16Z

Reported by: zarychtam@plan-b.pwste.edu.pl MFC after: 3 days Approved by: re(cperciva) (cherry picked from commit b9b2184322da85e1f4d52e3b0a6322dd214210ec) (cherry picked from commit d101991d8dcc1e056d1c06ca83b88826f4d65ae5)

netlink: fix IPv6 route addition with link-local gateway

2023-02-27T16:27:16Z

Currently kernel assumes that IPv6 gateway address is in "embedded" form - that is, for the link-local IPv6 addresses, interface index is embedded in bytes 2 and 3 of the address. Fix address embedding in netlink by wrapping nhop_set_gw() in the netlink-specific nl_set_nexthop_gw(), which does such embedding automatically. Reported by: Marek Zarychta MFC after: 3 days Approved by: re(cperciva) (cherry picked from commit c7c348162101a70b1f99299578dabe1d3b100e48) (cherry picked from commit 240ee0183fa190502a5e1f163c49f336f8f10cd4)

netlink: validate rtable value in RTM_ROUTE.

2023-02-20T19:48:35Z

Reported by: Stefan Grundmann Approved by: re(cperciva) MFC after: 1 day (cherry picked from commit f2f7911c5513096e46422ad7756bc90c13c6e6d8) (cherry picked from commit e9296dc1bcd21cd9d719389cd04235ce4513e84d)