src/sys/ofed/drivers/infiniband/core/ib_ucm.c, branch main

OFED: Various changes from Linux 4.19

2026-06-24T19:30:56Z

Many of these changes deal with shifting from fetcing SGID attributes via an index in drivers to including references to SGID attributes in other structures passed to driver callbacks which can be used directly avoiding the need for fetching attributes via lookup functions. I had to fixup the ROCE GID management code directly as the version in FreeBSD is very different from Linux. I also tweaked the change from commit 475c8de7bf2dc86d9806709a04e9c8f524d4ec32 to use a goto to reduce diffs with upstream to minimize conflicts when merging upstream changes. This contains changes from the following Linux commits: a1a4caeebac9 IB/core: Do not set the gid type when reserving default entries 1c36cf912ad1 IB/core: Store default GID property per-table instead of per-entry 1dfce2945771 IB: Replace ib_query_gid/ib_get_cached_gid with rdma_query_gid 83f6f8d29dd3 IB/core: Make rdma_find_gid_by_filter support all protocols c3d71b69a75c IB/core: Provide rdma_ versions of the gid cache API 77e786fcbe2e IB/core: Replace ib_query_gid with rdma_get_gid_attr bf399c2cadfa IB/core: Introduce GID attribute get, put and hold APIs f4df9a7c34d8 RDMA: Use GID from the ib_gid_attr during the add_gid() callback b150c3862d21 IB/core: Introduce GID entry reference counts 47ec38666210 RDMA: Convert drivers to use sgid_attr instead of sgid_index d97099fe53ed IB{cm, core}: Introduce and use ah_attr copy, move, replace APIs 947c99ecfcb4 IB/core: Tidy ib_resolve_eth_dmac 8d9ec9addd6c IB/core: Add a sgid_attr pointer to struct rdma_ah_attr 89af969a6653 RDMA: Convert drivers to use the AH's sgid_attr in post_wr paths 1a1f460ff151 RDMA: Hold the sgid_attr inside the struct ib_ah/qp 7492052a186b IB/mlx4: Use GID attribute from ah attribute 59d40813328f IB/core: Free GID table entry during GID deletion 881456789248 RDMA/cma: Consider net namespace while leaving multicast group 4ed13a5f2d60 IB/cm: Keep track of the sgid_attr that created the cm id aa74f4878d61 IB: Make init_ah_attr_grh_fields set sgid_attr f685c19529f0 IB: Make ib_init_ah_from_mcmember set sgid_attr b7403217656d IB: Make ib_init_ah_attr_from_wc set sgid_attr ea8c2d8f6014 RDMA/core: Remove unused ib cache functions a8872d53e9b7 IB/cm: Use sgid_attr from the AV 398391071f25 IB/cm: Replace members of sa_path_rec with 'struct sgid_attr *' 815d456ef21a IB/cm: Pass the sgid_attr through various events 4eefd62c17a9 include/rdma/opa_addr.h: Fix an endianness issue f8c2d2280cf6 RDMA/core: Remove set-but-not-used variables 28e39894ed4f RDMA/core: Remove ib_find_cached_gid() and ib_find_cached_gid_by_port() 07e7056aff6c IB/core: Simplify check for RoCE route resolve 40ddacf2dda9 RDMA/umem: Don't hold mmap_sem for too long 1215cb7c88ec RDMA/umem: Refactor exit paths in ib_umem_get c012691508f5 IB/cm: Remove cma_multicast->igmp_joined 4b4671a0f269 IB/IPoIB: Simplify ib_post_(send|recv|srq_recv)() calls 1fec77bf8fcd RDMA/core: Simplify ib_post_(send|recv|srq_recv)() calls bb039a870c05 IB/core: Allow ULPs to specify NULL as the third ib_post_(send|recv|srq_recv)() argument 643d213a9a03 RDMA/cma: Do not ignore net namespace for unbound cm_id d274e45ce1ed RDMA/cma: Consider netdevice for RoCE ports cee104334c98 IB/core: Introduce and use sgid_attr in CM requests 7150c3d5544b RDMA/core: Remove {create,destroy}_ah from mandatory verbs 854633165164 RDMA/core: Prefix _ib to IB/RoCE specific functions 7582df826734 RDMA/core: Avoid holding lock while initializing fields on stack 79d684f02647 RDMA/core: Simplify gid type check in cma_acquire_dev() ca3a8ace2b12 RDMA/core: Return bool instead of int 05e0b86c413d RDMA/cma: Get rid of 1 bit boolean e7ff98aefc9e RDMA/cma: Constify path record, ib_cm_event, listen_id pointers 2df7dba855e1 RDMA/core: Constify dst_addr argument 219d2e9dfda9 RDMA/cma: Simplify rdma_resolve_addr() error flow 26e551c5aec5 RDMA: Fix return code check in rdma_set_cq_moderation 58796e67d5d5 IB/ucm: Initialize sgid request GID attribute pointer dd81b2c8a333 IB/core: Change filter function return type from int to bool 93065ac753e4 mm, oom: distinguish blockable mode for mmu notifiers 0d23ba6034b9 RDMA/ucma: check fd type in ucma_migrate_id() Part of cee104334c98 was previously merged into FreeBSD. Namely, SGID index fields had been added to the two param structures instead and roce_get_net_dev_by_cm_event was implemented using SGID indices. Tested by: Wafa Hamzah (mlx5_ib) Tested by: John Baldwin (iw_cxgbe) Sponsored by: Chelsio Communications

OFED: Various changes from Linux 4.14

2026-06-24T19:30:55Z

This contains changes from the following Linux commits: 1cb2fc0db764 IB/mad: Change slid in RMPP recv from 16 to 32 bits 7e93e2cb835c IB/IPoIB: Increase local_lid to 32 bits d541e45500bd IB/core: Convert ah_attr from OPA to IB when copying to user 6b3c0e6e6d5a IB/CM: Create appropriate path records when handling CM request e92aa00a5189 IB/CM: Add OPA Path record support to CM 7db20ecd1d97 IB/core: Change wc.slid from 16 to 32 bits db58540b021a IB/core: Change port_attr.sm_lid from 16 to 32 bits 582faf3150f5 IB/core: Change port_attr.lid size from 16 to 32 bits ac3a949fb2ff IB/CM: Set appropriate slid and dlid when handling CM request 06f8174a9782 IB/core: Protect sysfs entry on ib_unregister_device 62ede7779904 Add OPA extended LID support 13c19222889d IB/rdmavt, hfi1, qib: Modify check_ah() to account for extended LIDs d98bb7f7e6fa IB/hfi1: Determine 9B/16B L2 header type based on Address handle dcc9881e6767 RDMA/(core, ulp): Convert register/unregister event handler to be void f808c13fd373 lib/interval_tree: fast overlap detection Tested by: Wafa Hamzah (mlx5_ib) Tested by: John Baldwin (iw_cxgbe) Sponsored by: Chelsio Communications

OFED: Various changes from Linux 4.12

2026-06-24T19:30:55Z

Most of the changes involve renaming InfiBand address handles (AH) to RDMA address handles including renaming various types and functions. Address handles now also include type-specific fields and a set of wrapper accessor functions for getting and setting fields. For some of the type and function renames, drivers in sys/dev had to be updated directly (typically via sed). This contains changes from the following Linux commits: f039f44fc331 IB/core: Add support for draining IB_POLL_DIRECT completion queues fedd9e1f7582 IB/cq: Don't process more than the given budget 403cd12e2cf7 IB/umem: Add contiguous ODP support 0008b84ea9af IB/umem: Add support to huge ODP 3e7e1193e28a IB: Replace ib_umem page_size by page_shift cb8637660ae8 IB/SA: Move functions update_sm_ah() and ib_sa_event() 680562b56939 IB/SA: Remove unwanted braces dbb6c91fd8e0 IB/SA: Add braces when using sizeof f96a31871449 IB/SA: Fix lines longer than 80 columns 94d595c56077 IB/core: Add rdma_cap_opa_ah to expose opa address handles ee1c60b1bff8 IB/SA: Modify SA to implicitly cache Class Port info aa4656d9a429 IB/core: Move opa_class_port_info definition to header file 2196f2716292 IB/SA: Add support to query opa classport info. 64b4646eaf3d IB/core: Define 'opa' rdma_ah_attr type 44c58487d51a IB/core: Define 'ib' and 'roce' rdma_ah_attr types d8966fcd4c25 IB/core: Use rdma_ah_attr accessor functions 2224c47ace23 IB/core: Add accessor functions for rdma_ah_attr fields 365231593409 IB/core: Rename ib_destroy_ah to rdma_destroy_ah bfbfd661c9ea IB/core: Rename ib_query_ah to rdma_query_ah 67b985b6c755 IB/core: Rename ib_modify_ah to rdma_modify_ah 0a18cfe4f6d7 IB/core: Rename ib_create_ah to rdma_create_ah 766b7f6cf0c0 IB/mthca: Rename to_ib_ah_attr to to_rdma_ah_attr 38349389fece IB/mlx5: Rename to_ib_ah_attr to to_rdma_ah_attr 71d53ab47ee6 IB/mlx4: Rename to_ib_ah_attr to to_rdma_ah_attr 90898850ec4e IB/core: Rename struct ib_ah_attr to rdma_ah_attr 4ba66093bdc6 IB/core: Check for global flag when using ah_attr cf0b9395d084 IB/core: Add braces when using sizeof cfd519358f50 IB/IPoIB: Remove 'else' when the 'if' has a return. 82ffc226483c IB/CM: Add braces when using sizeof dfa834e1d97e IB/SA: Introduce path record specific types c2f8fc4ec440 IB/SA: Rename ib_sa_path_rec to sa_path_rec 9fdca4da4d8c IB/SA: Split struct sa_path_rec based on IB and ROCE specific fields 4c33bd1926cc IB/SA: Add support to query OPA path records 57520751445b IB/SA: Add OPA path record type 87f0faadc685 IB/SA: Add OPA addr header eed7624552ca RDMA/mlx4: Fix MAD tunneling when SRIOV is enabled f937d93a9122 RDMA/uverbs: Declare local function static and add brackets to sizeof d3957b86a406 RDMA/SA: Fix kernel panic in CMA request handler flow The IPoIB portions of ee1c60b1bff8 were already present in FreeBSD from an earlier sync with OFED. Likewise, the ib_uverbs_cmd.c changes from 4ba66093bdc6 were also already present. Tested by: Wafa Hamzah (mlx5_ib) Tested by: John Baldwin (iw_cxgbe) Sponsored by: Chelsio Communications

OFED: Various changes from Linux 4.10

2026-06-24T19:30:55Z

This contains changes from the following Linux commits: 850d8fd76507 IB/mlx4: Handle IPv4 header when demultiplexing MAD a0b3455fcb2d IB/core: Remove debug prints after allocation failure 74226649f42d IB/ipoib: Remove and fix debug prints after allocation failure 870b28524552 IB/mthca: Remove debug prints after allocation failure aa6aae38f7fb IB/core: Release allocated memory in cache setup failure f73a1dbc45a5 infiniband: remove WARN that is not kernel bug 5f24410408fd rdma_cm: add rdma_consumer_reject_data helper function 5042a73d3e9d rdma_cm: add rdma_is_consumer_reject() helper function d3f4aadd614c RDMA/core: Add the function ib_mtu_int_to_enum Tested by: Wafa Hamzah (mlx5_ib) Tested by: John Baldwin (iw_cxgbe) Sponsored by: Chelsio Communications

sys: Remove $FreeBSD$: one-line .c pattern

2023-08-16T17:54:36Z

Remove /^[\s*]*__FBSDID$"\$FreeBSD\$"$;?\s*\n/

Infiniband clients must be attached and detached in a specific order in ibcore.

2020-07-06T08:50:11Z

Currently the linking order of the infiniband, IB, modules decide in which order the clients are attached and detached. For example one IB client may use resources from another IB client. This can lead to a potential deadlock at shutdown. For example if the ipoib is unregistered after the ib_multicast client is detached, then if ipoib is using multicast addresses a deadlock may happen, because ib_multicast will wait for all its resources to be freed before returning from the remove method. Fix this by using module_xxx_order() instead of module_xxx(). Differential Revision: https://reviews.freebsd.org/D23973 MFC after: 1 week Sponsored by: Mellanox Technologies

Use __FBSDID() for RCS tags in ibcore.

2018-07-17T09:47:14Z

MFC after: 1 week Sponsored by: Mellanox Technologies

Add missing FreeBSD tags and SVN properties to ibcore.

2018-03-05T11:49:45Z

MFC after: 1 week Sponsored by: Mellanox Technologies

Remove no longer needed linux_poll_wakeup() calls. This is now handled by

2017-09-16T16:31:30Z

"wake_up()" in the LinuxKPI. Accessing the file pointer directly might cause use after free issues. Sponsored by: Mellanox Technologies

ibcore: Delete old files and add new ones missed in the initial commit

2017-07-03T08:32:52Z

for this projects branch. Sponsored by: Mellanox Technologies