src/sys/opencrypto/crypto.c, branch main

crypto: Remove uses of CRYPTO_F_DONE

2025-05-09T00:29:23Z

Previously OCF set CRYPTO_F_DONE prior to invoking the completion callback, even if the request failed. This isn't particularly useful and leads to bugs when consumers retry a failed request, since OCF also asserts that CRYPTO_F_DONE is clear in crypto_dispatch(). (Really, OCF should retry requests that fail with EAGAIN, but that's a larger change.) For now, just stop setting CRYPTO_F_DONE to simplify consumers (and fix those which fail to clear the flag before retrying a request). PR: 286321 Reviewed by: jhb Differential Revision: https://reviews.freebsd.org/D50104

sys: make the kernel metadata pointer global

2025-01-24T21:25:51Z

The way we got the kernel metadata pointer was by calling preload_search_by_type with one of the following three: "elf kernel", "elf32 kernel" and "elf64 kernel". Which one(s) we used wasn't consistent though. Sometimes we would only try "elf kernel", and other times we would try one of the latter two if the first failed. However, the loader only ever sets "elf kernel" as the kernel type. Now, the kmdp is a global, preload_kmdp, and it's initialized using preload_initkmdp in machdep.c (or machdep_boot.c on arm/64). preload_initkmdp takes a single boolean argument that tells us whether not finding the kmdp is fatal or not. Reviewed by: imp, kib Pull Request: https://github.com/freebsd/freebsd-src/pull/1394

sys: Remove $FreeBSD$: one-line .c pattern

2023-08-16T17:54:36Z

Remove /^[\s*]*__FBSDID$"\$FreeBSD\$"$;?\s*\n/

Complete removal of opt_compat.h

2023-02-13T16:07:38Z

Since Linux emulation layer build options was removed there is no reason to keep opt_compat.h. Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D38548 MFC after: 2 weeks

crypto: move all zeroing into crypto_getreq

2022-11-22T12:28:07Z

Reviewed by: jhb, markj Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D36774

[skip ci] Remove obsolete references in crypto_request(9)

2022-11-02T17:09:06Z

They were missed by 68f6800ce05c3. Sponsored by: Axcient MFC with: 68f6800ce05c3 Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D37239

ddb: annotate some commands with DB_CMD_MEMSAFE

2022-07-18T22:06:09Z

This is not completely exhaustive, but covers a large majority of commands in the tree. Reviewed by: markj Sponsored by: Juniper Networks, Inc. Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D35583

crypto: Validate return values from CRYPTODEV_PROCESS()

2022-07-01T15:09:39Z

Errors are always handled by the completion callback, so we should check that they're not also passed back to the caller. No functional change intended. Reviewed by: kp, mav, jhb MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D35382

crypto: Fix assertions for digest-only sessions with separate output.

2022-06-30T17:10:00Z

Digest-only sessions do not generate modified payload as an output, so don't bother asserting anything about the payload with respect to the output buffer other than the payload output start being zero. In addition, a verify request on a digest-only session doesn't generate any output at all so should never have a separate output buffer. PR: 252316 Reviewed by: markj Co-authored-by: Jeremy Faulkner MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D35578

crypto: hide crypto_destroyreq behind a tunable

2022-02-16T07:45:12Z

Reviewed by: jhb, markj Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D32084