src/tests/sys/audit/Makefile, branch stable/13FreeBSD source treehttps://cgit-dev.freebsd.org/src/atom?h=stable%2F132023-08-23T17:43:30ZRemove $FreeBSD$: one-line sh pattern2023-08-23T17:43:30ZWarner Loshimp@FreeBSD.org2023-08-22T01:32:01Zurn:sha1:023fc80ee38a117fa65b2ccb2abf8bdc7dbd6fd9
Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/
Similar commit in main:
(cherry picked from commit d0b2dbfa0ecf)
tests/sys/audit: Avoid race caused by starting auditd(8) for testing2021-03-17T22:22:48ZAlex Richardsonarichardson@FreeBSD.org2021-02-18T10:14:27Zurn:sha1:eb52de783a1c079b2ef4d674090322886cc22fc0
In the CheriBSD CI we reproducibly see the first test in sys/audit
(administrative:acct_failure) fail due to a missing startup message.
It appears this is caused by a race condition when starting auditd:
`service auditd onestart` returns as soon as the initial auditd() parent
exits (after the daemon(3) call).
We can avoid this problem by setting up the auditd infrastructure
in-process: libauditd contains audit_quick_{start,stop}() functions that
look like they are ideally suited to this task.
This patch also avoids forking lots of shell processes for each of the 418
tests by using `auditon(A_SENDTRIGGER, &trigger, sizeof(trigger))` to check
for a running auditd(8) instead of using `service auditd onestatus`.
With these two changes (and D28388 to fix the XFAIL'd test) I can now
boot and run `cd /usr/tests/sys/audit && kyua test` without any failures
in a single-core QEMU instance. Before there would always be at least one
failed test.
Besides making the tests more reliable in CI, a nice side-effect of this
change is that it also significantly speeds up running them by avoiding
lots of fork()/execve() caused by shell scripts:
Running kyua test on an AArch64 QEMU took 315s before and now takes 68s,
so it's roughly 3.5 times faster. This effect is even larger when running
on a CHERI-RISC-V QEMU since emulating CHERI instructions on an x86 host
is noticeably slower than emulating AArch64.
Test Plan: aarch64+amd64 QEMU no longer fail.
Reviewed By: asomers
Differential Revision: https://reviews.freebsd.org/D28451
(cherry picked from commit df093aa9463b2121d8307fb91c4ba7cf17f4ea64)
tests/sys/audit: force PIE off2021-03-05T17:46:11ZEd Masteemaste@FreeBSD.org2021-02-19T01:41:33Zurn:sha1:812a476244c4c2458942f957cf1188f05459a5d8
df093aa9463b linked against libprivateauditd.a, but that is currently
(and incorrectly) built as position-dependent. For now just force PIE
off for this test to fix the WITH_PIE build.
Sponsored by: The FreeBSD Foundation
(cherry picked from commit 4621c4f2fd179eff0923140da9af122c42dbe78b)
Do a sweep and remove most WARNS=6 settings2020-10-01T01:10:51ZKyle Evanskevans@FreeBSD.org2020-10-01T01:10:51Zurn:sha1:7cc42f6d25ef2e19059d088fa7d4853fe9afefb5
Repeating the default WARNS here makes it slightly more difficult to
experiment with default WARNS changes, e.g. if we did something absolutely
bananas and introduced a WARNS=7 and wanted to try lifting the default to
that.
Drop most of them; there is one in the blake2 kernel module, but I suspect
it should be dropped -- the default WARNS in the rest of the build doesn't
currently apply to kernel modules, and I haven't put too much thought into
whether it makes sense to make it so.
Make audit tests depend on /dev/auditpipe. This should fix2020-06-18T15:41:16ZEdward Tomasz Napieralatrasz@FreeBSD.org2020-06-18T15:41:16Zurn:sha1:a8ca275b7d962a13ef38c6b6d63efbbd0efa367f
some 416 failing tests on armv7:
https://ci.freebsd.org/job/FreeBSD-head-armv7-test/lastCompletedBuild/testReport/
Reviewed by: asomers
MFC after: 2 weeks
Sponsored by: DARPA
Differential Revision: https://reviews.freebsd.org/D25144
Fix and simplify code by using ATF_REQUIRE_FEATURE macro2019-04-01T14:21:32ZOlivier Cochardolivier@FreeBSD.org2019-04-01T14:21:32Zurn:sha1:8f462da4f3cf6cabcbac87c971634bcdec12fe06
PR: 236857
Reviewed by: asomers, ngie
Approved by: emaste
MFC after: 1 month
Sponsored by: Netflix
audit(4) tests: require /etc/rc.d/auditd2018-12-17T18:11:06ZAlan Somersasomers@FreeBSD.org2018-12-17T18:11:06Zurn:sha1:7fe3fd48a5c9b1a082cb5d3a4da4469fd5666382
These tests should be skipped if /etc/rc.d/auditd is missing, which could be
the case if world was built with WITHOUT_AUDIT set. Also, one test case
requires /etc/rc.d/accounting.
Submitted by: ngie
MFC after: 2 weeks
Pull Request: https://github.com/freebsd/freebsd/pull/240
audit(4): add tests for sysctl(3) and sysarch(2)2018-07-29T20:34:44ZAlan Somersasomers@FreeBSD.org2018-07-29T20:34:44Zurn:sha1:70eaeb3622c3f915b892527f7b69163cbc355da3
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D16116
audit(4): add tests for the process-control audit class2018-06-26T20:26:57ZAlan Somersasomers@FreeBSD.org2018-06-26T20:26:57Zurn:sha1:c907f24ead1909ab4fd6e5fbcefc5e0613d82213
Tested syscalls include rfork(2), chdir(2), fchdir(2), chroot(2),
getresuid(2), getresgid(2), setpriority(2), setgroups(2), setpgrp(2),
setrlimit(2), setlogin(2), mlock(2), munlock(2), minherit(2), rtprio(2),
profil(2), ktrace(2), ptrace(2), fork(2), umask(2), setuid(2), setgid(2),
seteuid(2), and setegid(2). The last six are only tested in the success
case, either because they're infalliable or a failure is difficult to cause
on-demand.
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D15966
audit(4): add tests for ioctl(2)2018-06-19T01:32:33ZAlan Somersasomers@FreeBSD.org2018-06-19T01:32:33Zurn:sha1:4003d9383510b238ee789a49f91a3dc581a64a85
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D15872