src/tests/sys/kqueue/libkqueue, branch release/14.3.0FreeBSD source treehttps://cgit-dev.freebsd.org/src/atom?h=release%2F14.3.02023-08-16T17:55:03ZRemove $FreeBSD$: one-line sh pattern2023-08-16T17:55:03ZWarner Loshimp@FreeBSD.org2023-08-16T17:55:03Zurn:sha1:d0b2dbfa0ecf2bbc9709efc5e20baf8e4b44bbbf
Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/
Remove $FreeBSD$: one-line .c comment pattern2023-08-16T17:54:29ZWarner Loshimp@FreeBSD.org2023-08-16T17:54:29Zurn:sha1:2a63c3be158216222d89a073dcbd6a72ee4aab5a
Remove /^/[*/]\s*\$FreeBSD\$.*\n/
Remove $FreeBSD$: two-line .h pattern2023-08-16T17:54:16ZWarner Loshimp@FreeBSD.org2023-08-16T17:54:16Zurn:sha1:b3e7694832e81d7a904a10f525f8797b753bf0d3
Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/
kqueue tests: Simplify the test runner2022-05-25T00:17:41ZMark Johnstonmarkj@FreeBSD.org2022-05-25T00:17:04Zurn:sha1:68fe988a40ca5dedec426735f52471d9af7bddbd
Just invoke the test program directly instead of trying to convert its
output to TAP format. The test suite is all or nothing; there's no way
to enumerate individual test cases, so there's no advantage in trying to
massage its output, and doing so throws away information that's useful
when diagnosing test failures.
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
kqueue tests: Add new EVFILT_TIMER regression tests from upstream2022-05-25T00:16:32ZMark Johnstonmarkj@FreeBSD.org2022-05-25T00:16:32Zurn:sha1:d6d4f9b45e0be306bdaf53b2133b2cd0f7642167
One of the tests exposes the regression reported in PR 264131.
One test is disabled because FreeBSD does not support setting EV_ONESHOT
on an already-added periodic timer. Though, in this case the flag is
simply ignored, which isn't ideal.
One test is slightly modified to set EV_ADD when reconfiguring a
disabled timer per some commentary in PR 258412.
Ideally we would re-import the test suite from libkqueue but there is a
fair bit of divergence so this will require some effort. This just gets
us one small step closer while increasing test coverage.
PR: 258412
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
kqueue tests: Add file and line info to some test failure output2022-05-25T00:14:20ZMark Johnstonmarkj@FreeBSD.org2022-05-25T00:14:20Zurn:sha1:c728c56c870abe230e45cee5c477f0d890ebacef
This brings us slightly closer to upstream and is useful when debugging
test failures.
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
kqueue tests: Re-enable kqueue proc tests2022-05-25T00:14:10ZMark Johnstonmarkj@FreeBSD.org2022-05-25T00:14:10Zurn:sha1:bc7512cc58af2e8bbe5bbf5ca0059b1daa1da897
- Some EVFILT_PROC bugs were fixed around the time that the tests were
disabled.
- I can't reproduce any failures locally.
- Jenkins logs referenced from the PR are gone, so let's re-enable the
tests and see whether a problem persists.
PR: 233586
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
fifos: delegate unhandled kqueue filters to underlying filesystem2021-10-12T07:43:07ZKyle Evanskevans@FreeBSD.org2021-10-02T05:23:03Zurn:sha1:7259ca31048e5ced8e7f90657a3d7084aeafdf51
This gives the vfs layer a chance to provide handling for EVFILT_VNODE,
for instance. Change pipe_specops to use the default vop_kqfilter to
accommodate fifoops that don't specify the method (i.e. all in-tree).
Based on a patch by Jan Kokemüller.
PR: 225934
Reviewed by: kib, markj (both pre-KASSERT)
Differential Revision: https://reviews.freebsd.org/D32271
kqueue: fix recent assertion2021-10-01T18:17:30ZKyle Evanskevans@FreeBSD.org2021-10-01T16:59:31Zurn:sha1:2f4dbe279f6b5eb87ec493d96f6943ffdb603ba0
NOTE_ABSTIME may also have a zero timeout, which indicates that we
should still fire immediately as an absolute time in the past. A test
has been added for this one as well.
Fixes: 9c999a259f00 ("kqueue: don't arbitrarily restrict long-past...")
Point hat: kevans
Reported by: syzbot+1c8d1154f560b3930042@syzkaller.appspotmail.com
kqueue: don't arbitrarily restrict long-past values for NOTE_ABSTIME2021-10-01T02:31:24ZKyle Evanskevans@FreeBSD.org2021-09-29T19:55:59Zurn:sha1:9c999a259f00b35f0467acd351fea9157ed7e1e4
NOTE_ABSTIME values are converted to values relative to boottime in
filt_timervalidate(), and negative values are currently rejected. We
don't reject times in the past in general, so clamp this up to 0 as
needed such that the timer fires immediately rather than imposing what
looks like an arbitrary restriction.
Another possible scenario is that the system clock had to be adjusted
by ~minutes or ~hours and we have less than that in terms of uptime,
making a reasonable short-timeout suddenly invalid. Firing it is still
a valid choice in this scenario so that applications can at least
expect a consistent behavior.
Reviewed by: kib, markj
Discussed with: allanjude
Differential Revision: https://reviews.freebsd.org/D32230