FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=release%2F13.1.0 2021-10-06T07:03:53Z 2021-10-06T07:03:53Z Kyle Evans kevans@FreeBSD.org 2021-09-29T19:55:59Z urn:sha1:121740e18515f56f54931c3d0dbbca620175c2a8 NOTE_ABSTIME values are converted to values relative to boottime in filt_timervalidate(), and negative values are currently rejected. We don't reject times in the past in general, so clamp this up to 0 as needed such that the timer fires immediately rather than imposing what looks like an arbitrary restriction. Another possible scenario is that the system clock had to be adjusted by ~minutes or ~hours and we have less than that in terms of uptime, making a reasonable short-timeout suddenly invalid. Firing it is still a valid choice in this scenario so that applications can at least expect a consistent behavior. (cherry picked from commit 9c999a259f00b35f0467acd351fea9157ed7e1e4) (cherry picked from commit 2f4dbe279f6b5eb87ec493d96f6943ffdb603ba0) 2020-04-22T09:53:41Z Li-Wen Hsu lwhsu@FreeBSD.org 2020-04-22T09:53:41Z urn:sha1:79959b84754f856487ecaba16916a8fb62d743cb They were fixed in r360140 PR: 245768 Sponsored by: The FreeBSD Foundation 2020-04-21T15:55:08Z Alex Richardson arichardson@FreeBSD.org 2020-04-21T15:55:08Z urn:sha1:f527d7de582277fbebe8897b082a726786cb11e9 Suggested by: cem 2020-04-20T17:48:10Z Li-Wen Hsu lwhsu@FreeBSD.org 2020-04-20T17:48:10Z urn:sha1:129ba2d368cfca7a2d762669a258c71a22f44311 PR: 245768 Sponsored by: The FreeBSD Foundation 2020-04-20T00:47:28Z Kyle Evans kevans@FreeBSD.org 2020-04-20T00:47:28Z urn:sha1:0fbdc3726a50a2e5f8530f08da858d3ff175d960 There were ultimately two separate problems here: - a 32-bit long cannot represent microseconds since 1970 (noted by ian) - time_t is 32-bit on i386, so now() was wrong anyways even with the correct return type. For the first, just explicitly use a uint64_t for now() and all of the callers. For the second, we need to explicitly cast tv_sec to uint64_t before it gets multiplied in the SEC_TO_US macro. Casting this instance rather than generally in the macro was arbitrarily chosen simply because all other uses are converting small relative time values. The tests now pass on i386, at least; presumably other ILP32 will be fine now as well. 2020-04-18T12:54:47Z Alex Richardson arichardson@FreeBSD.org 2020-04-18T12:54:47Z urn:sha1:c9c283bd3045c909671fc9aab250c35fe124ef35 Reviewed By: kevans Differential Revision: https://reviews.freebsd.org/D24296 2020-04-17T02:22:15Z Kyle Evans kevans@FreeBSD.org 2020-04-17T02:22:15Z urn:sha1:c17dd0e88b5db94cf641e862f50bdad436704598 Originally noticed while attempting to run the kqueue tests under qemu-user-static, this apparently just happens sometimes when running in a jail in general -- the timer will fire off "too early," but it's really just the result of imprecise measurements (noted by cem). Kicking this over to NOTE_USECONDS still tests the correct thing while allowing it to work more consistently; a basic sanity test reveals that we often end up coming in just less than 200 microseconds after the timer fired off. MFC after: 3 days 2020-04-06T23:08:07Z Kyle Evans kevans@FreeBSD.org 2020-04-06T23:08:07Z urn:sha1:ce6a89e27cd190313be39bb479880aeda4778436 vnode_fd and kqfd are both shared among multiple CU; define them exactly once. In the case of vnode_fd, it was simply the declaration that needed correction. -fno-common will become the default in GCC10/LLVM11. MFC after: 3 days 2018-12-06T09:22:35Z Li-Wen Hsu lwhsu@FreeBSD.org 2018-12-06T09:22:35Z urn:sha1:037479ff5ee18977b1c48e1e59770aad2f200a5a PR: 233586, 233587, 233588 Approved by: markj (mentor) Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D18362 2018-11-27T15:12:34Z David Bright dab@FreeBSD.org 2018-11-27T15:12:34Z urn:sha1:d34048812292b714a0bf99967270d18fe3097c62 After r337820, which "corrected" some spaces-instead-of-tab whitespace issues in the libkqueue tests, jmg@ pointed out that these files were originally space-based, not tab-spaced, and so the correction should have been to get rid of the tabs that had been introduced in previous changes, not the spaces. This change does that. This is a whitespace only change; no functional change is intended. Reported by: jmg@ MFC after: 3 days Sponsored by: Dell EMC Isilon