src/tests/sys, branch release/13.2.0

netlink: fix interface dump.

2023-03-06T19:37:56Z

The current code missed interface addition when reallocating temporary buffer. Tweak the code to perform the reallocation first and add interface afterwards unconditionally. Reported by: Marek Zarychta Approved by: re (cperciva) (cherry picked from commit 86fd0bdba540132ae298457e160b651f61d1db6b) (cherry picked from commit a800622765b1e7cab79fa857e9a671e6c0c1ccec)

sockets: add MSG_TRUNC flag handling for recvfrom()/recvmsg().

2023-02-09T18:01:49Z

Implement Linux-variant of MSG_TRUNC input flag used in recv(), recvfrom() and recvmsg(). Posix defines MSG_TRUNC as an output flag, indicating packet/datagram truncation. Linux extended it a while (~15+ years) ago to act as input flag, resulting in returning the full packet size regarless of the input buffer size. It's a (relatively) popular pattern to do recvmsg( MSG_PEEK | MSG_TRUNC) to get the packet size, allocate the buffer and issue another call to fetch the packet. In particular, it's popular in userland netlink code, which is the primary driving factor of this change. This commit implements the MSG_TRUNC support for SOCK_DGRAM sockets (udp, unix and all soreceive_generic() users). PR: kern/176322 Reviewed by: pauamma(doc) Differential Revision: https://reviews.freebsd.org/D35909 MFC after: 1 month (cherry picked from commit be1f485d7d6bebc53b055cc165a11ada0ab5fb17)

sched.h: Fix _S macros for better compatibility with glibc.

2023-02-06T19:06:30Z

In e2650af157 was added "_S" macros for compatibility with glibc, but it's still incompatible as under glibc the macros whose names end with "_S" operate on the dynamically allocated CPU set(s) whose size is in bytes, not in bits. While here remove limiting ifdef to non-kernel case. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D38110 MFC after: 1 week (cherry picked from commit 02f7670ed243498aea96150962c2c9916bab7c98)

netpfil tests: improve pfsync_defer.py

2023-01-29T05:37:46Z

Return different exit code depending on which failure was encountered. The pfsync test expect a very particular failure, not just any. MFC after: 1 week Sponsored by: InnoGames GmbH Differential Revision: https://reviews.freebsd.org/D38123 (cherry picked from commit 06012728beff45e94d58410eae7cda2ea980ef77)

netpfil tests: improve pft_ping.py

2023-01-29T05:37:46Z

Multiple improvements to pft_ping.py: * Automatically use IPv6 when IPv6 addresses are used, --ip6 is not needed. * Building of ping requests and parsing of ping replies is done layer by layer. This way most arguments are available both for IPv6 and IPv4, for ICMP and TCP. * Use argument groups for improved readability. * Change ToS and TTL argument name to TC and HL to reflect the modern IPv6 nomenclature. The argument still set related IPv4 header fields properly. * Instead of sniffing for the very specific case of duplicated packets, allow for sniffing on multiple interfaces. * Report which sniffer has failed by setting bits of error code. * Raise meaningful exceptions when irrecoverable errors happen. * Make IPv4 fragmentation flags configurable. * Make IPv6 HL / IPv4 TTL configurable. * Make TCP MSS configurable. * Make TCP sequence number configurable. * Make ICMP payload size configurable. * Add debug output. * Move command line argument parsing out of network functions. * Make the code somehow PEP-8 compliant. MFC after: 1 week Sponsored by: InnoGames GmbH Differential Revision: https://reviews.freebsd.org/D38122 (cherry picked from commit f57218e469a7b1ab40521ea75ebfd45b493851ca)

netpfil tests: improve sniffer.py

2023-01-29T05:37:46Z

Multiple improvements to sniffer.py: * Remove ambiguity of configuring recvif, it must be now explicitly specified. * Don't catch exceptions around creating the sniffer, let it properly fail and display the whole stack trace. * Count correct packets so that duplicates can be found. MFC after: 1 week Sponsored by: InnoGames GmbH Differential Revision: https://reviews.freebsd.org/D38120 (cherry picked from commit a39dedeb31052ec74b0cd394d56f8d7cc8534645)

pf tests: test fast port re-use with syncookies

2023-01-28T01:34:38Z

When a src/dst ip/port tuple is re-used before the pf state fully expires we clean up the state and create a new one, unless syncookies are enabled. Test this, by running two back-to-back nc sessions, with a fixed source port. Move the interface and IP to a different (vnet) jail, to trick the network stack into letting us do this. MFC after: 2 weeks Event: Aberdeen hackathon 2022 Differential Revision: https://reviews.freebsd.org/D36886 (cherry picked from commit dc698b2cd59ebc08b05a261dbba8ee5707450d28)

wg: Re-add basic if_wg(4) tests.

2023-01-24T05:18:28Z

These were originally added in commit 74ae3f3e33b810248da19004c58b3581cd367843 but have been updated to use wg(8). Reviewed by: kevans, markj Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D37400 (cherry picked from commit 8fb9739615da8922fbd8988ccd77093d4ca335ba)

netlink: allow creating sockets with SOCK_DGRAM.

2023-01-23T22:10:01Z

Some existing applications setup Netlink socket with SOCK_DGRAM instead of SOCK_RAW. Update the manpage to clarify that the default way of creating the socket should be with SOCK_RAW. Update the code to support both SOCK_RAW and SOCK_DGRAM. Reviewed By: pauamma Differential Revision: https://reviews.freebsd.org/D38075 (cherry picked from commit 0079d177ab69168df5e103128a2b15bd8e74d4eb)

netlink: fix compatibility with older netlink applications.

2023-01-23T22:09:05Z

Some apps try to provide only the non-zero part of the required message header instead of the full one. It happens when fetching routes or interface addresses, where the first header byte is the family. This behavior is "illegal" under the "strict" Netlink socket option, however there are many applications out there doing things in the "old" way. Support this usecase by copying the provided bytes into the temporary zero-filled header and running the parser on this header instead. Reported by: Goran Mekić (cherry picked from commit 228c632ab3f6245df4a08d8692d49c8e12aacc27)