src/tests/sys, branch release/14.3.0

queue(3): Add simple tests for some macros for all list/tailq types

2025-05-01T19:48:48Z

These essentially test building a list/tailq of 100 elements with _INSERT_HEAD(), iterating over them with _FOREACH(), splitting it with _SPLIT_AFTER() and concatenating back the results with _CONCAT(), checking that the lists/tailqs at each step have the right number of elements and at the expected positions. Reviewed by: markj MFC after: 2 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D49975 (cherry picked from commit 4fa275a5f35742a5d662db7106d20819329dc8f2)

fusefs: slightly better debugging in the tests

2025-04-17T20:14:58Z

If the kernel rejects a response written by the server, print it. That would most likely be due to an error in the test logic. MFC after: 2 weeks Sponsored by: ConnectWise (cherry picked from commit 564c732b5c0221373d067c9a21da09b310e676ae) fusefs: fix the 32-bit build after 564c732b5c0 It's a printf format specifier again. MFC with: 564c732b5c0221373d067c9a21da09b310e676ae Sponsored by: ConnectWise (cherry picked from commit 52f7eb31ae84b0a02cd79c857c3201cb7b65c00f)

fusefs: add a test for the max_read= mount option

2025-04-17T20:14:58Z

When set, this limits the amount of data that the kernel will request of the server in any single read operation. The option has always been available in our fusefs implementation, but never covered by the test suite. MFC after: 2 weeks Sponsored by: ConnectWise (cherry picked from commit 9f31c47460412ab6ccae36a70ca019b47423ccec)

fusefs: minor refactor in the tests

2025-04-17T20:14:57Z

Do more work in MockFS's constructor's member initializer list, instead of the body of the constructor. It's easier to read this way. Sponsored by: ConnectWise (cherry picked from commit 3f83f32d7d07afbb2dbff63fc6ec520f3341eec7)

pfctl: fix recursive printing of NAT rules

2025-04-16T07:34:56Z

pfctl_show_nat() is called recursively to print nat anchors. This passes the anchor path, but this path was modified by pfctl_show_nat(), leading to issues printing the anchors. Make a copy of the path ('npath') before we modify it. Ensure we do this correctly by sprinking in 'const', and add a test case to verify that we do now print things correctly. Reported by: Thomas Pasqualini MFC after: 2 weeks Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 58164dcb55d62ca73b5e550b8344bf61e2d8a47a)

if_ovpn: fix use-after-free of mbuf

2025-04-15T07:27:09Z

m_unshare() can return a new mbuf pointer. We update the 'm' pointer in ovpn_udp_input(), but if we decide to pass on the packet (e.g. because it's for an unknown peer) the caller (udp_append()) continues with the old 'm' pointer, eventually resulting in a use-after-free. Re-order operations in ovpn_udp_input() so that we don't modify the 'm' pointer until we're committed to keeping the packet. PR: 283426 Test case by: takahiro.kurosawa@gmail.com MFC after: 2 weeks Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 04a7134c1e92c7752ffdc665f99ae26db70866c0)

ptrace_test: add test for expanded reporting of syscall args

2025-04-07T01:28:23Z

(cherry picked from commit 526becbf6e42331e3680d55fe1e9a82e1b56a735)

fibs tests: Fix test failures and simplify

2025-04-06T18:08:18Z

The tests previously expected the invoker to pass a list of FIBs to use. However, they now run in separate VNET jails, so we can simply expand the FIB array as needed in each test. Modify each test to simply set net.fibs as needed and grab FIB numbers starting at 1. A number of tests were also broken by commit 9206c7996198 ("usr.bin/netstat: -n should not print symbolic names"), so fix those. Reviewed by: asomers Fixes: 9206c7996198 ("usr.bin/netstat: -n should not print symbolic names") MFC after: 2 weeks Sponsored by: Klara, Inc. Sponsored by: Stormshield Differential Revision: https://reviews.freebsd.org/D48585 (cherry picked from commit 81b076e43aa63ac255996093233ab3560a23977e) Note, the netstat-related changes described above are not merged.

netmap: fix unit tests

2025-04-06T18:05:05Z

After ad874544d9f018bf8eef4053b5ca7b856c4674cb, interface name validation has been removed, resulting in two unit tests failures. Drop the failing tests since they no longer apply. Reported by: markj (cherry picked from commit ee5804da116f2107451c8b4376b69b3a64a630e8)

sound: Implement AFMT_FLOAT support

2025-04-06T00:28:14Z

Even though the OSS manual [1] advises against using AFMT_FLOAT, there are applications that expect the sound driver to support it, and might not work properly without it. This patch adds AFMT_F32_LE|BE (as well as AFMT_FLOAT for OSS compatibility) in sys/soundcard.h and implements AFMT_F32_LE|BE <-> AFMT_S32_LE|BE conversion functions. As a result, applications can write/read floats to/from sound(4), but internally, because sound(4) works with integers, we convert floating point samples to integer ones, before doing any processing. The reason for encoding/decoding IEEE754s manually, instead of using fpu_kern(9), is that fpu_kern(9) is not supported by all architectures, and also introduces significant overhead. The IEEE754 encoding/decoding implementation has been written by Ariff Abdullah [2]. [1] http://manuals.opensound.com/developer/AFMT_FLOAT.html [2] https://people.freebsd.org/~ariff/utils/ieee754.c PR: 157050, 184380, 264973, 280612, 281390 Sponsored by: The FreeBSD Foundation MFC after: 1 week Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D47638 (cherry picked from commit e1bbaa71d62c8681a576f9f5bedf475c7541bd35)