src/tools/regression/geom_gpt, branch releng/12.1 FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=releng%2F12.1 2017-06-10T20:56:31Z Improve handling with system state 2017-06-10T20:56:31Z Enji Cooper ngie@FreeBSD.org 2017-06-10T20:56:31Z urn:sha1:22184bfa63cf3411a78c3cb0a28868dfbc7320a9 - Always unlink $cmd after exit via END block. - The tests don't function well if kern.geom.debugflags != 0. Save debugflags, then restore them at the end of the test. MFC after: 1 month Sponsored by: Dell EMC Isilon Don't explicitly get the class to PART in gctl_test_helper.c 2017-06-10T19:48:45Z Enji Cooper ngie@FreeBSD.org 2017-06-10T19:48:45Z urn:sha1:e15b2a7854b77974f32d6a82faf31b0abf08655a This will allow the tool to be used with arbitrary geom(4) classes, like GEOM. Specify class=PART explicitly in the tester to keep existing behavior. MFC after: 1 month Sponsored by: Dell EMC Isilon Use calloc instead of malloc + memset 2017-05-27T23:57:09Z Enji Cooper ngie@FreeBSD.org 2017-05-27T23:57:09Z urn:sha1:73dcfb8ddc0645d6b92d980fbdf083bfae040cf7 MFC after: 3 days Sponsored by: Dell EMC Isilon gctl_test.t: catch errors with the mdcfg directive 2017-04-23T02:30:06Z Enji Cooper ngie@FreeBSD.org 2017-04-23T02:30:06Z urn:sha1:67b1f73f1ec2189a7d8f4a7c475a01a4e1288e5c While here, add a note about certain testcases relying on `count=1024` in the "create" portion. MFC after: 5 weeks Sponsored by: Dell EMC Isilon gctl_test.t: improve error reporting with mdcfg and mount directives 2017-04-22T23:30:02Z Enji Cooper ngie@FreeBSD.org 2017-04-22T23:30:02Z urn:sha1:d1f57d5900f0ef02414b41f2ebe92af63717d6a6 If the commands had failed previously, it would press on and result in a series of cascading failures. Fail early and continue on to the next case instead of executing additional commands after a previously failed series of steps. MFC after: 5 weeks Sponsored by: Dell EMC Isilon gctl_test.t: more tweaks to try and update the code and get it functional (again?) 2017-04-22T23:27:40Z Enji Cooper ngie@FreeBSD.org 2017-04-22T23:27:40Z urn:sha1:9940eaaa17b17b1f4a106cd68130e27ec2832eca - Make the logfile for $out be built off the basename for $cmd, instead of $cmd. (r317292 broke this assumption). - Rename $mntpt to $mntpt_prefix for clarity, as this variable is a prefix for mountpoints. - Reindent the umount directive block while here to match the rest of the code. MFC after: 5 weeks Sponsored by: Dell EMC Isilon Use verb=delete not verb=remove 2017-04-22T23:06:53Z Enji Cooper ngie@FreeBSD.org 2017-04-22T23:06:53Z urn:sha1:414bf3a177fcbeea3dd67ef568f1f838714d84ed The `remove` verb hasn't been present in geom_part*(4) for well over a decade, if ever. I couldn't find any references to it in ^/stable/5 at least, which is around the timeframe that this test was written. MFC after: 5 weeks Sponsored by: Dell EMC Isilon gctl_test.t: minor tweaks 2017-04-22T22:40:39Z Enji Cooper ngie@FreeBSD.org 2017-04-22T22:40:39Z urn:sha1:acca703a09d3567140e2080e37c51e70cd59a2cd - Declare $count with the `my` scope operator to permit `use strict`. - Add `use strict`. - Use `use warnings` instead of using `-w` in the shebang. - Don't unlink $cmd when done (prevents unnecessary rebuilding). - Improve the error message when running with insufficient permissions, e.g., non-root. MFC after: 5 weeks Sponsored by: Dell EMC Isilon gctl_test_helper: add diagnostic output for parse_retval(..) 2017-04-22T22:34:45Z Enji Cooper ngie@FreeBSD.org 2017-04-22T22:34:45Z urn:sha1:29924a1c128739dd405d5463ee03458382f2f403 This will help end-users better diagnose issues with the function. MFC after: 5 weeks Sponsored by: Dell EMC Isilon The GPT class no longer exists; use the PART class instead 2017-04-22T20:51:54Z Enji Cooper ngie@FreeBSD.org 2017-04-22T20:51:54Z urn:sha1:d55eb4ff7e0beae67d84f615df35e65bdbff8e63 MFC after: 5 weeks Sponsored by: Dell EMC Isilon