FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=release%2F13.1.0 2020-11-16T18:41:49Z 2020-11-16T18:41:49Z Mitchell Horne mhorne@FreeBSD.org 2020-11-16T18:41:49Z urn:sha1:a521f2116473fbd8c09db395518f060a27d02334 The program reads oldsize bytes from oldfile, and proceeds to initialize a suffix array of oldsize elements using divsufsort(). As per the function's API [1], array indices 0 through n-1 are initialized. Later, search() is called, but with index bounds [0, n]. Depending on the contents of the malloc'd buffer, accessing this uninitialized index at the end of can result in a segmentation fault. Fix this by passing oldsize-1 to search(), limiting the search bounds to [0, n-1]. This bug is a result of r303285, which introduced divsufsort() as an alternate suffix sorting function to the existing qsufsort(). It seems that qsufsort() did initialize the final empty element, meaning it could be safely accessed. This difference in the implementations was missed at the time. [1] https://github.com/y-256/libdivsufsort Discussed with: cperciva MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D26911 2019-09-26T13:27:25Z Ed Maste emaste@FreeBSD.org 2019-09-26T13:27:25Z urn:sha1:20bd59416dcacbd2b776fe49dfa193900f303287 Introduce a new add_off_t static function that exits with an error message if there's an overflow, otherwise returns their sum. Use this when adding values obtained from the input patch. Reviewed by: delphij, allanjude (earlier) MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D7897 2019-07-18T07:37:26Z Xin LI delphij@FreeBSD.org 2019-07-18T07:37:26Z urn:sha1:9344e4d73860cfcf943e716de9aa7f19f8e26838 No MFC planned as that revision was not merged. 2019-07-18T07:26:30Z Xin LI delphij@FreeBSD.org 2019-07-18T07:26:30Z urn:sha1:c93b6e5fa24ba172ab271432c6692f9cc604e15a MFC after: 1 month 2018-11-07T21:01:14Z Mariusz Zaborski oshogbo@FreeBSD.org 2018-11-07T21:01:14Z urn:sha1:a25896ca1270e25b657ceaa8d47d5699515f5c25 Assume that user wants to run with capsicum support if he builds the software with HAVE_CAPSICUM. Treat running application without capsicum in the kernel as an error. MFC after: 3 weeks 2017-11-27T15:37:16Z Pedro F. Giffuni pfg@FreeBSD.org 2017-11-27T15:37:16Z urn:sha1:1de7b4b805ddbf2429da511c053686ac4591ed89 Mainly focus on files that use BSD 2-Clause license, however the tool I was using misidentified many licenses so this was mostly a manual - error prone - task. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts. No functional change intended. 2017-10-31T00:07:04Z Bryan Drewery bdrewery@FreeBSD.org 2017-10-31T00:07:04Z urn:sha1:ea825d02749f382c3f7e17f28247f20a48733eab Sponsored by: Dell EMC Isilon 2017-03-31T03:11:25Z Allan Jude allanjude@FreeBSD.org 2017-03-31T03:11:25Z urn:sha1:f901525697b8282ee9ec14b9de6400afab61750e 2017-03-31T03:08:07Z Allan Jude allanjude@FreeBSD.org 2017-03-31T03:08:07Z urn:sha1:8554754c7bbe3cda171378ad6305bbe8a1a94cb6 top(1) read the wrong amount of data from sysctl, uint64_t instead of boolean_t, resulting in the stats not showing in many cases. X-MFC-With: r315435 Sponsored by: ScaleEngine Inc. 2017-03-12T18:58:44Z Warner Losh imp@FreeBSD.org 2017-03-12T18:58:44Z urn:sha1:a35f04fba2ebb8f86d4cbdc710c89a094572b08e Prefer ${SRCTOP}/foo over ${.CURDIR}/../../foo and ${SRCTOP}/usr.bin/foo over ${.CURDIR}/../foo for paths in Makefiles. Differential Revision: https://reviews.freebsd.org/D9932 Sponsored by: Netflix Silence on: arch@ (twice)