src/usr.bin/diff/diffreg.c, branch releng/12.2

MFC r356723-r356725, r357649, r357652: diff(1) catch-up

2020-04-27T22:33:32Z

r356723: mkstemp returns -1 r356724: asprintf returns -1, not an arbitrary value < 0. Also upon error the (very sloppy specification) leaves an undefined value in *ret, so it is wrong to inspect it, the error condition is enough. r356725: When system calls indicate an error they return -1, not some arbitrary value < 0. errno is only updated in this case. r357649: Update diff(1) TODO removing what has been implemented r357652: Fix most of the style warnings

MFC r357648:

2020-03-04T11:28:49Z

diff: implement -y (--side-by-side) along with -W and --suppress-common-lines PR: 219933 Submitted by: fehmi noyan isi

MFC r356695, r356731:

2020-01-20T01:38:03Z

Optimize diff -q. PR: 242828

MFC r340138 (by oshogbo):

2019-12-06T18:26:34Z

capsicum: use a new capsicum helpers in tools

diff(1): Refactor -B a little bit

2018-08-19T04:15:38Z

Instead of doing a second pass to skip empty lines if we've specified -I, go ahead and check both at once. Ignore critera has been split out into its own function to try and keep the logic cleaner.

diff(1): Implement -B/--ignore-blank-lines

2018-08-19T03:57:20Z

As noted by cem in r338035, coccinelle invokes diff(1) with the -B flag. This was not previously implemented here, so one was forced to create a link for GNU diff to /usr/local/bin/diff Implement the -B flag and add some primitive tests for it. It is implemented in the same fashion that -I is implemented; each chunk's lines are scanned, and if a non-blank line is encountered then the chunk will be output. Otherwise, it's skipped. MFC after: 2 weeks

Improve --strip-trailing-cr handling:

2018-07-27T05:21:20Z

- Advance ctold for f1 and ctnew for f2 - ungetc() if the character is unexpected - Don't break early when we hit the combination on one side PR: 230049 Reported by: maskray Reviewed by: bapt, maskray MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D16451

Convert `cap_enter() < 0 && errno != ENOSYS` to `caph_enter() < 0`.

2018-06-19T23:43:14Z

No functional change intended.

Isolate the pr(1) related code in its own source files

2018-06-09T20:24:17Z

This keeps diffreg.c closer to what it is supposed to do: diffing regular files. It also allows my code to get a proper license

Replace homemade equivalent of tolower(3) by towlower(3)

2017-12-13T16:09:00Z

This will help in the futur making diff -i works with multibyte