src/usr.bin/diff/pr.c, branch releng/14.4FreeBSD source treehttps://cgit-dev.freebsd.org/src/atom?h=releng%2F14.42026-02-11T06:14:26Zdiff: Fix pagination leak2026-02-11T06:14:26ZDag-Erling Smørgravdes@FreeBSD.org2026-02-05T14:39:53Zurn:sha1:6761e555376e375f89fe36c72f2813f5e64a7f63
* Drop an unnecessary variable and rename pidfd to procd.
* Rewinding stdout serves no purpose, so stop doing it.
* Don't bother freeing memory or setting the global status right
before erroring out.
* Error out if dup(2) or dup2(2) fail.
* In the unlikely case that our pipe is equal to stdout, we need to
record that information so we don't close it when cleaning up.
* Don't bother closing a descriptor before dup2(2)ing to it.
* Don't forget to close the the process descriptor after reaping the
child process.
Approved by: re (cperciva)
PR: 266592
MFC after: 1 week
Sponsored by: Klara, Inc.
Reviewed by: kevans, markj
Differential Revision: https://reviews.freebsd.org/D55112
(cherry picked from commit c3904a7de78ca1ca15fcdf4c09f9d4be7f6fe6f5)
(cherry picked from commit 144455c333dc0d3db369596038de2e3dd6113b46)
Remove $FreeBSD$: one-line .c pattern2023-08-16T17:54:42ZWarner Loshimp@FreeBSD.org2023-08-16T17:54:42Zurn:sha1:1d386b48a555f61cb7325543adbbb5c3f3407a66
Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
Fix indentation in usr.bin/diff/pr.c2022-03-04T19:46:56ZDimitry Andricdim@FreeBSD.org2022-02-28T20:06:19Zurn:sha1:f7d6e97e4bf1fe4c70d5b0ef9fdf649bf07e1c91
In commit 6fa5bf0832ef the pr(1) related code in diff was moved around,
but some part of the indentation was messed up, and one line was
duplicated. Remove the duplicated line, and fix up the indentation.
Reviewed by: bapt
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D34398
Fix memory leak2018-06-12T16:42:11ZBaptiste Daroussinbapt@FreeBSD.org2018-06-12T16:42:11Zurn:sha1:43d7b1c097bdd90eaadcaf41d87d526ca02f72b0
CID: 1393352
Correctly test return value of pipe(2)2018-06-12T16:40:22ZBaptiste Daroussinbapt@FreeBSD.org2018-06-12T16:40:22Zurn:sha1:5a43dca273c2628bb4936deb168acb063da5cee9
CID: 1393351
Isolate the pr(1) related code in its own source files2018-06-09T20:24:17ZBaptiste Daroussinbapt@FreeBSD.org2018-06-09T20:24:17Zurn:sha1:6fa5bf0832efe8a894f612968c5afe1ad91f3a03
This keeps diffreg.c closer to what it is supposed to do:
diffing regular files.
It also allows my code to get a proper license