src/usr.bin/diff, branch main

diff: Correct fd 0 case on pipe

2026-06-03T20:50:38Z

After git commit c8d40bf8ecc60cc15e3904410db62065ea681fdc, if fd 0 was not open, it is left with CLOEXEC set and therefore fails. This is an unlikely situation, but fixing it reduces the size of the code (by using posix_spawn_file_actions_adddup2's special case if the two file descriptor numbers are the same). At the same time, check the error code from posix_spawn_file_actions_adddup2. Reviewed by: bapt Differential Revision: https://reviews.freebsd.org/D56910

diff: use O_CLOEXEC on pipes

2026-03-28T08:55:24Z

This only simplifies the code, no functional changes expected MFC After: 1 week

diff: handle read(2) failures

2026-03-26T09:25:50Z

MFC After: 1 week

diff: prefer posix_spawn over pdfork/execl

2026-03-26T07:36:55Z

MFC After: 1 week Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D56076

diff: Add SPDX-License-Identifier tag

2026-02-19T13:25:40Z

Reviewed by: emaste Sponsored by: The FreeBSD Foundation

diff: Drop unnecessary casts, fix none algo

2026-02-18T18:28:29Z

MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D55349

diff: Tweak recursion tests

2026-02-13T20:19:16Z

The -r flag is not required to compare two directories; it is only required to compare them recursively, i.e. descend into their common subdirectories. Adjust tests that use -r needlessly, and adjust the dirloop test to verify that these two cases remain distinct. MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: kevans Differential Revision: https://reviews.freebsd.org/D55262

diff: Tweak range of -C and -U arguments

2026-02-13T20:19:16Z

POSIX uses the terms “positive decimal integer” for -C and “non-negative decimal integer” for -U, which translates into lower bounds of 1 for -C and 0 for -U. POSIX does not specify a minimum upper bound for either mode, but as of 5fc739eb5949 both our backends support context sizes up to and including INT_MAX, so use that. Having had the opportunity to consult the Unix System Test Suite, the diff test cases found therein happen to precisely match these bounds. While here, switch to using strtonum() to parse numerical arguments, and try to be more consistent in how we report usage errors. MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: kevans Differential Revision: https://reviews.freebsd.org/D55261

diff: Improve directory loop detection

2026-02-11T16:24:54Z

When we're done processing a directory, remove its entry from the tree of visited inodes, ensuring that we only report a loop when we encounter a descendant-to-ancestor link, not when we encounter a cousin-to-cousin or sibling-to-sibling link. MFC after: 1 week Reported by: Bakul Shah Sponsored by: Klara, Inc. Reviewed by: kevans Differential Revision: https://reviews.freebsd.org/D55248

diff: Bump version number

2026-02-06T00:14:05Z

MFC after: 1 week Sponsored by: Klara, Inc.