src/usr.bin/elfctl, branch release/13.2.0

elfctl: whitespace cleanup

2022-02-22T19:54:41Z

Reported by: jrm (in review D34283) (cherry picked from commit 828e50092ac84f50247fb3f400027fc7510d8141)

elfctl: fix operations with multiple features on multiple files

2022-02-18T00:31:57Z

Previously an invocation like elfctl -e +feature1,feature2 file1 file2 would set both feature flags in file 1 but only feature1 in file2 (due to the string being modified by strsep()). Reported by: jrm Tested by: jrm MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D34283 (cherry picked from commit 82b611ed18e6bfaeadf152ef9216230548c25a8a)

elfctl: error if -e is specified multiple times

2022-02-18T00:31:46Z

Reported by: jrm MFC after: 3 days Sponsored by: The FreeBSD Foundation (cherry picked from commit f0cf9b602dc0375dfc279500e0314b7c55273bf0)

elfctl: fix -e invalid operation error handling

2022-02-18T00:31:26Z

Validate the operation prior to parsing the feature string, so that e.g. -e 0x1 reports invalid operation '0' rather than invalid feature 'x11'. Also make it an error rather than a warning, so that it is not repeated if multiple files are specified. (Previously an invalid operation resulted in a segfault.) MFC after: 3 days Sponsored by: The FreeBSD Foundation (cherry picked from commit b8185579f457569640f714b6180522619c2f18ea)

elfctl: update man page example for 'no' prefix

2022-02-09T17:28:41Z

Reported by: Mark Millard on freebsd-current@ Fixes: c763f99d11fd ("elfctl: prefix disable flags with "no"") MFC after: 1 week Sponsored by: The FreeBSD Foundation (cherry picked from commit dbc7364b1840ef3f36994952d085add5d161775d)

exec: Remove the stack gap implementation

2022-01-31T14:48:57Z

ASLR stack randomization will reappear in a forthcoming commit. Rather than inserting a random gap into the stack mapping, the entire stack mapping itself will be randomized in the same way that other mappings are when ASLR is enabled. No functional change intended, as the stack gap implementation is currently disabled by default. Reviewed by: kib Sponsored by: The FreeBSD Foundation (cherry picked from commit 758d98debec43ff83b8a1ed9a3d3a8441b83b3cc)

usr.bin/elfctl: Allow for cross-endian operations.

2021-12-12T18:59:30Z

Detect if host endian is different than target endian and swap byte order of ELF note fields instead of failing. Submitted by: Dawid Gorecki Reviewed by: imp Obtained from: Semihalf Sponsored by: Stormshield Differential Revision: https://reviews.freebsd.org/D29550 (cherry picked from commit 4a27bf128b108d90412190c06a54ebac36a8ca2e)

elfctl: avoid touching file if no change made

2021-06-02T02:08:54Z

Suggested by: brooks Reviewed by: brooks, markj MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D30452 (cherry picked from commit 3f2508b7f3855102abed99b846e30e728ba3d04d)

elfctl: allow features to be specified by value

2021-01-26T14:44:12Z

This will allow elfctl on older releases to set bits that are not yet known there, so that the binary will have the correct settings applied if run on a later FreeBSD version. PR: 252629 (related) Suggested by: kib Reviewed by: gbe (manpage, earlier), kib Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D28284 (cherry picked from commit 86f33b5fcf6087bf4439881011b920ff99e6e300) elfctl: fix typo from last-minute refactoring Reported by: jkim (cherry picked from commit f302fd1aa6730facd53a3f761e0a57302731b03e) elfctl: Fix type errors. Target value for val has uint32_t type, not uint, adjust used constant. Change val type to unsigned so that left and right sides of comparision operator do not expose different signed types of same range [*]. Switch to unsigned long long and strtoll(3) so that 0x80000000 is accepted by conversion function [**]. Reported by: kargl [*] Noted by: emaste [**] Reviewed by: emaste Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D28301 (cherry picked from commit 9940ac808de7b7d4ed0408c3e739f667dca06d3b)

elfctl: prefix disable flags with "no"

2021-01-14T20:09:13Z

Some ELF feature flags indicate a request to opt-out of some feature, for example NT_FREEBSD_FCTL_ASLR_DISABLE indicates that ASLR should be disabled for the tagged binary. Using "aslr" as the short name for the flag is confusing as it seems to indicate a request for ASLR to be enabled. Rename "noaslr", and make a similar change for other opt-out flags. Reviewed by: bapt, manu, markj MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D28139