src/usr.bin/pkill/pkill.c, branch main

pkill(1) first appeared in /usr/bin, but later it was moved to /bin

2008-08-31T14:27:59Z

for the convenience of rc.d. Now it has happily lived there for quite a while. So move the pkill(1) source files from usr.bin to bin, too. Approved by: gad

Fix and extend the -j option to pkill/pgrep WRT the jail

2006-11-23T11:55:17Z

wildcard specifications. Earlier the only wildcard syntax was "-j 0" for "any jail". There were at least two shortcomings in it: First, jail ID 0 was abused; it meant "no jail" in other utils, e.g., ps(1). Second, it was impossible to match processed not in jail, which could be useful to rc.d developers. Therefore a new syntax is introduced: "-j any" means any jail while "-j none" means out of jail. The old syntax is preserved for compatibility, but now it's deprecated because it's limited and confusing. Update the respective regression tests. While I'm here, make the tests more complex but sensitive: Start several processes, some in jail and some out of jail, so we can detect that only the right processes are killed by pkill or matched by pgrep. Reviewed by: gad, pjd MFC after: 1 week

Sync as close as possible with NetBSD.

2005-11-16T11:03:00Z

This includes fixes and cleanups listed below: - If a process dissappears while we are signalling it, don't count it as a match/error. - Better handling of errors and messages. - Downgrade failure to kill(2) (other than ESRCH) from fatal error to a warning; otherwise processing aborts and possibly matching killees would remain unsignalled. This makes pkill match the Solaris behavior. - Exit with 2 on usage errors as documented. Obtained from: NetBSD Glanced at by: maintainer (gad) [a bit different version of this patch]

I often find myself doing:

2005-11-16T10:36:44Z

% pgrep [to verify which processes match] % pkill To speed such operation up, add -I option which works like rm(1)'s -i option (unfortunately -i is already used in pkill(1)), ie. pkill will ask for confirmation before killing each matching process. After adding -j, -F, -i, -S, -o and -L options and other improvements, I think I can add myself to the copyright header. Glanced at by: maintainer (gad)

Revert previous behaviour of '-F' option and add '-L' option, which will

2005-08-25T20:10:47Z

tell pkill(1)/pgrep(1) to try to flock(2) pidfile before reading PID from there. Discussed with: jhb, gad

Modify '-F' option to work nicely with pidfile(3) - a pidfile given as

2005-08-24T19:38:28Z

an argument has to be locked.

Whitespace fixes.

2005-03-20T11:47:44Z

- Introduce an '-o' option which allows to match oldest of the matching

2005-03-20T11:42:26Z

processes. This option can be also found in Solaris and Linux. - Use timercmp(9) macro for timeval comparsion. - Include time.h directly, don't depend on stat.h doing it for us. Reviewed by: gad (first point) MFC after: 3 days

- Introduce '-S' option which allows to match system processes (pgrep only).

2005-03-20T11:30:26Z

- Rename IS_KERNPROC() macro to PSKIP() and extend its functionality. Now it'll skip calling process and system processes when -S is not given. As a side effect it fixes '-n' option. Before it was always matching calling process (because of missing 'if (kp->ki_pid == mypid)' check) and after that, calling process was ignored. - When '-l' option is given and there are no arguments, use p_comm as an arguments list (this is helpful for kernel threads matching). Reviewed by: gad MFC after: 3 days

Add a -i option to ignore case in the process match.

2005-03-20T11:12:13Z

Obtained from: NetBSD Reviewed by: gad MFC after: 3 days