src/usr.bin/stat, branch releng/12.2

stat(1): cache id->name resolution

2018-08-11T02:56:43Z

When invoked on a large list of files, it is most common for a small number of uids/gids to own most of the results. Like ls(1), use pwcache(3) to avoid repeatedly looking up the same IDs. Example microbenchmark and non-scientific results: $ time (find /usr/src -type f -print0 | xargs -0 stat >/dev/null) BEFORE: 3.62s user 5.23s system 102% cpu 8.655 total 3.47s user 5.38s system 102% cpu 8.647 total AFTER: 1.23s user 1.81s system 108% cpu 2.810 total 1.43s user 1.54s system 107% cpu 2.754 total Does this microbenchmark have any real-world significance? Until a use case is demonstrated otherwise, I doubt it. Ordinarily I would be resistant to optimizing pointless microbenchmarks in base utilities (e.g., recent totally gratuitous changes to yes(1)). However, the pwcache(3) APIs actually simplify stat(1) logic ever so slightly compared to the raw APIs they wrap, so I think this is at worst harmless. PR: 230491 Reported by: Thomas Hurst Discussed with: gad@

various: general adoption of SPDX licensing ID tags.

2017-11-27T15:37:16Z

Mainly focus on files that use BSD 2-Clause license, however the tool I was using misidentified many licenses so this was mostly a manual - error prone - task. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts. No functional change intended.

DIRDEPS_BUILD: Update dependencies.

2017-10-31T00:07:04Z

DIRDEPS_BUILD: Connect new directories.

2017-10-31T00:04:07Z

Add HAS_TESTS to all Makefiles that use the SUBDIR.${MK_TESTS}+= tests idiom

2017-08-02T08:14:06Z

:l_flag:: be more aggressive when normalizing whitespace

2017-07-06T07:37:03Z

Save output from ls -ldT and stat -l, then normalize all repeating whitespace using sed to single column spaces. This makes the test flexible with single-digit days, etc, similar to r320723. This approach is just a bit more of a hammer approach because of how the columns are ordered/spaced in both ls and stat. MFC after: 1 week MFC with: r319841

Use %e instead of %d with x_output_date(..)

2017-07-06T06:15:44Z

stat -x doesn't 0-fill days so %d is inappropriate. %e is correct. MFC after: 1 week MFC with: r319841

Add initial tests for stat(1)

2017-06-12T00:21:55Z

Testcases for -H, -L, and -f haven't been implemented yet, in part due to additional complexity needed to validate the features: * -H and -f will require an external "helper" program to display/modify the state/permissions for a given path. * -L is being covered partially via the -n testcase today. MFC after: 1 month

stat(1): sort flags in the DESCRIPTION section

2017-06-11T21:23:54Z

-x's description should come after -t's description. MFC after: 1 month Sponsored by: Dell EMC Isilon

Write up some basic tests for readlink(1)

2017-06-11T21:13:12Z

The tests exercise -f (f_flag), -n (n_flag), and no arguments (basic). MFC after: 1 month Sponsored by: Dell EMC Isilon