FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=releng%2F14.3 2024-02-25T18:03:17Z 2024-02-25T18:03:17Z Gleb Smirnoff glebius@FreeBSD.org 2024-02-20T18:31:05Z urn:sha1:1e74fc950419f2b2482d313fc664cc03aa46f13c When setting a permanent ARP entry, the route(4) would use rtm->rtm_rmx.rmx_expire == 0 as a flag for installing a static entry, but netlink(4) is looking for explicit NTF_STICKY flag in the request. The arp(8) utility was adopted to use netlink(4) by default, but it has lots of route-era guts internally. Specifically there is global variable 'opts' that shares configuration for both protocols, and it is still initialized with route(4) specific RTF_xxx flags. In set_nl() these flags are translated to netlink(4) parameters. However, RTF_STATIC is a flag that is never set by default, so attempt to use it as a proxy flag manifesting -s/-S results in losing it. Use zero opts.expire_time as a manifest of -s/-S operation. This is a minimal fix. A better one would be to fully get rid of route(4) legacy. The change also corrects the logic to set NUD_PERMANENT flag for consistency. This flag is ignored by our kernel (now). Reviewed by: melifaro, tuexen, emaste PR: 277063 Fixes: 6ad73dbf65048b0950a1ba6ff25607f6708c8954 Differential Revision: https://reviews.freebsd.org/D43983 (cherry picked from commit 6a3e87e1306d5058d63f7552a25ed6376422f658) 2023-10-24T07:45:20Z Kristof Provost kp@FreeBSD.org 2023-10-16T09:48:57Z urn:sha1:72b97a4e28617b600cc21eb51664d1e1f6e6f923 If a request ends up growing beyong the initially allocated space the netlink functions (such as snl_add_msg_attr_u32()) will allocate a new buffer. This invalidates the header pointer we can have received from snl_create_msg_request(). Always use the hdr returned by snl_finalize_msg(). Reviewed by: melifaro MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D42223 (cherry picked from commit 4f8f43b06ed07e96a250855488cc531799d5b78f) 2023-09-30T13:26:12Z R. Christian McDonald rcm@rcm.sh 2023-09-14T07:07:24Z urn:sha1:f21f0d2e16af702c53bc150c6c23d1bc99399bcd arp(8) has traditionally supported filtering by interface via -i and by hostname. However, this functionality was omitted from the initial netlink-ification of arp. This patch re-introduces this filtering functionality. This patch also improves by-interface filtering by storing and using the ifindex of the requested interface for filtering instead of comparing interface name strings Reviewed by: melifaro Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 79278872ad966e5f54805efbeb692c8cbc0306c8) 2023-08-16T17:55:15Z Warner Losh imp@FreeBSD.org 2023-08-16T17:55:15Z urn:sha1:b2c76c41be32f904179efed29c0ca04d53f3996c Remove /^\.\\"\s*\$FreeBSD\$$\n/ 2023-08-16T17:55:03Z Warner Losh imp@FreeBSD.org 2023-08-16T17:55:03Z urn:sha1:d0b2dbfa0ecf2bbc9709efc5e20baf8e4b44bbbf Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/ 2023-08-16T17:54:42Z Warner Losh imp@FreeBSD.org 2023-08-16T17:54:42Z urn:sha1:1d386b48a555f61cb7325543adbbb5c3f3407a66 Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/ 2023-07-07T16:45:18Z Alfonso Gregory gfunni234@gmail.com 2023-07-07T16:39:23Z urn:sha1:72e1ea2f13619f3bd299348f281815a6669f3775 In most cases, usage does not return, so mark them as __dead2. For the cases where they do return, they have not been marked __dead2. Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/735 2023-05-27T13:25:16Z Alexander V. Chernikov melifaro@FreeBSD.org 2023-05-27T13:25:16Z urn:sha1:c90901245e9c1816f2a2c2d1e2242b0772f4bd31 2023-04-26T20:18:53Z John Baldwin jhb@FreeBSD.org 2023-04-26T20:18:53Z urn:sha1:2d7842d0bfb4257c5b1aba5c1e6f79e47735d71c 2023-04-26T13:26:37Z Alexander V. Chernikov melifaro@FreeBSD.org 2023-04-26T12:29:43Z urn:sha1:52199877a658842f81f1e997205ff26fb781a5a0