src/usr.sbin/bootparamd, branch release/13.2.0FreeBSD source treehttps://cgit-dev.freebsd.org/src/atom?h=release%2F13.2.02022-02-09T17:26:18ZFix too small hostname buffer in bootparamd2022-02-09T17:26:18ZDimitry Andricdim@FreeBSD.org2022-02-06T14:25:22Zurn:sha1:50cf1cf36898f8697c32c79e8e7fd279deeee514
This fixes the following warning from clang 14:
usr.sbin/bootparamd/bootparamd/bootparamd.c:204:32: error: 'fscanf' may
overflow; destination buffer in argument 3 has size 255, but the
corresponding specifier may require size 256 [-Werror,-Wfortify-source]
The MAX_MACHINE_NAME macro indicates the maximum number of bytes in a
machine name, but it does not include the NUL terminator required for
scanf.
MFC after: 3 days
(cherry picked from commit d310bf3867b4168e57365196c3a31797c0538097)
bootparamd: Add missing __unused mark.2021-01-02T15:40:34ZYoshihiro Takahashinyan@FreeBSD.org2021-01-02T15:40:34Zurn:sha1:8c45fe5d8ecda4be7564aadaa50712790c6c0a6f
e03764d931d820185a019334259b18df2e3f6b6c did not catch all unused
variables.
Submitted by: otis
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D27894
bootparamd: Fix several warnings and increase warn level to 6.2021-01-02T03:36:09ZYoshihiro Takahashinyan@FreeBSD.org2021-01-02T03:36:09Zurn:sha1:e03764d931d820185a019334259b18df2e3f6b6c
- Increase WARNS to 6.
- Except -Wcast-align and -Wincompatible-pointer-types-discards-qualifiers
checks.
- Use ANSI C prototype.
- Statically variables and functions.
- Add extern declaration for global variables.
- Rename local variables to resolve shadow warnings.
PR: 71667
MFC after: 2 weeks
DIRDEPS_BUILD: Update dependencies.2017-10-31T00:07:04ZBryan Drewerybdrewery@FreeBSD.org2017-10-31T00:07:04Zurn:sha1:ea825d02749f382c3f7e17f28247f20a48733eab
Sponsored by: Dell EMC Isilon
Don't leak bpf on early return when YP isn't defined (NIS support)2017-08-17T20:41:28ZEnji Cooperngie@FreeBSD.org2017-08-17T20:41:28Zurn:sha1:c78c36cd9c6af40b97241a455bd3022708b30095
MFC after: 1 week
Reported by: cppcheck
Fix WARNS2017-08-17T20:37:01ZEnji Cooperngie@FreeBSD.org2017-08-17T20:37:01Zurn:sha1:c354522292c3f8ce80fbffd71d5c71a3b59a2946
- Remove ad hoc inet_ntoa prototype declaration; it's already handled
by the included headers.
- De-K&Rify the function prototypes for eachres_whoami(..),
eachres_getfile(..), and main(..).
MFC after: 1 week
PR: 71667
Tested with: clang (5.0), gcc (4.2.1, 5)
Utilize SYSROOT from r320119 in places where DESTDIR may be wanting WORLDTMP.2017-06-19T20:47:24ZBryan Drewerybdrewery@FreeBSD.org2017-06-19T20:47:24Zurn:sha1:c99b67a7947ea215f9c1d44ec022680e98920cd1
Since buildenv exports SYSROOT all of these uses will now look in
WORLDTMP by default.
sys/boot/efi/loader/Makefile
A LIBSTAND hack is no longer required for buildenv.
MFC after: 2 weeks
Sponsored by: Dell EMC Isilon
Fix uninitialized variable in bootparamd.c2017-05-31T14:53:50ZAlan Somersasomers@FreeBSD.org2017-05-31T14:53:50Zurn:sha1:43a251d687a16a671f578ad3edfd73879e27e23b
Restore line that was accidentally deleted in change 318790
Reported by: Coverity
CID: 1375855
MFC after: 1 week
X-MFC-With: 318790
Sponsored by: Spectra Logic Corp
Fix a buffer overflow in bootparamd(8)2017-05-24T16:30:38ZAlan Somersasomers@FreeBSD.org2017-05-24T16:30:38Zurn:sha1:6e3c30637d46e0684447084f152a849f8e7acc6b
If /etc/bootparams contains a line with an excessively long pathname, and a
client asks for that path, then bootparamd will overflow a buffer and crash
while parsing that line. This is not remotely exploitable since it requires
a malformed /etc/bootparams file.
Reported by: Coverity
CID: 1305954
MFC after: 1 week
Sponsored by: Spectra Logic Corp
DIRDEPS_BUILD: Regenerate without local dependencies.2016-02-24T17:20:11ZBryan Drewerybdrewery@FreeBSD.org2016-02-24T17:20:11Zurn:sha1:bd18fd57db1df29da1a3adf94d47924a977a29c2
These are no longer needed after the recent 'beforebuild: depend' changes
and hooking DIRDEPS_BUILD into a subset of FAST_DEPEND which supports
skipping 'make depend'.
Sponsored by: EMC / Isilon Storage Division