src/usr.sbin/bsnmpd, branch stable/13

bsnmpd: avoid warnings about too-long initializer strings

2025-12-29T12:21:20Z

Mark `UTC` as `__non_string`, to avoid a warning from clang 21 similar to: usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptc.c:339:29: error: initializer-string for character array is too long, array size is 3 but initializer has size 4 (including the null terminating character); did you mean to use the 'nonstring' attribute? [-Werror,-Wunterminated-string-initialization] --- all_subdir_usr.sbin --- 339 | static const char UTC[3] = "UTC"; | ^~~~~ MFC after: 3 days (cherry picked from commit 3054e22e4524df24908d7e9379681c1ccf829b93)

bsnmpd: Fix an error message

2025-08-08T19:46:32Z

MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D51678 (cherry picked from commit bf304a40cde836435a55e938865fc12ce81cf0fe)

snmp_pf: fix pfInterfacesIfRefsState

2025-04-03T05:57:30Z

pfInterfacesIfRefsState was described as 'Null', which upset bsnmpwalk's attempt to resolve OIDs to symbolic names: > bsnmpwalk: Error adding leaf pfInterfacesIfRefsState to list This was done back in d6d3f01e0a339, because we don't return this value any more. Return it to 'Unsigned32', which fixes things, even if we still don't actually return this value. While here update the ORGANIZATION to reflect current ownership. Reviewed by: philip MFC after: 2 weeks Event: Tokyo Hackathon 202503 Differential Revision: https://reviews.freebsd.org/D49413 (cherry picked from commit 712309a64512c7e4ebf0e10de8a5c59d5a185ae8)

libbsnmptools: avoid uninitialized snmptoolctx->passwd with empty password

2025-01-20T14:28:54Z

The removed check left snmptoolctx->passwd pointer to uninitialized memory. Always calling strlcpy(3) would guarantee that with empty password it will point to empty string. Submitted by: markj PR: 283909 (cherry picked from commit 3999a860d6e899de98b1025317d2d0ef1f83255f) (cherry picked from commit 0bfbd30663b68a851ebf24667d121c6891c86827)

bsnmpwalk: Fix crash on invalid data

2025-01-12T19:32:38Z

PR: 258570 Reported by: Robert Morris Reviewed by: emaste, markj Differential Revision: https://reviews.freebsd.org/D48422 (cherry picked from commit f021e3573519ff192fc708cda9ca4bba264c96f7) (cherry picked from commit 7fbbab2d326bcbfa1592c6104b745cd5973f5aaa)

snmp_wlan: Fix a couple of type mismatches in function prototypes

2024-11-30T18:57:59Z

Reported by: GCC 13 via -Wenum-int-mismatch Reviewed by: imp, emaste Differential Revision: https://reviews.freebsd.org/D42582 (cherry picked from commit cc61bf9eccd46592704f3e7bc189c94ccae8f524)

MFC: unbreak BEGEMOT-LM75-MIB.txt

2023-09-14T11:58:23Z

The MIB has several bugs making it unusable. Fix it. Reported-by: Eugene M. Zheganin (cherry picked from commit 872e89405684eac984e9004bdfeeb540e818ed74)

snmp_pf: use libpfctl's pfctl_get_status() rather than DIOCGETSTATUS

2023-09-07T19:23:07Z

Prefer libpfctl functions over direct access to the ioctl whenever possible. This will allow subsequent removal of DIOCGETSTATUS (in 15) as there already is an nvlist-based alternative. MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D41650 (cherry picked from commit 6fbb9fbf7d659574512d706912e8fd0576b13573)

Remove $FreeBSD$: two-line lua tag

2023-08-23T17:43:33Z

Remove /^--\n--\s*\$FreeBSD\$.*$\n/ Similar commit in main: (cherry picked from commit 9636a14538f5)

Remove $FreeBSD$: two-line nroff pattern

2023-08-23T17:43:31Z

Remove /^\.\\"\n\.\\"\s*\$FreeBSD\$$\n/ Similar commit in main: (cherry picked from commit fa9896e082a1)