src/usr.sbin/memcontrol/memcontrol.c, branch stable/13

Remove $FreeBSD$: two-line .h pattern

2023-08-23T17:43:21Z

Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/ Similar commit in main: (cherry picked from commit b3e7694832e8)

spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSD

2023-07-25T15:13:49Z

The SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catch up to that fact and revert to their recommended match of BSD-2-Clause. Discussed with: pfg MFC After: 3 days Sponsored by: Netflix (cherry picked from commit 4d846d260e2b9a3d4d0a701462568268cbfe7a5b)

various: general adoption of SPDX licensing ID tags.

2017-11-27T15:37:16Z

Mainly focus on files that use BSD 2-Clause license, however the tool I was using misidentified many licenses so this was mostly a manual - error prone - task. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts. No functional change intended.

Fix conditional expression: previously a bit vector was being operated

2012-10-22T02:12:15Z

on by a logical not instead of the entire expression. Approved by: cperciva MFC after: 3 days

Mark global functions and/or variables in memcontrol(8) static where possible.

2011-11-06T19:01:59Z

This allows compilers and static analyzers to do more thorough analysis.

Correct formatting of pointers in the listing by using "0x%" PRIx64 instead of

2005-03-29T20:17:47Z

"%" PRIu64 "x".

WARNS=6 cleanup. This includes:

2005-01-07T12:06:30Z

- Apply __unused on unused parameters - Use const where suitable - Use PRIu64 instead of the deprecated %q - Bump WARNS to 6

Some BIOSs are using MTRR values that are only documented under NDA

2002-09-15T15:07:55Z

to control the mapping of things like the ACPI and APM into memory. The problem is that starting X changes these values, so if something was using the bits of BIOS mapped into memory (say ACPI or APM), then next time they access this memory the machine would hang. This patch refuse to change MTRR values it doesn't understand, unless a new "force" option is given. This means X doesn't change them by accident but someone can override that if they really want to. PR: 28418 Tested by: Christopher Masto , David Bushong , Santos MFC after: 1 week

Make the MTRR code a bit more defensive - this should help people

2002-04-14T20:19:13Z

trying to run X on some Athlon systems where the BIOS does odd things (mines an ASUS A7A266, but it seems to also help on other systems). Here's a description of the problem and my fix: The problem with the old MTRR code is that it only expects to find documented values in the bytes of MTRR registers. To convert the MTRR byte into a FreeBSD "Memory Range Type" (mrt) it uses the byte value and looks it up in an array. If the value is not in range then the mrt value ends up containing random junk. This isn't an immediate problem. The mrt value is only used later when rewriting the MTRR registers. When we finally go to write a value back again, the function i686_mtrrtype() searches for the junk value and returns -1 when it fails to find it. This is converted to a byte (0xff) and written back to the register, causing a GPF as 0xff is an illegal value for a MTRR byte. To work around this problem I've added a new mrt flag MDF_UNKNOWN. We set this when we read a MTRR byte which we do not understand. If we try to convert a MDF_UNKNOWN back into a MTRR value, then the new function, i686_mrt2mtrr, just returns the old value of the MTRR byte. This leaves the memory range type unchanged. I have seen one side effect of the fix, which is that ACPI calls after X has been run seem to hang my machine. As running X would previously panic the machine, this is still an improvement ;-) I'd like to MFC this before the 4.6 code freeze - please let me know if it causes any problems. PR: 28418, 25958 Tested by: jkh, Christopher Masto MFC after: 2 weeks

Nuke unused variables.

2001-06-24T23:41:57Z