src/usr.sbin/nfsuserd, branch mainFreeBSD source treehttps://cgit-dev.freebsd.org/src/atom?h=main2025-10-09T17:06:57Znfsuserd: Fix OOB access on membership of too many groups, take 22025-10-09T17:06:57ZOlivier Certnerolce@FreeBSD.org2025-10-09T17:03:11Zurn:sha1:75eb6846269bb9bec1eaf4f0ad93d7525715b550
Forgot to reset 'ngroup' after one of the calls to getgrouplist() in the
previous commit with same title (referenced also below).
MFC after: 1 hour
Fixes: e6c623c86ab4 ("Add support for the "-manage-gids" option to the nfsuserd daemon.")
Fixes: bb339adfb2a2 ("nfsuserd: Fix OOB access on membership of too many groups")
Sponsored by: The FreeBSD Foundation
nfsuserd: Fix OOB access on membership of too many groups2025-10-09T11:34:23ZOlivier Certnerolce@FreeBSD.org2025-10-09T09:19:37Zurn:sha1:bb339adfb2a26c5bb71cd4275dff80f615534ab6
getgrouplist() sets the variable containing the allocated length in
input to the full effective group list length, not the number of slots
that were actually filled in case the passed array is too small to
contain it.
While here, on this condition, improve the error message by outputting
the corresponding user name.
MFC after: 1 hour
Fixes: e6c623c86ab4 ("Add support for the "-manage-gids" option to the nfsuserd daemon.")
Sponsored by: The FreeBSD Foundation
Remove residual blank line at start of Makefile2024-07-15T22:43:39ZWarner Loshimp@FreeBSD.org2024-07-15T04:46:32Zurn:sha1:e9ac41698b2f322d55ccf9da50a3596edb2c1800
This is a residual of the $FreeBSD$ removal.
MFC After: 3 days (though I'll just run the command on the branches)
Sponsored by: Netflix
usr.sbin: Automated cleanup of cdefs and other formatting2023-11-27T05:24:01ZWarner Loshimp@FreeBSD.org2023-11-24T20:12:57Zurn:sha1:4d65a7c6951cea0333f1a0c1b32c38489cdfa6c5
Apply the following automated changes to try to eliminate
no-longer-needed sys/cdefs.h includes as well as now-empty
blank lines in a row.
Remove /^#if.*\n#endif.*\n#include\s+<sys/cdefs.h>.*\n/
Remove /\n+#include\s+<sys/cdefs.h>.*\n+#if.*\n#endif.*\n+/
Remove /\n+#if.*\n#endif.*\n+/
Remove /^#if.*\n#endif.*\n/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/types.h>/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/param.h>/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/capsicum.h>/
Sponsored by: Netflix
Remove $FreeBSD$: two-line nroff pattern2023-08-16T17:55:10ZWarner Loshimp@FreeBSD.org2023-08-16T17:55:10Zurn:sha1:fa9896e082a1046ff4fbc75fcba4d18d1f2efc19
Remove /^\.\\"\n\.\\"\s*\$FreeBSD\$$\n/
Remove $FreeBSD$: one-line sh pattern2023-08-16T17:55:03ZWarner Loshimp@FreeBSD.org2023-08-16T17:55:03Zurn:sha1:d0b2dbfa0ecf2bbc9709efc5e20baf8e4b44bbbf
Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/
Remove $FreeBSD$: one-line .c pattern2023-08-16T17:54:42ZWarner Loshimp@FreeBSD.org2023-08-16T17:54:42Zurn:sha1:1d386b48a555f61cb7325543adbbb5c3f3407a66
Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
nfsuserd.8: Change machines to machine's2023-06-04T19:52:04ZRick Macklemrmacklem@FreeBSD.org2023-06-04T19:52:04Zurn:sha1:6fa30de4d3caf5be3fd4dd44bf73fda0fb7616c5
Change machines to machine's.
Suggested by: grahamperrin
Differential Revision: https://reviews.freebsd.org/D39877
nfsuserd.8: Substitute server for slave terminology2023-06-01T20:49:04ZRick Macklemrmacklem@FreeBSD.org2023-06-01T20:49:04Zurn:sha1:c21438cd14d3fafc77f2cc2d591c6fad962c37ea
Commit 33906122e1ff replaced the use of "slave" with "server"
for nfsuserd.c. This patch does the same for nfsuserd.8.
Discussed with: karels
Differential Revision: https://reviews.freebsd.org/D39877
nfsuserd: Improve failure message when running in a jail2023-05-29T20:38:07ZRick Macklemrmacklem@FreeBSD.org2023-05-29T20:38:07Zurn:sha1:a94018e2003b83c10e8fb814f7a8d47e2513da95
If a jail is not correctly configured to run nfsd(8)
in the jail, nfsuserd(8) cannot run.
This patch improves the failure message for this case.
MFC after: 2 weeks