src/usr.sbin/ngctl, branch mainFreeBSD source treehttps://cgit-dev.freebsd.org/src/atom?h=main2026-02-24T14:29:01Zngctl.8: fix incorrect synopsis2026-02-24T14:29:01ZDavid Markerdave@freedave.net2026-02-24T14:27:52Zurn:sha1:9ed56cd8d6929e3ee733e1e61d2e0c6b81122983
Tiny manpage bug I caused in D50241
I left a line in the manpage that shouldn't be there.
MFC after: 3 days
Fixes: 72d01e62b082 ("netgraph: teach ngctl to attach and run itself in a jail")
Reviewed by: des, markj
Differential Revision: https://reviews.freebsd.org/D55485
ngctl: Fix getline loop2026-02-24T14:25:57ZDag-Erling Smørgravdes@FreeBSD.org2026-02-24T14:23:39Zurn:sha1:6c4777c59325c2cfefcce0c466b3bf475404a550
I misremembered when I wrote this code: getline() returns -1 on EOF, not
zero, so the loop condition and the error check are both incorrect
(though in practice getline() will never return 0).
MFC after: 3 days
Fixes: 3cbdcabf714d ("ngctl: Modernize code somewhat")
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D55487
ngctl: Fix buffer overflow in config command2026-02-13T15:57:58ZDag-Erling Smørgravdes@FreeBSD.org2026-02-13T15:57:50Zurn:sha1:59906a163e474c8d00bdebe226c4d47332b91bad
Keep track of our buffer length when assembling the argument list.
PR: 293075
MFC after: 1 week
Reviewed by: zlei, markj
Differential Revision: https://reviews.freebsd.org/D55259
ngctl: Check hook name length2026-02-13T15:57:58ZDag-Erling Smørgravdes@FreeBSD.org2026-02-13T15:57:46Zurn:sha1:585190dff436eeea3be97300e36c82559028d3dd
Check the length of the hook name when copying it into the sockaddr.
MFC after: 1 week
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D55258
ngctl: Modernize code somewhat2026-02-13T15:57:58ZDag-Erling Smørgravdes@FreeBSD.org2026-02-13T15:57:40Zurn:sha1:3cbdcabf714d5187e22d8ff1cbfbc261dc8622eb
* Replace fgets(3) with getline(3)
* Replace select(2) with poll(2)
* Avoid needlessly copying text around
* Correct use of getopt(3)
* Pick some style and whitespace nits
MFC after: 1 week
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D55257
ngctl: Fix build without JAIL2025-09-10T04:00:05ZZhenlei Huangzlei@FreeBSD.org2025-09-10T04:00:05Zurn:sha1:685e60e860d61f6e1bcf981f5c30647e0c025702
Reported by: Michael Dexter
Fixes: 72d01e62b082 netgraph: teach ngctl to attach and run itself in a jail
MFC after: 1 day
netgraph: teach ngctl to attach and run itself in a jail2025-08-29T23:02:14ZJamie Grittonjamie@FreeBSD.org2025-08-29T23:02:14Zurn:sha1:72d01e62b082de39ecf1ff3ced67dcf7259e5084
Add -j <jail> flag to ngctl to allow ngctl to attach and run inside
a jail. This allow parent to manipulate netgraph nodes in the jail
even if ngctl is not available.
Submitted by: David Marker <dave_freedave.net>
Reviewed by: kevans, zlei, jamie
Relnotes: yes
Differential Revision: https://reviews.freebsd.org/D50241
usr.sbin: Automated cleanup of cdefs and other formatting2023-11-27T05:24:01ZWarner Loshimp@FreeBSD.org2023-11-24T20:12:57Zurn:sha1:4d65a7c6951cea0333f1a0c1b32c38489cdfa6c5
Apply the following automated changes to try to eliminate
no-longer-needed sys/cdefs.h includes as well as now-empty
blank lines in a row.
Remove /^#if.*\n#endif.*\n#include\s+<sys/cdefs.h>.*\n/
Remove /\n+#include\s+<sys/cdefs.h>.*\n+#if.*\n#endif.*\n+/
Remove /\n+#if.*\n#endif.*\n+/
Remove /^#if.*\n#endif.*\n/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/types.h>/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/param.h>/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/capsicum.h>/
Sponsored by: Netflix
Remove $FreeBSD$: two-line nroff pattern2023-08-16T17:55:10ZWarner Loshimp@FreeBSD.org2023-08-16T17:55:10Zurn:sha1:fa9896e082a1046ff4fbc75fcba4d18d1f2efc19
Remove /^\.\\"\n\.\\"\s*\$FreeBSD\$$\n/
Remove $FreeBSD$: one-line sh pattern2023-08-16T17:55:03ZWarner Loshimp@FreeBSD.org2023-08-16T17:55:03Zurn:sha1:d0b2dbfa0ecf2bbc9709efc5e20baf8e4b44bbbf
Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/