diff options
| author | Joseph Mingrone <jrm@FreeBSD.org> | 2024-09-06 02:11:27 +0000 |
|---|---|---|
| committer | Joseph Mingrone <jrm@FreeBSD.org> | 2024-09-06 02:36:15 +0000 |
| commit | 75d9de99aec2d9f3bdc495c91bbd6d7a2392e2a3 (patch) | |
| tree | 99d6c086833d530e5d1d33a8128961f8149843f0 /print-openflow-1.3.c | |
| parent | 51a183021fce3928d24b11c319d2787f5a15ae87 (diff) | |
Diffstat (limited to 'print-openflow-1.3.c')
| -rw-r--r-- | print-openflow-1.3.c | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/print-openflow-1.3.c b/print-openflow-1.3.c index 9e76ba1b2935..935e573909f0 100644 --- a/print-openflow-1.3.c +++ b/print-openflow-1.3.c @@ -33,9 +33,7 @@ /* \summary: OpenFlow protocol version 1.3 printer */ -#ifdef HAVE_CONFIG_H #include <config.h> -#endif #include "netdissect-stdinc.h" @@ -676,7 +674,7 @@ of13_port_print(netdissect_options *ndo, cp += 4; /* state */ ND_PRINT("\n\t state 0x%08x", GET_BE_U_4(cp)); - of_bitmap_print(ndo, ofpps_bm, GET_BE_U_4(cp), OFPPS_U);; + of_bitmap_print(ndo, ofpps_bm, GET_BE_U_4(cp), OFPPS_U); cp += 4; /* curr */ ND_PRINT("\n\t curr 0x%08x", GET_BE_U_4(cp)); @@ -856,21 +854,20 @@ of13_hello_elements_print(netdissect_options *ndo, while (len) { uint16_t type, bmlen; - if (len < OF_HELLO_ELEM_MINSIZE) - goto invalid; + ND_PRINT("\n\t"); + ND_ICHECKMSG_U("remaining length", len, <, OF_HELLO_ELEM_MINSIZE); /* type */ type = GET_BE_U_2(cp); OF_FWD(2); - ND_PRINT("\n\t type %s", + ND_PRINT(" type %s", tok2str(ofphet_str, "unknown (0x%04x)", type)); /* length */ bmlen = GET_BE_U_2(cp); OF_FWD(2); ND_PRINT(", length %u", bmlen); /* cp is OF_HELLO_ELEM_MINSIZE bytes in */ - if (bmlen < OF_HELLO_ELEM_MINSIZE || - bmlen > OF_HELLO_ELEM_MINSIZE + len) - goto invalid; + ND_ICHECKMSG_U("bitmap length", bmlen, <, OF_HELLO_ELEM_MINSIZE); + ND_ICHECKMSG_U("bitmap length", bmlen, >, OF_HELLO_ELEM_MINSIZE + len); switch (type) { case OFPHET_VERSIONBITMAP: /* |