aboutsummaryrefslogtreecommitdiff
path: root/ssl
diff options
context:
space:
mode:
authorSimon L. B. Nielsen <simon@FreeBSD.org>2010-12-02 22:36:51 +0000
committerSimon L. B. Nielsen <simon@FreeBSD.org>2010-12-02 22:36:51 +0000
commitfd3744ddb062b70bb370acec340acbac23f0bd98 (patch)
treeb5613f06a47ca8522264b520b04a27a5fa0ff300 /ssl
parentf2c43d19b91f8847c1dfd87721254b44f963d9a2 (diff)
downloadsrc-fd3744ddb062b70bb370acec340acbac23f0bd98.tar.gz
src-fd3744ddb062b70bb370acec340acbac23f0bd98.zip
Notes
Diffstat (limited to 'ssl')
-rw-r--r--ssl/s3_clnt.c3
-rw-r--r--ssl/s3_srvr.c5
2 files changed, 8 insertions, 0 deletions
diff --git a/ssl/s3_clnt.c b/ssl/s3_clnt.c
index f0995b96acea..a7cb7a1ebf30 100644
--- a/ssl/s3_clnt.c
+++ b/ssl/s3_clnt.c
@@ -814,8 +814,11 @@ int ssl3_get_server_hello(SSL *s)
s->session->cipher_id = s->session->cipher->id;
if (s->hit && (s->session->cipher_id != c->id))
{
+/* Workaround is now obsolete */
+#if 0
if (!(s->options &
SSL_OP_NETSCAPE_REUSE_CIPHER_CHANGE_BUG))
+#endif
{
al=SSL_AD_ILLEGAL_PARAMETER;
SSLerr(SSL_F_SSL3_GET_SERVER_HELLO,SSL_R_OLD_SESSION_CIPHER_NOT_RETURNED);
diff --git a/ssl/s3_srvr.c b/ssl/s3_srvr.c
index e696450d6569..e2d570f80f0a 100644
--- a/ssl/s3_srvr.c
+++ b/ssl/s3_srvr.c
@@ -927,6 +927,10 @@ int ssl3_get_client_hello(SSL *s)
break;
}
}
+/* Disabled because it can be used in a ciphersuite downgrade
+ * attack: CVE-2010-4180.
+ */
+#if 0
if (j == 0 && (s->options & SSL_OP_NETSCAPE_REUSE_CIPHER_CHANGE_BUG) && (sk_SSL_CIPHER_num(ciphers) == 1))
{
/* Special case as client bug workaround: the previously used cipher may
@@ -941,6 +945,7 @@ int ssl3_get_client_hello(SSL *s)
j = 1;
}
}
+#endif
if (j == 0)
{
/* we need to have the cipher in the cipher