diff options
| author | Mark Johnston <markj@FreeBSD.org> | 2020-08-03 23:06:33 +0000 |
|---|---|---|
| committer | Mark Johnston <markj@FreeBSD.org> | 2020-08-03 23:06:33 +0000 |
| commit | 9c4a78a41a2cdce7b1a749ad9a295a8953faa9ab (patch) | |
| tree | 74ef3b6da5620ce285418cc39411dad16cbb0ee9 /sys/dev/mps | |
| parent | c35d37cef9d7b490dedff216755461cdb3741de5 (diff) | |
Notes
Diffstat (limited to 'sys/dev/mps')
| -rw-r--r-- | sys/dev/mps/mps.c | 8 | ||||
| -rw-r--r-- | sys/dev/mps/mps_sas.c | 15 | ||||
| -rw-r--r-- | sys/dev/mps/mps_user.c | 7 |
3 files changed, 0 insertions, 30 deletions
diff --git a/sys/dev/mps/mps.c b/sys/dev/mps/mps.c index 046beda137fc..2e2fd9641c77 100644 --- a/sys/dev/mps/mps.c +++ b/sys/dev/mps/mps.c @@ -1513,10 +1513,6 @@ mps_alloc_requests(struct mps_softc *sc) */ sc->commands = malloc(sizeof(struct mps_command) * sc->num_reqs, M_MPT2, M_WAITOK | M_ZERO); - if(!sc->commands) { - mps_dprint(sc, MPS_ERROR, "Cannot allocate command memory\n"); - return (ENOMEM); - } for (i = 1; i < sc->num_reqs; i++) { cm = &sc->commands[i]; cm->cm_req = sc->req_frames + i * sc->reqframesz; @@ -2584,10 +2580,6 @@ mps_register_events(struct mps_softc *sc, u32 *mask, int error = 0; eh = malloc(sizeof(struct mps_event_handle), M_MPT2, M_WAITOK|M_ZERO); - if(!eh) { - mps_dprint(sc, MPS_ERROR, "Cannot allocate event memory\n"); - return (ENOMEM); - } eh->callback = cb; eh->data = data; TAILQ_INSERT_TAIL(&sc->event_list, eh, eh_list); diff --git a/sys/dev/mps/mps_sas.c b/sys/dev/mps/mps_sas.c index 90294daed112..e2c13ce2aea7 100644 --- a/sys/dev/mps/mps_sas.c +++ b/sys/dev/mps/mps_sas.c @@ -738,11 +738,6 @@ mps_attach_sas(struct mps_softc *sc) mps_dprint(sc, MPS_INIT, "%s entered\n", __func__); sassc = malloc(sizeof(struct mpssas_softc), M_MPT2, M_WAITOK|M_ZERO); - if(!sassc) { - mps_dprint(sc, MPS_INIT|MPS_ERROR, - "Cannot allocate SAS controller memory\n"); - return (ENOMEM); - } /* * XXX MaxTargets could change during a reinit. Since we don't @@ -753,12 +748,6 @@ mps_attach_sas(struct mps_softc *sc) sassc->maxtargets = sc->facts->MaxTargets + sc->facts->MaxVolumes; sassc->targets = malloc(sizeof(struct mpssas_target) * sassc->maxtargets, M_MPT2, M_WAITOK|M_ZERO); - if(!sassc->targets) { - mps_dprint(sc, MPS_INIT|MPS_ERROR, - "Cannot allocate SAS target memory\n"); - free(sassc, M_MPT2); - return (ENOMEM); - } sc->sassc = sassc; sassc->sc = sc; @@ -3671,8 +3660,4 @@ mpssas_realloc_targets(struct mps_softc *sc, int maxtargets) sassc->targets = malloc(sizeof(struct mpssas_target) * maxtargets, M_MPT2, M_WAITOK|M_ZERO); - if (!sassc->targets) { - panic("%s failed to alloc targets with error %d\n", - __func__, ENOMEM); - } } diff --git a/sys/dev/mps/mps_user.c b/sys/dev/mps/mps_user.c index 0a2506070849..15ae463a1ad1 100644 --- a/sys/dev/mps/mps_user.c +++ b/sys/dev/mps/mps_user.c @@ -1436,13 +1436,6 @@ mps_diag_register(struct mps_softc *sc, mps_fw_diag_register_t *diag_register, bzero(sc->fw_diag_buffer, buffer_size); ctx = malloc(sizeof(*ctx), M_MPSUSER, M_WAITOK | M_ZERO); - if (ctx == NULL) { - device_printf(sc->mps_dev, "%s: context malloc failed\n", - __func__); - *return_code = MPS_FW_DIAG_ERROR_NO_BUFFER; - status = MPS_DIAG_FAILURE; - goto bailout; - } ctx->addr = &sc->fw_diag_busaddr; ctx->buffer_dmat = sc->fw_diag_dmat; ctx->buffer_dmamap = sc->fw_diag_map; |
