| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
| |
Discussed with: erwin, brooks, bapt
Notes:
svn path=/head/; revision=222035
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Rework the wrapper support to check libpkg version as well as pkg_install
version.
- Add libfetch to _prebuild_libs.
- There are no new features introduced.
Notes: the API is not stable, so basically, do not use libpkg in your
projects for now. Also there's no manpage for libpkg yet, because the API
will change drastically. I repeat, do not use libpkg for now.
Notes:
svn path=/head/; revision=207113
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
either COMMENT or DESCR from the command line. When a port is
installed, one gets both +COMMENT and +DESCR files with a trailing
'\n' character. However, +COMMENT does not contain a trailing '\n'
when it is installed from a package due to this behavior of pkg_create.
Therefore, make sure it behaves exactly the same regardless of
where got its information; either command line or files. The modified
functions are used by pkg_create.
PR: 52097
Reviewed by: bento, kris,
portmgr, re,
Michael Nottebrock <michaelnottebrock@gmx.net>,
Martin Horcicka <horcicka@FreeBSD.cz>
Approved by: re (scottl)
MFC after: 1 week
Notes:
svn path=/head/; revision=115325
|
| |
|
|
| |
Notes:
svn path=/head/; revision=93520
|
| |
|
|
|
|
|
|
| |
Tested on: i386, alpha
MFC after: 2 weeks
Notes:
svn path=/head/; revision=84745
|
| |
|
|
|
|
|
| |
Approved by: jkh
Notes:
svn path=/head/; revision=81571
|
| |
|
|
| |
Notes:
svn path=/head/; revision=80472
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When reading the code I had to stop, say "ok, what does *these*
modifications of strl*() do? Pull out grep. Oh, not in add/, maybe above
in ../lib/? Yep. So what do they do? Comments above them are misleading,
guess I'll have to read the code. Oh, they just test strl* against the
size and return the result of the test. Now I can continue to read the
code I was.
The uses of s_strl*() then test that result and errx()'s.
Lets think about the "optimized" code I am removing:
In general the compiler pushes the three args to strl* onto the stack and calls
s_strl*. s_strl* has to indirectly access 3 args from the stack. Then push
them on the stack a 2nd time for the real strl* call. s_strl* then pops the
return from strl* off the stack; or moves it from the register it was returned
in, to the register where tests can happen. s_strl* then pops the three
arguments to strl*. Perform the test, push the result of the test, or move it
from the result register to the return value register. The caller to s_strl*
now has to either pop the return value of s_strl* or move it from the return
value register to the test register. The caller then pops the three args to
s_strl* off the stack (the same args that s_strl* itself had to pop off after
the real call to strl*). The s_strl* caller then performs a simular test to
what has already been done, and conditionally jumps. By doing things this way, we've given the compiler optimizer less to work with.
Also, please don't forget the that call to s_strl* has possibly jumped to code
not in the cache due to being far away from the calling code, thus causing a
pipeline stall.
So where is the "optimization" from s_strl*?
It isn't code clarity.
It isn't code execution speed. It isn't code size either.
Notes:
svn path=/head/; revision=80463
|
| |
|
|
|
|
|
|
|
|
|
| |
warnx()+exit() with errx() and replace a big if..then..else construct
to determine the package download directory with a lookup table.
Reviewed by: jkh
MFC after: 2 weeks
Notes:
svn path=/head/; revision=76504
|
| |
|
|
|
|
|
|
|
|
|
|
| |
- fix a harmless bug in match_installed() function introduced in my last
commit;
- uniformely reorder includes across files.
Submitted by: Garrett Rooney <rooneg@electricjellyfish.net>
Not objected by: jkh, -ports
Notes:
svn path=/head/; revision=74699
|
| |
|
|
|
|
|
|
|
|
|
|
| |
concerning where they're taking place.
Switch from [r]index() to str[r]chr() functions, which are more ISO
compliant.
Prompted by: Edward Welbourne <eddy@vortigen.demon.co.uk>
Notes:
svn path=/head/; revision=67429
|
| |
|
|
| |
Notes:
svn path=/head/; revision=50479
|
| |
|
|
| |
Notes:
svn path=/head/; revision=30221
|
| |
|
|
| |
Notes:
svn path=/head/; revision=11780
|
| |
|
|
| |
Notes:
svn path=/head/; revision=8087
|
| |
|
|
| |
Notes:
svn path=/head/; revision=4546
|
|
|
for info.
Notes:
svn path=/cvs2svn/branches/unlabeled-1.1.1/; revision=327
|
