| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Improve mfi_pd_inq_string() by
* Reusing buffer sizes from cam/cam.h according to SCSI specification + NULL byte
* Don't truncate vendor-specific information by escaping into a too small buffer
* Use cam_strvis() from libcam instead of old, outdated local copy
* Recaculate size of inq_string based on the reused buffer sizes and
format statements
PR: 294354
Reviewed by: imp
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D56328
(cherry picked from commit 850eb149e7ab0733fcf9469a607dca223ff467ad)
|
| |
|
|
|
|
|
|
|
|
|
| |
This is the small internal doc fix from https://reviews.freebsd.org/D46313
Reviewed by: michaelo
Approved by: (blanket; comment fix)
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D55325
(cherry picked from commit e9a69948a8837601d71e556550a272ca85c03e48)
|
| |
|
|
|
|
|
|
|
|
|
| |
Both (U)EFI and BIOS are completely different things, be precise and don't use
them together.
Reviewed by: imp
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D56329
(cherry picked from commit 4f684e929de1275b1099b17b2a2cff0d3f4af223)
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Normally, syslogd reacts only to SIGTERM, and ignores SIGINT and SIGQUIT
unless in debug mode. Extend that to also apply when running in the
foreground.
MFC after: 1 week
Reviewed by: jfree
Differential Revision: https://reviews.freebsd.org/D55886
(cherry picked from commit 828de702ada854b5f09f447ba06e4e08e976ba07)
|
| |
|
|
|
|
|
|
|
|
|
| |
MFC after: 3 days
Fixes: 6378393308bc ("Add an internal libiscsiutil library.")
Sponsored by: Klara, Inc.
Sponsored by: NetApp, Inc.
Reviewed by: kevans
Differential Revision: https://reviews.freebsd.org/D55596
(cherry picked from commit 05ca4837a3e9a413aabcf005abb14fff35088476)
|
| |
|
|
|
|
|
|
|
|
|
| |
Set a 120-second receive timeout on all client connections, and add a
command-line option to change that value.
MFC after: 1 week
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D55400
(cherry picked from commit 56fbfd1ecdc78fc99b3a2e381c355ce8980de39d)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Check for integer overflow when receiving file sizes.
* Check for buffer overflow when receiving file names, and fully
validate the names.
* Check for integer overflow when checking for available disk space.
* Check for I/O errors when sending status codes.
* Enforce one job per connection and one control file per job (see
code comments for additional details).
* Simplify readfile(), avoiding constructs vulnerable to integer
overflow.
* Don't delete files we didn't create.
* Rename read_number() to read_minfree() since that's all it's used
for, and move all the minfree logic into it.
* Fix a few style issues.
PR: 293278
MFC after: 1 week
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D55399
(cherry picked from commit 9065be0a5902e058d25a42bd9b3fbe9dc28b189d)
|
| |
|
|
|
|
|
| |
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/654
(cherry picked from commit 365348f66a47df247b5289b8a86fb20b36d778c1)
|
| |
|
|
|
|
| |
Reported by: 0mp
(cherry picked from commit cebcca89f1b059438cc329bde4d8ad254a303623)
|
| |
|
|
| |
(cherry picked from commit 56b0f5f360b6039c6a696aa241aaa02a16ff6a0a)
|
| |
|
|
|
|
|
|
|
|
|
| |
This is necessary for use with supervision, e.g. runit.
I chose -F simply because that is what the folks at LPRng use.
Approved by: pfg, gad, ngie
Differential Revision: https://reviews.freebsd.org/D29566
(cherry picked from commit 3c6366067036d4573528309a0a4d3b52e2a76ae7)
|
| |
|
|
|
|
| |
MFC after: 3 days
(cherry picked from commit fac9ae3db4e6a28dfd467369e262f636e10a3b01)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"trim /dev/da*" would print the following line multiple times
when given multiple agruments:
dry run: add -f to actually perform the operation
Print it once before looping over arguments.
Also, note possible suffixes P and E after offset/length
as per expand_number(3).
(cherry picked from commit 5d5848648013a189fc766e4ee3a121362905b836)
(cherry picked from commit f1b934c8138cfd98a70e305d54b2b431c842ec21)
|
| |
|
|
| |
(cherry picked from commit 66797b469ee3e303c5e228bea1e244f433e666e1)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pw.8 structure is quite different from usual manual page, especially in
describing -o option usage. Specifically, these paragraphs do not
contain "uid/gid" terms, and have "user id"/"group id" instead,
making searching for "override duplicate safety belt" difficult.
Try to simplify such searches.
Also, clarify uid/gid space between 100 and 1000 as "somewhat special",
as it actually is.
Discussed on: russian telegram FreeBSD group
Reviewed by: eugen, novel
MFC after: 1 week
(cherry picked from commit e89454417b2bfecce9daee10dece2f49632640d3)
|
| |
|
|
|
|
|
|
|
|
|
| |
Keep track of our buffer length when assembling the argument list.
PR: 293075
MFC after: 1 week
Reviewed by: zlei, markj
Differential Revision: https://reviews.freebsd.org/D55259
(cherry picked from commit 59906a163e474c8d00bdebe226c4d47332b91bad)
|
| |
|
|
|
|
|
|
|
|
| |
Check the length of the hook name when copying it into the sockaddr.
MFC after: 1 week
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D55258
(cherry picked from commit 585190dff436eeea3be97300e36c82559028d3dd)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The daemon utility has always created its output file with a fixed mode
of 0600. This causes issues for log collection setups where the collector
does not run as root but instead relies on group access to the watched
daemon’s log file.
Introduce a new option that allows specifying the output file mode using
install(1)-style semantics. This enables non-root log collectors to access
the file as intended and improves compatibility with log rotation tools.
Reviewed by: kevans
MFC after: 1 week
Relnotes: yes
Differential Revision: https://reviews.freebsd.org/D54930
(cherry picked from commit a3b90a1f008365d9f62773998f89f9c872e2bed5)
|
| |
|
|
|
|
|
|
|
|
|
| |
This helps future developers when adding additional options handlers in the
surrounding blocks.
This is effectively a no-op.
MFC after: 1 month
(cherry picked from commit 0adec3d7ec96105c402ff2286e402ad63c845066)
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The wrong value passed to strncmp meant that only enable and disable were being
accepted. This change corrects the logic so enabled and disabled are also
accepted.
Pull Request: https://github.com/freebsd/freebsd-src/pull/739
MFC after: 1 week
Reviewed by: delphij, ngie
(cherry picked from commit 5a9c724847f9b4e3831aa2c16276cc2ae20a99cc)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is based on an initial implementation by michaelo in
https://reviews.freebsd.org/D54361.
PR: 270497
Reported by: michaelo
Reviewed by: michaelo
Tested by: michaelo
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D54606
(cherry picked from commit 8ac6427b1bb95470f6c755202d1c0391ed8eefbd)
|
| |
|
|
|
|
| |
MFC after: 1 week
(cherry picked from commit 73af599fb7be6806b553ac6f470d76711b74286c)
|
| |
|
|
|
|
|
| |
Reported by: wosch
Tested by: wosch
(cherry picked from commit 2804461adfc670c78c1dcb9cab6b2191c8d486ec)
|
| |
|
|
|
|
|
|
|
|
| |
Correct inconsistent spelling of terms and duplication.
Reviewed by: ziaee
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D54370
(cherry picked from commit 66604463e737f4754ae6268171031ceefc226837)
|
| |
|
|
|
|
|
|
|
|
| |
bhyve accepts any MAC address even foreign as long it is a unicast one.
Reviewed by: ziaee
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D54372
(cherry picked from commit e1bfd541c7cdee1e184cacb2ea3bbebb3a500dfb)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mark `UTC` as `__non_string`, to avoid a warning from clang 21 similar
to:
usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptc.c:339:29: error: initializer-string for character array is too long, array size is 3 but initializer has size 4 (including the null terminating character); did you mean to use the 'nonstring' attribute? [-Werror,-Wunterminated-string-initialization]
--- all_subdir_usr.sbin ---
339 | static const char UTC[3] = "UTC";
| ^~~~~
MFC after: 3 days
(cherry picked from commit 3054e22e4524df24908d7e9379681c1ccf829b93)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mark `direntry::deName` as `__non_string`, to avoid warnings from clang
21 similar to:
usr.sbin/makefs/msdos/msdosfs_vnops.c:512:4: error: initializer-string for character array is too long, array size is 11 but initializer has size 12 (including the null terminating character); did you mean to use the 'nonstring' attribute? [-Werror,-Wunterminated-string-initialization]
512 | { ". ", /* the . entry */
| ^~~~~~~~~~~~~
usr.sbin/makefs/msdos/msdosfs_vnops.c:522:4: error: initializer-string for character array is too long, array size is 11 but initializer has size 12 (including the null terminating character); did you mean to use the 'nonstring' attribute? [-Werror,-Wunterminated-string-initialization]
522 | { ".. ", /* the .. entry */
| ^~~~~~~~~~~~~
MFC after: 3 days
(cherry picked from commit ba0a11512237681fc621670023d56195cb8c82ad)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initialize `tbfl` and `tofl` to NULL, and check whether they are
non-NULL before calling remove(3) on them, to avoid warnings from clang
21 similar to:
usr.sbin/pmcannotate/pmcannotate.c:746:3: error: variable 'tbfl' is uninitialized when used here [-Werror,-Wuninitialized]
746 | FATAL(exec, "%s: Impossible to locate the binary file\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
747 | exec);
| ~~~~~
usr.sbin/pmcannotate/pmcannotate.c:57:9: note: expanded from macro 'FATAL'
57 | remove(tbfl); \
| ^~~~
usr.sbin/pmcannotate/pmcannotate.c:695:12: note: initialize the variable 'tbfl' to silence this warning
695 | char *tbfl, *tofl, *tmpdir;
| ^
| = NULL
usr.sbin/pmcannotate/pmcannotate.c:746:3: error: variable 'tofl' is uninitialized when used here [-Werror,-Wuninitialized]
746 | FATAL(exec, "%s: Impossible to locate the binary file\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
747 | exec);
| ~~~~~
usr.sbin/pmcannotate/pmcannotate.c:58:9: note: expanded from macro 'FATAL'
58 | remove(tofl); \
| ^~~~
usr.sbin/pmcannotate/pmcannotate.c:695:19: note: initialize the variable 'tofl' to silence this warning
695 | char *tbfl, *tofl, *tmpdir;
| ^
| = NULL
MFC after: 3 days
(cherry picked from commit cd880010c49a5d4ec529f4204d4e88cd27727255)
|
| |
|
|
|
|
|
|
|
|
| |
Correct inconsistent spelling of terms and duplication.
Reviewed by: ziaee
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D54332
(cherry picked from commit 5819f8b285fc55a75e5dea56ffe73b376525150c)
|
| |
|
|
|
|
|
|
|
| |
Reported by: Kevin Day <kevin@your.org>
Approved by: so
Security: FreeBSD-SA-25:12.rtsold
Security: CVE-2025-14558
(cherry picked from commit bf804f69dd94b3c98962618b4ad3b48a35bff2ff)
|
| |
|
|
|
|
|
|
| |
Further explain that trim(8) is not for trimming free blocks
in populated file systems/ZFS pools, as people still take it wrong sometimes.
(cherry picked from commit dbc4a1c69191909a7210cad6da46b755557d0d34)
(cherry picked from commit b2f8d46d898fb50222aefca47d687a852c647b2f)
|
| |
|
|
|
|
|
|
|
|
|
|
| |
These days most end users are likely using pre-built packages, not
locally-built ports. Thus be sure to mention this as an important case,
and put it ahead of ports.
Reviewed by: emaste
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D42968
(cherry picked from commit ced74610217ff0be071e4614c64a4ff66c40bc6b)
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This case is hit for the kernel itself on riscv64, and did not used to
be checked. Since the code here can already handle missing Elf_Rel
and/or Elf_Rela just delete the check.
Reviewed by: jhb, imp
Fixes: 0299afdff145 ("kldxref: Make use of libelf to be a portable cross tool")
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D46517
(cherry picked from commit 05996f453de2f2c7a03437a492d9d53831fccb2e)
|
| |
|
|
|
|
|
|
|
|
|
| |
`ul` reaches `__arraycount(services)` before the bound-check happens, causing undefined behaviour.
Reviewed by: imp, jrtc27
Fixes: 7718ced0ea98 ("Add btpand(8) daemon from NetBSD.")
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D45463
(cherry picked from commit fbfdf57d65bedfab28f9debc8a4a8d6802f9338a)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If cnt == 0 we access element 0 unconditionally, which is out of bounds,
and then if that doesn't crash and happens to be 0 we will access
element - 1, also out of bounds, and then if that doesn't crash will add
1 to whatever junk is there and use that for the variable. On CHERI,
though, this does crash. This code is also overly complicated, with
unnecessary special cases and tracking more state than needed.
Rewrite it in a more general manner that doesn't need those special
cases and naturally works for cnt == 0.
Found by: CHERI
Reviewed by: imp
Fixes: 1285bcc833a3 ("Import Netflix's efibootmgr to help manage UEFI boot variables")
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D44029
(cherry picked from commit 09cb8031b43c8e98abb5ff9b43ff649031d1e808)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This isn't inherently an error. It is if you're attempting to download
dist tarballs or later install packages, but a FreeBSD system with no
NIC is a reasonable setup to have, especially in a throwaway VM setting,
so we shouldn't say it is one.
Leaving the exit code as 1 is still fine, since auto will ignore it, and
avoids breaking other uses.
MFC after: 1 week
(cherry picked from commit 7414d14bd51d8378057bbe952c2715b9f32d1d3e)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The script uses [ -z "$INTERFACES" ] to check if the list of interfaces
is empty and will exit early if so, but INTERFACES always contains at
least a space due to the way it appends the list of wireless devices.
Fix this by only adding the space when there are devices to append,
mirroring the behaviour for non-wireless devices above (both will result
in a redundant leading space when the list is non-empty, but that one is
harmless).
Fixes: 159ca5c844cd ("Adapt to new wireless scheme where base wlan interfaces do not show up in ifconfig anymore.")
MFC after: 1 week
(cherry picked from commit b809c7d6a26924ac351e49a15011da718cc3feec)
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Use [[:space:]] rather than a white space character to delimit the keys
and the values in the resolv.conf file.
PR: 236079
Reviewed by: des
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D53811
(cherry picked from commit 0628400590e025b7db1c0905e6ee488a24ef3f60)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The existing parser was needlessly complicated and wildly inconsistent
in how it handled invalid input. Rewrite using getline() and treat
invalid input consistently: silently ignore lines that don't begin with
a number, and print a warning if the inode number is out of range.
PR: 290992
MFC after: 1 week
Reviewed by: obrien
Differential Revision: https://reviews.freebsd.org/D53726
(cherry picked from commit fa272a5276865a97b01823fe6546940eaaf1b164)
(cherry picked from commit 179fa1d81c73ab7ef231e17da73f230e4f8ee5a2)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To facilitate the task, we change the comparison function so that users
with equal filesystem usage are sorted by UID, and add an undocumented
option that prevents quot from replacing numerical UIDs with names. We
also switch from getfsfile(3) to getmntpoint(3) so the first line is
identical regardless of whether we pass quot a mountpoint or a device.
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D53133
(cherry picked from commit aa870a1935bccb66e02c4c31630706768a3e7d74)
(cherry picked from commit b5f3f1a661ab69986c3379fa4c9c2b38785933db)
(cherry picked from commit b41551753a2baff6646e2958acb4a7fcd205b69c)
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Without this setting, Unbound 1.24.0 and newer will attempt to set the
socket buffer size to 4 MB to mitigate issues that mostly affect servers
with large numbers of clients on local networks, which is not a scenario
local-unbound is intended for. This is not only a waste of resources,
it can also fail, resulting in a warning message on daemon startup.
Fixes: b2efd602aea8 ("unbound: Vendor import 1.24.0")
Reviewed by: jlduran, cy
Differential Revision: https://reviews.freebsd.org/D52977
(cherry picked from commit de3faa85d8f99d260cbfa6242dd8e4ece693e4f8)
|
| |
|
|
|
|
| |
- s/th/the/
(cherry picked from commit 2b2a4f02e0872065c63baec8bf0069e3b677def7)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If it encounters an inode whose owner does not have a pw entry, quot
allocates a 7-byte buffer (8 in practice, since that is the minimum
allocation size) and uses it to store the numeric uid preceded by a
hash character. This will overflow the allocated buffer if the UID
exceeds 6 decimal digits. Avoid this by using asprintf() instead.
While here, simplify the common case as well using strdup().
Reported by: Igor Gabriel Sousa e Souza <igor@bsdtrust.com>
MFC after: 3 days
Reviewed by: obiwac, emaste
Differential Revision: https://reviews.freebsd.org/D53129
(cherry picked from commit 5854d1cbab1073d78519e7ad9a6eb5726341d587)
|
| |
|
|
| |
(cherry picked from commit 5d8fde850768d31f722de6177204ec7cab199bd1)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is referred to in the documentation as the system crontab, not root's
crontab.
PR: 289099
Reviewed by: emaste
Approved by: emaste (mentor)
Fixes: d33daab9348a ("Call /etc/crontab the "system crontab", not "root's crontab". While here, fix some other wording issues")
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D52503
(cherry picked from commit c806defe8fee62c4738f46e555d69b085e8d1259)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Upgrading from 14.x to 15.x with freebsd-update broke because libc
depends on the new libsys library; freebsd-update installed the new
libc before creating libsys, and every step after that failed because
all the tools (including gunzip and install) are dynamically linked
and need a working libc.
Enforce ordering when installing shared objects: First libsys, then
libc, then libthr, and then all the rest of the shared object files.
This is a candidate for an Errata Notice since the issue this fixes
breaks upgrades.
PR: 289769
Reported by: Graham Perrin
Reviewed by: kib
MFC after: 3 days
Sponsored by: https://www.patreon.com/cperciva
Differential Revision: https://reviews.freebsd.org/D52688
(cherry picked from commit 7ece602e00e85195fc426a2401c49921cd39735e)
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
PR: 266374
Pull request: https://github.com/freebsd/freebsd-src/pull/1851
Reviewed by: emaste
Sponsored by: The FreeBSD Foundation
(cherry picked from commit 87a7b35f04b60956e9aa192680ae80773ec38f14)
(cherry picked from commit 093f3f26e95198bf1db082763e915d7a53c6ba82)
(cherry picked from commit 8f7dded412516d35e538ed05524d2a14870e62b0)
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
All datasets on zroot pool are compressed by default since FreeBSD 11.0 [1],
no need to mention that on some specific datasets these days.
[1] 47206692f2cca020891d1eec5028e02c3e6f56c5
Reviewed by: jrm (mentor), ziaee
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D52304
(cherry picked from commit f304c5bb8be65df83b86f8a50e1c7982b266262d)
|
| |
|
|
|
|
|
|
|
|
| |
Current leap-seconds file has already expired on 28 June 2025
PR: 289352
Obtained from: https://hpiers.obspm.fr/iers/bul/bulc/ntp/leap-seconds.3960835200
MFC after: 3 days
(cherry picked from commit 4729d5e2e2e3013fe1aaf92d5d932a3414f22ab3)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
The exports.5 man page is a bit of a monster.
One place of common confusion is the use of
the "V4:" line(s) for defining the location of the
root of the NFSv4 export subtree.
This patch adds a paragraph in an attempt to
clarify this.
This is a content change.
(cherry picked from commit 200730f29dbc8da2aa9392b35518bf77b8899f89)
|