From 3a0d1d886ae5e4f1dd859ead122e33fbb79d4970 Mon Sep 17 00:00:00 2001 From: Archie Cobbs Date: Mon, 8 Nov 1999 03:11:22 +0000 Subject: Fix crash when trying to duplicate a NULL meta. --- sys/netgraph/ng_tee.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/sys/netgraph/ng_tee.c b/sys/netgraph/ng_tee.c index 8874e49e2a68..7ae417c88834 100644 --- a/sys/netgraph/ng_tee.c +++ b/sys/netgraph/ng_tee.c @@ -266,15 +266,18 @@ ngt_rcvdata(hook_p hook, struct mbuf *m, meta_p meta) } /* Copy meta info */ - MALLOC(meta2, meta_p, - meta->used_len, M_NETGRAPH, M_NOWAIT); - if (meta2 == NULL) { - m_freem(m2); - NG_FREE_DATA(m, meta); - return (ENOMEM); - } - meta2->allocated_len = meta->used_len; - bcopy(meta, meta2, meta->used_len); + if (meta != NULL) { + MALLOC(meta2, meta_p, + meta->used_len, M_NETGRAPH, M_NOWAIT); + if (meta2 == NULL) { + m_freem(m2); + NG_FREE_DATA(m, meta); + return (ENOMEM); + } + bcopy(meta, meta2, meta->used_len); + meta2->allocated_len = meta->used_len; + } else + meta2 = NULL; /* Deliver duplicate */ dup->stats.outOctets += m->m_pkthdr.len; -- cgit v1.3