From 5cba3b218f332467a81263e2b9914f4f39c19958 Mon Sep 17 00:00:00 2001 From: Robert Noland Date: Sun, 13 Dec 2009 14:55:50 +0000 Subject: MFC 198332 Check pointer for NULL before dereferencing it, not after. Originally committed by: brueffer --- sys/dev/drm/mach64_state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/drm/mach64_state.c b/sys/dev/drm/mach64_state.c index d59d55e7dd67..16848c23ac14 100644 --- a/sys/dev/drm/mach64_state.c +++ b/sys/dev/drm/mach64_state.c @@ -826,7 +826,7 @@ int mach64_dma_vertex(struct drm_device *dev, void *data, struct drm_file *file_priv) { drm_mach64_private_t *dev_priv = dev->dev_private; - drm_mach64_sarea_t *sarea_priv = dev_priv->sarea_priv; + drm_mach64_sarea_t *sarea_priv; drm_mach64_vertex_t *vertex = data; LOCK_TEST_WITH_RETURN(dev, file_priv); @@ -835,6 +835,7 @@ int mach64_dma_vertex(struct drm_device *dev, void *data, DRM_ERROR("called with no initialization\n"); return -EINVAL; } + sarea_priv = dev_priv->sarea_priv; DRM_DEBUG("pid=%d buf=%p used=%lu discard=%d\n", DRM_CURRENTPID, -- cgit v1.3