From e9da08f2eb9b4f396bc91358a18949afbe8cf116 Mon Sep 17 00:00:00 2001 From: Warner Losh Date: Thu, 28 Jun 2007 05:50:14 +0000 Subject: With the advent of G3/CDMA modems, the old buffer sizes are no longer adequate. Increase them to 1k. The referenced PR made this a sysctl, but that seems like overkill to me. The difference between 320 and 2048 bytes in modern systems, even embedded ones, seems to be in the noise to be worth the extra hair to make it settable. PR: 74609 Submitted by: Divacky Roman Approved by: re (blanket) --- sys/dev/usb/umodem.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/dev/usb/umodem.c b/sys/dev/usb/umodem.c index f16f1f98ba18..5f52d97cdeb7 100644 --- a/sys/dev/usb/umodem.c +++ b/sys/dev/usb/umodem.c @@ -132,11 +132,11 @@ static const struct umodem_product { /* * These are the maximum number of bytes transferred per frame. - * If some really high speed devices should use this driver they - * may need to be increased, but this is good enough for normal modems. + * As speeds for umodem deivces increase, these numbers will need to + * be increased. They should be good for G3 speeds and below. */ -#define UMODEMIBUFSIZE 64 -#define UMODEMOBUFSIZE 256 +#define UMODEMIBUFSIZE 1024 +#define UMODEMOBUFSIZE 1024 #define UMODEM_MODVER 1 /* module version */ -- cgit v1.3