From 5ca98fd98791947eba83a1ed3f2c8191ef7afa6c Mon Sep 17 00:00:00 2001 From: Dimitry Andric Date: Mon, 24 Nov 2014 09:08:18 +0000 Subject: Vendor import of llvm RELEASE_350/final tag r216957 (effectively, 3.5.0 release): https://llvm.org/svn/llvm-project/llvm/tags/RELEASE_350/final@216957 --- lib/Object/Binary.cpp | 85 +++++++++++++++------------------------------------ 1 file changed, 25 insertions(+), 60 deletions(-) (limited to 'lib/Object/Binary.cpp') diff --git a/lib/Object/Binary.cpp b/lib/Object/Binary.cpp index de57b4c9a742..552d5db89c54 100644 --- a/lib/Object/Binary.cpp +++ b/lib/Object/Binary.cpp @@ -13,26 +13,22 @@ #include "llvm/Object/Binary.h" #include "llvm/ADT/StringRef.h" -#include "llvm/Support/MemoryBuffer.h" #include "llvm/Support/FileSystem.h" +#include "llvm/Support/MemoryBuffer.h" #include "llvm/Support/Path.h" // Include headers for createBinary. #include "llvm/Object/Archive.h" -#include "llvm/Object/COFF.h" #include "llvm/Object/MachOUniversal.h" #include "llvm/Object/ObjectFile.h" using namespace llvm; using namespace object; -Binary::~Binary() { - delete Data; -} +Binary::~Binary() {} -Binary::Binary(unsigned int Type, MemoryBuffer *Source) - : TypeID(Type) - , Data(Source) {} +Binary::Binary(unsigned int Type, std::unique_ptr Source) + : TypeID(Type), Data(std::move(Source)) {} StringRef Binary::getData() const { return Data->getBuffer(); @@ -42,31 +38,17 @@ StringRef Binary::getFileName() const { return Data->getBufferIdentifier(); } -error_code object::createBinary(MemoryBuffer *Source, - OwningPtr &Result) { - OwningPtr scopedSource(Source); - if (!Source) - return make_error_code(errc::invalid_argument); - sys::fs::file_magic type = sys::fs::identify_magic(Source->getBuffer()); - error_code ec; - switch (type) { - case sys::fs::file_magic::archive: { - OwningPtr ret(new Archive(scopedSource.take(), ec)); - if (ec) return ec; - Result.swap(ret); - return object_error::success; - } +ErrorOr object::createBinary(std::unique_ptr Buffer, + LLVMContext *Context) { + sys::fs::file_magic Type = sys::fs::identify_magic(Buffer->getBuffer()); + + switch (Type) { + case sys::fs::file_magic::archive: + return Archive::create(std::move(Buffer)); case sys::fs::file_magic::elf_relocatable: case sys::fs::file_magic::elf_executable: case sys::fs::file_magic::elf_shared_object: - case sys::fs::file_magic::elf_core: { - OwningPtr ret( - ObjectFile::createELFObjectFile(scopedSource.take())); - if (!ret) - return object_error::invalid_file_type; - Result.swap(ret); - return object_error::success; - } + case sys::fs::file_magic::elf_core: case sys::fs::file_magic::macho_object: case sys::fs::file_magic::macho_executable: case sys::fs::file_magic::macho_fixed_virtual_memory_shared_lib: @@ -76,43 +58,26 @@ error_code object::createBinary(MemoryBuffer *Source, case sys::fs::file_magic::macho_dynamic_linker: case sys::fs::file_magic::macho_bundle: case sys::fs::file_magic::macho_dynamically_linked_shared_lib_stub: - case sys::fs::file_magic::macho_dsym_companion: { - OwningPtr ret( - ObjectFile::createMachOObjectFile(scopedSource.take())); - if (!ret) - return object_error::invalid_file_type; - Result.swap(ret); - return object_error::success; - } - case sys::fs::file_magic::macho_universal_binary: { - OwningPtr ret(new MachOUniversalBinary(scopedSource.take(), ec)); - if (ec) return ec; - Result.swap(ret); - return object_error::success; - } + case sys::fs::file_magic::macho_dsym_companion: case sys::fs::file_magic::coff_object: case sys::fs::file_magic::coff_import_library: - case sys::fs::file_magic::pecoff_executable: { - OwningPtr ret( - ObjectFile::createCOFFObjectFile(scopedSource.take())); - if (!ret) - return object_error::invalid_file_type; - Result.swap(ret); - return object_error::success; - } - case sys::fs::file_magic::unknown: + case sys::fs::file_magic::pecoff_executable: case sys::fs::file_magic::bitcode: - case sys::fs::file_magic::windows_resource: { + return ObjectFile::createSymbolicFile(Buffer, Type, Context); + case sys::fs::file_magic::macho_universal_binary: + return MachOUniversalBinary::create(std::move(Buffer)); + case sys::fs::file_magic::unknown: + case sys::fs::file_magic::windows_resource: // Unrecognized object file format. return object_error::invalid_file_type; - } } llvm_unreachable("Unexpected Binary File Type"); } -error_code object::createBinary(StringRef Path, OwningPtr &Result) { - OwningPtr File; - if (error_code ec = MemoryBuffer::getFileOrSTDIN(Path, File)) - return ec; - return createBinary(File.take(), Result); +ErrorOr object::createBinary(StringRef Path) { + ErrorOr> FileOrErr = + MemoryBuffer::getFileOrSTDIN(Path); + if (std::error_code EC = FileOrErr.getError()) + return EC; + return createBinary(std::move(*FileOrErr)); } -- cgit v1.2.3