From a982c4c7f5f7635683cb70577478397c38bef54b Mon Sep 17 00:00:00 2001 From: Dag-Erling Smørgrav Date: Thu, 11 Feb 2016 17:48:15 +0000 Subject: Fix double-free error: r289419 moved all error handling in http_connect() to the end of the function, but did not remove a fetch_close() call which was made redundant by the one in the shared error-handling code. PR: 206774 Submitted by: Christian Heckendorf MFC after: 3 days --- lib/libfetch/http.c | 1 - 1 file changed, 1 deletion(-) (limited to 'lib/libfetch') diff --git a/lib/libfetch/http.c b/lib/libfetch/http.c index 206648dd464b..ca522a6bcb8c 100644 --- a/lib/libfetch/http.c +++ b/lib/libfetch/http.c @@ -1435,7 +1435,6 @@ http_connect(struct url *URL, struct url *purl, const char *flags) } if (strcasecmp(URL->scheme, SCHEME_HTTPS) == 0 && fetch_ssl(conn, URL, verbose) == -1) { - fetch_close(conn); /* grrr */ errno = EAUTH; fetch_syserr(); -- cgit v1.3