From dacbef689d3fb076f8e4f565dff0ca1e34d74ce1 Mon Sep 17 00:00:00 2001 From: Eitan Adler Date: Thu, 15 Feb 2018 03:22:53 +0000 Subject: devd: don't pass &fds in useless parameters to select(2) select(2) should be declared as restrict. In addition the only fd in the fdset is open O_RDONLY, and it's not a socket that can provide OOB notifications, Reviewed by: ian, imp, vangyzen --- sbin/devd/devd.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'sbin/devd/devd.cc') diff --git a/sbin/devd/devd.cc b/sbin/devd/devd.cc index f3111412fd17..51653e2f8596 100644 --- a/sbin/devd/devd.cc +++ b/sbin/devd/devd.cc @@ -1021,7 +1021,7 @@ event_loop(void) tv.tv_usec = 0; FD_ZERO(&fds); FD_SET(fd, &fds); - rv = select(fd + 1, &fds, &fds, &fds, &tv); + rv = select(fd + 1, &fds, NULL, NULL, &tv); // No events -> we've processed all pending events if (rv == 0) { devdlog(LOG_DEBUG, "Calling daemon\n"); -- cgit v1.3