From 315a0b84cc08ece7d6825bb30eb2e4a294b2f41f Mon Sep 17 00:00:00 2001 From: Robert Watson Date: Sun, 19 Apr 2009 22:04:29 +0000 Subject: Lock interface address list when building a reply to NGM_EIFACE_GET_IFADDRS messages in ng_eiface. MFC after: 2 weeks --- sys/netgraph/ng_eiface.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'sys') diff --git a/sys/netgraph/ng_eiface.c b/sys/netgraph/ng_eiface.c index 542eaadb7a11..eb638fe7e059 100644 --- a/sys/netgraph/ng_eiface.c +++ b/sys/netgraph/ng_eiface.c @@ -452,10 +452,12 @@ ng_eiface_rcvmsg(node_p node, item_p item, hook_p lasthook) /* Determine size of response and allocate it */ buflen = 0; + IF_ADDR_LOCK(ifp); TAILQ_FOREACH(ifa, &ifp->if_addrhead, ifa_link) buflen += SA_SIZE(ifa->ifa_addr); NG_MKRESPONSE(resp, msg, buflen, M_NOWAIT); if (resp == NULL) { + IF_ADDR_UNLOCK(ifp); error = ENOMEM; break; } @@ -474,6 +476,7 @@ ng_eiface_rcvmsg(node_p node, item_p item, hook_p lasthook) ptr += len; buflen -= len; } + IF_ADDR_UNLOCK(ifp); break; } -- cgit v1.3