From a2a8420cfd8732cd21dd1ff9b47d3c5a8ffac0ea Mon Sep 17 00:00:00 2001 From: Pyun YongHyeon Date: Mon, 4 Aug 2008 02:34:40 +0000 Subject: Don't enable TSO by default. Users of RTL8169/8110 reported watchdog timeout issues and the root cause seems to stem from silicon bug of controller. Personally I couldn't reproduce it on RTL8169 controller but it seems it's dependent on usage pattern. For newer PCIe based controllers I have no TSO complaints but turning off TSO would be more safe. Users who are sure that their controller works with TSO can still reenable the TSO with ifconfig(8). Reported by: Oliver Lehmann (lehmann at ans-netz dot de), Eugene Butusov (ebutusov at gmail dot com) --- sys/dev/re/if_re.c | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'sys') diff --git a/sys/dev/re/if_re.c b/sys/dev/re/if_re.c index f549bf50a842..cc96c3b7cf0e 100644 --- a/sys/dev/re/if_re.c +++ b/sys/dev/re/if_re.c @@ -1392,6 +1392,13 @@ re_attach(dev) if (pci_find_extcap(sc->rl_dev, PCIY_PMG, ®) == 0) ifp->if_capabilities |= IFCAP_WOL; ifp->if_capenable = ifp->if_capabilities; + /* + * Don't enable TSO by default. Under certain + * circumtances the controller generated corrupted + * packets in TSO size. + */ + ifp->if_hwassist &= ~CSUM_TSO; + ifp->if_capenable &= ~IFCAP_TSO4; #ifdef DEVICE_POLLING ifp->if_capabilities |= IFCAP_POLLING; #endif -- cgit v1.3